search for: dev_open

...names were not repeatable. >>> >>> This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly. >>> >>> Patch is pending. >> Do we really need to delay the setup until the name is changed? >> Can't we call dev_set_mtu() and dev_open() until dev_change_name() is done? >> >> Thanks >> Sridhar > You can call dev_set_mtu, but when dev_open is done the device name > can not be changed by userspace. I did a quick test to remove the delay and also the dev_open() call and i don't see any issues with virtio...

...names were not repeatable. >>> >>> This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly. >>> >>> Patch is pending. >> Do we really need to delay the setup until the name is changed? >> Can't we call dev_set_mtu() and dev_open() until dev_change_name() is done? >> >> Thanks >> Sridhar > You can call dev_set_mtu, but when dev_open is done the device name > can not be changed by userspace. I did a quick test to remove the delay and also the dev_open() call and i don't see any issues with virtio...

...ev is only doing naming policy > because kernel names were not repeatable. > > This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly. > > Patch is pending. Do we really need to delay the setup until the name is changed? Can't we call dev_set_mtu() and dev_open() until dev_change_name() is done? Thanks Sridhar

...ev is only doing naming policy > because kernel names were not repeatable. > > This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly. > > Patch is pending. Do we really need to delay the setup until the name is changed? Can't we call dev_set_mtu() and dev_open() until dev_change_name() is done? Thanks Sridhar

...chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): net/core/dev.c: In function 'dev_change_name': >> net/core/dev.c:1277:9: error: too few arguments to function 'dev_open' ret = dev_open(dev); ^~~~~~~~ In file included from net/core/dev.c:93:0: include/linux/netdevice.h:2636:5: note: declared here int dev_open(struct net_device *dev, struct netlink_ext_ack *extack); ^~~~~~~~ vim +/dev_open +1277 net/core/dev.c 1166 1167...

...>>> > >>> This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly. > >>> > >>> Patch is pending. > >> Do we really need to delay the setup until the name is changed? > >> Can't we call dev_set_mtu() and dev_open() until dev_change_name() is done? > >> > >> Thanks > >> Sridhar > > You can call dev_set_mtu, but when dev_open is done the device name > > can not be changed by userspace. > I did a quick test to remove the delay and also the dev_open() call and >...

On Mon, 7 May 2018 15:10:44 -0700 Sridhar Samudrala <sridhar.samudrala at intel.com> wrote: > + if (netif_running(failover_dev)) { > + err = dev_open(slave_dev); > + if (err && (err != -EBUSY)) { > + netdev_err(failover_dev, "Opening slave %s failed err:%d\n", > + slave_dev->name, err); > + goto err_dev_open; > + } > + } > + > + netif_addr_lock_bh(failover_dev); > + dev_uc_sync_multiple...

...gt; because kernel names were not repeatable. > > > > This makes the VF show up as "ethN_vf" on Hyper-V which is user friendly. > > > > Patch is pending. > Do we really need to delay the setup until the name is changed? > Can't we call dev_set_mtu() and dev_open() until dev_change_name() is done? > > Thanks > Sridhar You can call dev_set_mtu, but when dev_open is done the device name can not be changed by userspace.

...>+ reopen_needed = true; >+ } > > write_seqcount_begin(&devnet_rename_seq); > >@@ -1198,6 +1215,9 @@ int dev_change_name(struct net_device *dev, const char *newname) > return err; > } > >+ if (reopen_needed) >+ dev_close(dev); Ugh. Don't dev_close/dev_open on name change. >+ > if (oldname[0] && !strchr(oldname, '%')) > netdev_info(dev, "renamed from %s\n", oldname); > >@@ -1210,7 +1230,9 @@ int dev_change_name(struct net_device *dev, const char *newname) > memcpy(dev->name, oldname, IFNAMSIZ); &g...

...ld only > deal with failover master in the long run. > > Fixes: 30c8bd5aa8b2 ("net: Introduce generic failover module") > Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> > Reviewed-by: Liran Alon <liran.alon at oracle.com> Why do you need to do dev_close/dev_open which will bounce the link?

...ld only > deal with failover master in the long run. > > Fixes: 30c8bd5aa8b2 ("net: Introduce generic failover module") > Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> > Reviewed-by: Liran Alon <liran.alon at oracle.com> Why do you need to do dev_close/dev_open which will bounce the link?

Sorry for replying to this ancient thread. There was some remaining issue that I don't think the initial net_failover patch got addressed cleanly, see: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1815268 The renaming of 'eth0' to 'ens4' fails because the udev userspace was not specifically writtten for such kernel automatic enslavement. Specifically, if it is a bond

...;& netif_carrier_ok(dev); +} + +static int net_failover_open(struct net_device *dev) +{ + struct net_failover_info *nfo_info = netdev_priv(dev); + struct net_device *primary_dev, *standby_dev; + int err; + + primary_dev = rtnl_dereference(nfo_info->primary_dev); + if (primary_dev) { + err = dev_open(primary_dev); + if (err) + goto err_primary_open; + } + + standby_dev = rtnl_dereference(nfo_info->standby_dev); + if (standby_dev) { + err = dev_open(standby_dev); + if (err) + goto err_standby_open; + } + + if ((primary_dev && net_failover_xmit_ready(primary_dev)) || + (stan...

...| > | runs `ifup ens3' -> | > | ip link set dev ens3 up | > net_failover_open() | | > dev_open(virtnet_dev) | | > virtnet_open(virtnet_dev) | | > netif_carrier_on(failover_dev) | | > ......

...LL pointer dereference at virtual address 00000002 printing eip: c022d6d2 *pde = ma 00000000 pa 55555000 [<c022ea3a>] e100_alloc_cbs+0x74/0x140 [<c022f5bb>] e100_up+0x39/0x1d6 [<c0127f8b>] queue_delayed_work+0x50/0x6d [<c02307b3>] e100_open+0x23/0x69 [<c031198b>] dev_open+0x8a/0xe6 [<c0312e6e>] dev_change_flags+0x51/0x11f [<c03479d6>] devinet_ioctl+0x4f1/0x5b2 [<c03496b9>] inet_ioctl+0x7e/0xa8 [<c030a026>] sock_ioctl+0x184/0x25d [<c015c4e6>] sys_ioctl+0x16f/0x211 [<c010d1b7>] syscall_call+0x7/0xb Oops: 0002 [#1] Modules link...

...l standby; >> + >> + if (failover_ops) { >> + if (!failover_ops->slave_join) >> + return -EINVAL; >> + >> + return failover_ops->slave_join(slave_dev, failover_dev); >> + } >> + >> + if (netif_running(failover_dev)) { >> + err = dev_open(slave_dev); >> + if (err && (err != -EBUSY)) { >> + netdev_err(failover_dev, "Opening slave %s failed err:%d\n", >> + slave_dev->name, err); >> + goto err_dev_open; >> + } >> + } >> + >> + /* Align MTU of slave with fa...

...| runs `ifup ens3' -> | > > > | ip link set dev ens3 up | > > > net_failover_open() | | > > > dev_open(virtnet_dev) | | > > > virtnet_open(virtnet_dev) | | > > > netif_carrier_on(failover_dev) | | > > > ......

...fo; > + int err, orig_mtu; > + bool standby; > + > + if (failover_ops) { > + if (!failover_ops->slave_join) > + return -EINVAL; > + > + return failover_ops->slave_join(slave_dev, failover_dev); > + } > + > + if (netif_running(failover_dev)) { > + err = dev_open(slave_dev); > + if (err && (err != -EBUSY)) { > + netdev_err(failover_dev, "Opening slave %s failed err:%d\n", > + slave_dev->name, err); > + goto err_dev_open; > + } > + } > + > + /* Align MTU of slave with failover dev */ > + orig_mtu =...

...fo; > + int err, orig_mtu; > + bool standby; > + > + if (failover_ops) { > + if (!failover_ops->slave_join) > + return -EINVAL; > + > + return failover_ops->slave_join(slave_dev, failover_dev); > + } > + > + if (netif_running(failover_dev)) { > + err = dev_open(slave_dev); > + if (err && (err != -EBUSY)) { > + netdev_err(failover_dev, "Opening slave %s failed err:%d\n", > + slave_dev->name, err); > + goto err_dev_open; > + } > + } > + > + /* Align MTU of slave with failover dev */ > + orig_mtu =...

...| runs `ifup ens3' -> | > >> | ip link set dev ens3 up | > >> net_failover_open() | | > >> dev_open(virtnet_dev) | | > >> virtnet_open(virtnet_dev) | | > >> netif_carrier_on(failover_dev) | | > >> ......