search for: dev_hard_start_xmit

...socket limits to stall, socket close to hang, etc.). DaveM points out that there are advantages to doing it generally (it's more likely to be on same CPU than after xmit), and I couldn't find any new starvation issues in simple benchmarking here. This patch adds skb_orphan to the start of dev_hard_start_xmit(): it can be premature in the NETDEV_TX_BUSY case, but that's uncommon. I removed the drivers' skb_orphan(), though it's harmless. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> Cc: Divy Le Ray <divy at chelsio.com> Cc: Roland Dreier <rolandd at cisco.com> C...

...socket limits to stall, socket close to hang, etc.). DaveM points out that there are advantages to doing it generally (it's more likely to be on same CPU than after xmit), and I couldn't find any new starvation issues in simple benchmarking here. This patch adds skb_orphan to the start of dev_hard_start_xmit(): it can be premature in the NETDEV_TX_BUSY case, but that's uncommon. I removed the drivers' skb_orphan(), though it's harmless. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> Cc: Divy Le Ray <divy at chelsio.com> Cc: Roland Dreier <rolandd at cisco.com> C...

...8152db19>] kmemleak_alloc+0x59/0xc0 [<ffffffff81102e93>] __kmalloc+0xf3/0x180 [<ffffffff812db5d6>] vring_add_indirect+0x36/0x280 [<ffffffff812dc59f>] virtqueue_add_outbuf+0xbf/0x4e0 [<ffffffff813a8b30>] start_xmit+0x1a0/0x3b0 [<ffffffff81445861>] dev_hard_start_xmit+0x2d1/0x4d0 [<ffffffff81460052>] sch_direct_xmit+0xf2/0x1c0 [<ffffffff81445c28>] dev_queue_xmit+0x1c8/0x460 [<ffffffff814e3187>] ip6_finish_output2+0x1d7/0x470 [<ffffffff814e34b0>] ip6_finish_output+0x90/0xb0 [<ffffffff814e3507>] ip6_output+0x37/0xb...

...8152db19>] kmemleak_alloc+0x59/0xc0 [<ffffffff81102e93>] __kmalloc+0xf3/0x180 [<ffffffff812db5d6>] vring_add_indirect+0x36/0x280 [<ffffffff812dc59f>] virtqueue_add_outbuf+0xbf/0x4e0 [<ffffffff813a8b30>] start_xmit+0x1a0/0x3b0 [<ffffffff81445861>] dev_hard_start_xmit+0x2d1/0x4d0 [<ffffffff81460052>] sch_direct_xmit+0xf2/0x1c0 [<ffffffff81445c28>] dev_queue_xmit+0x1c8/0x460 [<ffffffff814e3187>] ip6_finish_output2+0x1d7/0x470 [<ffffffff814e34b0>] ip6_finish_output+0x90/0xb0 [<ffffffff814e3507>] ip6_output+0x37/0xb...

...00 00 00 00 00 ........n....... backtrace: [<ffffffff815ed721>] kmemleak_alloc+0x21/0x50 [<ffffffff8111d0b0>] __kmalloc+0xe0/0x160 [<ffffffff81362b7c>] virtqueue_add_buf+0x1fc/0x3d0 [<ffffffff8140cbd3>] start_xmit+0x153/0x3a0 [<ffffffff8150887e>] dev_hard_start_xmit+0x21e/0x470 [<ffffffff815247ce>] sch_direct_xmit+0xfe/0x280 [<ffffffff81509014>] dev_queue_xmit+0x1f4/0x5d0 [<ffffffff81592e91>] ip6_finish_output2+0x101/0x450 [<ffffffff81595ae8>] ip6_finish_output+0x98/0x200 [<ffffffff81595ca1>] ip6_output+0x51/0x...

...00 00 00 00 00 ........n....... backtrace: [<ffffffff815ed721>] kmemleak_alloc+0x21/0x50 [<ffffffff8111d0b0>] __kmalloc+0xe0/0x160 [<ffffffff81362b7c>] virtqueue_add_buf+0x1fc/0x3d0 [<ffffffff8140cbd3>] start_xmit+0x153/0x3a0 [<ffffffff8150887e>] dev_hard_start_xmit+0x21e/0x470 [<ffffffff815247ce>] sch_direct_xmit+0xfe/0x280 [<ffffffff81509014>] dev_queue_xmit+0x1f4/0x5d0 [<ffffffff81592e91>] ip6_finish_output2+0x101/0x450 [<ffffffff81595ae8>] ip6_finish_output+0x98/0x200 [<ffffffff81595ca1>] ip6_output+0x51/0x...

...loc+0x59/0xc0 > [<ffffffff81102e93>] __kmalloc+0xf3/0x180 > [<ffffffff812db5d6>] vring_add_indirect+0x36/0x280 > [<ffffffff812dc59f>] virtqueue_add_outbuf+0xbf/0x4e0 > [<ffffffff813a8b30>] start_xmit+0x1a0/0x3b0 > [<ffffffff81445861>] dev_hard_start_xmit+0x2d1/0x4d0 > [<ffffffff81460052>] sch_direct_xmit+0xf2/0x1c0 > [<ffffffff81445c28>] dev_queue_xmit+0x1c8/0x460 > [<ffffffff814e3187>] ip6_finish_output2+0x1d7/0x470 > [<ffffffff814e34b0>] ip6_finish_output+0x90/0xb0 > [<ffffffff814e3507...

...00000000421628: c030001c3569 larl %r3,7a80fa > [ 8.644106] Call Trace: > [ 8.644110] ([<00000000004214de>] virtqueue_add_outbuf+0x1aa/0x340) > [ 8.644114] [<000003ff80174466>] start_xmit+0x1e6/0x49c [virtio_net] > [ 8.644119] [<000000000050571a>] dev_hard_start_xmit+0x346/0x600 > [ 8.644123] [<000000000052a43c>] sch_direct_xmit+0xe8/0x1e8 > [ 8.644126] [<0000000000505be8>] __dev_queue_xmit+0x214/0x4ec > [ 8.644131] [<000000000054a476>] ip_finish_output+0x436/0x90c > [ 8.644134] [<000000000054b7c0>] ip_queue_x...

...00000000421628: c030001c3569 larl %r3,7a80fa > [ 8.644106] Call Trace: > [ 8.644110] ([<00000000004214de>] virtqueue_add_outbuf+0x1aa/0x340) > [ 8.644114] [<000003ff80174466>] start_xmit+0x1e6/0x49c [virtio_net] > [ 8.644119] [<000000000050571a>] dev_hard_start_xmit+0x346/0x600 > [ 8.644123] [<000000000052a43c>] sch_direct_xmit+0xe8/0x1e8 > [ 8.644126] [<0000000000505be8>] __dev_queue_xmit+0x214/0x4ec > [ 8.644131] [<000000000054a476>] ip_finish_output+0x436/0x90c > [ 8.644134] [<000000000054b7c0>] ip_queue_x...

...loc+0x59/0xc0 > [<ffffffff81102e93>] __kmalloc+0xf3/0x180 > [<ffffffff812db5d6>] vring_add_indirect+0x36/0x280 > [<ffffffff812dc59f>] virtqueue_add_outbuf+0xbf/0x4e0 > [<ffffffff813a8b30>] start_xmit+0x1a0/0x3b0 > [<ffffffff81445861>] dev_hard_start_xmit+0x2d1/0x4d0 > [<ffffffff81460052>] sch_direct_xmit+0xf2/0x1c0 > [<ffffffff81445c28>] dev_queue_xmit+0x1c8/0x460 > [<ffffffff814e3187>] ip6_finish_output2+0x1d7/0x470 > [<ffffffff814e34b0>] ip6_finish_output+0x90/0xb0 > [<ffffffff814e3507...

...c030001c3569 larl %r3,7a80fa >> [ 8.644106] Call Trace: >> [ 8.644110] ([<00000000004214de>] virtqueue_add_outbuf+0x1aa/0x340) >> [ 8.644114] [<000003ff80174466>] start_xmit+0x1e6/0x49c [virtio_net] >> [ 8.644119] [<000000000050571a>] dev_hard_start_xmit+0x346/0x600 >> [ 8.644123] [<000000000052a43c>] sch_direct_xmit+0xe8/0x1e8 >> [ 8.644126] [<0000000000505be8>] __dev_queue_xmit+0x214/0x4ec >> [ 8.644131] [<000000000054a476>] ip_finish_output+0x436/0x90c >> [ 8.644134] [<000000000054b7c0...

...loc+0x59/0xc0 > [<ffffffff81102e93>] __kmalloc+0xf3/0x180 > [<ffffffff812db5d6>] vring_add_indirect+0x36/0x280 > [<ffffffff812dc59f>] virtqueue_add_outbuf+0xbf/0x4e0 > [<ffffffff813a8b30>] start_xmit+0x1a0/0x3b0 > [<ffffffff81445861>] dev_hard_start_xmit+0x2d1/0x4d0 > [<ffffffff81460052>] sch_direct_xmit+0xf2/0x1c0 > [<ffffffff81445c28>] dev_queue_xmit+0x1c8/0x460 > [<ffffffff814e3187>] ip6_finish_output2+0x1d7/0x470 > [<ffffffff814e34b0>] ip6_finish_output+0x90/0xb0 > [<ffffffff814e3507...

...queue_xmit_nit+0x5cd/0xaf0 > > [ 310.021168] start_xmit+0x1b4/0x1b10 [virtio_net] > > [ 310.022413] ? default_device_exit+0x2d0/0x2d0 > > [ 310.023634] ? virtnet_remove+0xf0/0xf0 [virtio_net] > > [ 310.024874] ? update_load_avg+0x1281/0x29f0 > > [ 310.026059] dev_hard_start_xmit+0x1ea/0x7f0 > > [ 310.027247] ? validate_xmit_skb_list+0x100/0x100 > > [ 310.028470] ? validate_xmit_skb+0x7f/0xc10 > > [ 310.029731] ? netif_skb_features+0x920/0x920 > > [ 310.033469] ? __skb_tx_hash+0x2f0/0x2f0 > > [ 310.035615] ? validate_xmit_skb_list+0xa...

...queue_xmit_nit+0x5cd/0xaf0 > > [ 310.021168] start_xmit+0x1b4/0x1b10 [virtio_net] > > [ 310.022413] ? default_device_exit+0x2d0/0x2d0 > > [ 310.023634] ? virtnet_remove+0xf0/0xf0 [virtio_net] > > [ 310.024874] ? update_load_avg+0x1281/0x29f0 > > [ 310.026059] dev_hard_start_xmit+0x1ea/0x7f0 > > [ 310.027247] ? validate_xmit_skb_list+0x100/0x100 > > [ 310.028470] ? validate_xmit_skb+0x7f/0xc10 > > [ 310.029731] ? netif_skb_features+0x920/0x920 > > [ 310.033469] ? __skb_tx_hash+0x2f0/0x2f0 > > [ 310.035615] ? validate_xmit_skb_list+0xa...

...21 lgr %r2,%r1 0000000000421628: c030001c3569 larl %r3,7a80fa [ 8.644106] Call Trace: [ 8.644110] ([<00000000004214de>] virtqueue_add_outbuf+0x1aa/0x340) [ 8.644114] [<000003ff80174466>] start_xmit+0x1e6/0x49c [virtio_net] [ 8.644119] [<000000000050571a>] dev_hard_start_xmit+0x346/0x600 [ 8.644123] [<000000000052a43c>] sch_direct_xmit+0xe8/0x1e8 [ 8.644126] [<0000000000505be8>] __dev_queue_xmit+0x214/0x4ec [ 8.644131] [<000000000054a476>] ip_finish_output+0x436/0x90c [ 8.644134] [<000000000054b7c0>] ip_queue_xmit+0x170/0x3e8 [...

...e02 00000000 cf914400 cf5db200 c07fc448 00000140 d1232e6e 00000001 c08a8e02 cf914000 cf88c200 00000002 cf5db200 0000004e d126c000 cf914000 0000004e c08a8e02 cf88c140 cf88c140 cf88c200 c07c4c88 Call Trace: [<d1232e6e>] boomerang_start_xmit+0x141/0x352 [3c59x] [<c05aec59>] dev_hard_start_xmit+0x198/0x1ee [<c05bcaf6>] __qdisc_run+0xe4/0x19a [<c05b0544>] dev_queue_xmit+0x1e0/0x2e8 [<c05b4b24>] neigh_resolve_output+0x1b2/0x1dc [<d136eb2e>] ip6_output2+0x256/0x2a7 [ipv6] [<d136f656>] ip6_output+0x9c7/0x9f3 [ipv6] [<d137c8c0>] dst_output+0x0/0x7 [ipv...

...000004 cc83f160 cd2130c0 cd215bc0 cd2130c0 cd215bc0 c021734b c030bdb4 c0307a60 0000000a cceee800 cceee800 cd215bc0 cd1f3160 00000000 c021896b c0307a60 cd215bc0 cd215bc0 cceee800 cd1f3160 c025f1c6 00000000 Call Trace: [<c0212cc4>] __kfree_skb+0x84/0xe0 [<c021734b>] dev_hard_start_xmit+0x1bb/0x1d0 [<c021896b>] dev_queue_xmit+0x11b/0x1b0 [<c025f1c6>] ip6_output2+0x276/0x2b0 [<c025ed30>] ip6_output_finish+0x0/0xf0 [<c025fc0a>] ip6_output+0x90a/0x940 [<c013e9e5>] cache_alloc_refill+0x2c5/0x3f0 [<c0212eed>] pskb_expand_head+0xdd/0x130...

...f7ed4008000 CR3: 0000000289e1a000 CR4: 00000000001406e0 [ 728.983778] Call Trace: [ 728.984107] <IRQ> [ 728.984368] [<ffffffffae7df612>] skb_to_sgvec+0x12/0x30 [ 728.985098] [<ffffffffc00fa4bf>] start_xmit+0x19f/0x500 [virtio_net] [ 728.985925] [<ffffffffae7f02e6>] dev_hard_start_xmit+0x246/0x3b0 [ 728.986741] [<ffffffffae81bc0a>] sch_direct_xmit+0x11a/0x250 [ 728.987489] [<ffffffffae81bdce>] __qdisc_run+0x8e/0x360 [ 728.988182] [<ffffffffae7ef3e6>] net_tx_action+0x1d6/0x240 [ 728.988924] [<ffffffffae29dba5>] __do_softirq+0xf5/0x280 [ 728.989634]...

...000000 ffffffa3 00000003 cd9e32e0 00000002 c63a7900 c04dcfb0 cd9e32e0 00000003 00000000 cd9e32e0 cf8e3000 cf8e3140 c04dd07e cd9e32e0 cf8e3000 00000000 cd9e32e0 cf8e3000 c04ec07e cd9e32e0 cf8e3000 c0895140 Call Trace: [<c04dcfb0>] dev_gso_segment+0x30/0xb0 [<c04dd07e>] dev_hard_start_xmit+0x4e/0x110 [<c04ec07e>] __qdisc_run+0xbe/0x280 [<c04dd4b9>] dev_queue_xmit+0x379/0x380 [<c05bbe44>] br_dev_queue_push_xmit+0xa4/0x140 [<c05c2402>] br_nf_post_routing+0x102/0x1d0 [<c05c22b0>] br_nf_dev_queue_xmit+0x0/0x50 [<c05bbda0>] br_dev_queue_push_xmit+...

...fffffff8002f73b>] dev_queue_xmit+0x0/0x271 Oct 14 16:25:07 localhost kernel: [<ffffffff881987c6>] :8139cp:cp_start_xmit+0x4ef/0x511 Oct 14 16:25:07 localhost kernel: [<ffffffff8819842d>] :8139cp:cp_start_xmit+0x156/0x511 Oct 14 16:25:07 localhost kernel: [<ffffffff8022eede>] dev_hard_start_xmit+0x1b7/0x28a Oct 14 16:25:08 localhost kernel: [<ffffffff8023f0b8>] __qdisc_run+0x136/0x1f9 Oct 14 16:25:08 localhost kernel: [<ffffffff8002f88b>] dev_queue_xmit+0x150/0x271 Oct 14 16:25:08 localhost kernel: [<ffffffff80031f87>] ip_output+0x2ae/0x2dd Oct 14 16:25:08 localhost ke...