search for: dev_close

...andby_dev); + if (err) + goto err_standby_open; + } + + if ((primary_dev && net_failover_xmit_ready(primary_dev)) || + (standby_dev && net_failover_xmit_ready(standby_dev))) { + netif_carrier_on(dev); + netif_tx_wake_all_queues(dev); + } + + return 0; + +err_standby_open: + dev_close(primary_dev); +err_primary_open: + netif_tx_disable(dev); + return err; +} + +static int net_failover_close(struct net_device *dev) +{ + struct net_failover_info *nfo_info = netdev_priv(dev); + struct net_device *slave_dev; + + netif_tx_disable(dev); + + slave_dev = rtnl_dereference(nfo_info->pr...

...gt; >> > >> write_seqcount_begin(&devnet_rename_seq); > >> > >> @@ -1198,6 +1215,9 @@ int dev_change_name(struct net_device *dev, const char *newname) > >> return err; > >> } > >> > >> + if (reopen_needed) > >> + dev_close(dev); > > Ugh. Don't dev_close/dev_open on name change. > See my response to Michael and Stephen. What's your suggestion then? To a DEV_CHANGE notification instead? My opinion is that allowing name change is not worth the doing. Also, the kernel should never do the name chan...

...F_FAILOVER_SLAVE))) >+ return -EBUSY; >+ reopen_needed = true; >+ } > > write_seqcount_begin(&devnet_rename_seq); > >@@ -1198,6 +1215,9 @@ int dev_change_name(struct net_device *dev, const char *newname) > return err; > } > >+ if (reopen_needed) >+ dev_close(dev); Ugh. Don't dev_close/dev_open on name change. >+ > if (oldname[0] && !strchr(oldname, '%')) > netdev_info(dev, "renamed from %s\n", oldname); > >@@ -1210,7 +1230,9 @@ int dev_change_name(struct net_device *dev, const char *newname) > me...

...andby_dev); + if (err) + goto err_standby_open; + } + + if ((primary_dev && net_failover_xmit_ready(primary_dev)) || + (standby_dev && net_failover_xmit_ready(standby_dev))) { + netif_carrier_on(dev); + netif_tx_wake_all_queues(dev); + } + + return 0; + +err_standby_open: + dev_close(primary_dev); +err_primary_open: + netif_tx_disable(dev); + return err; +} + +static int net_failover_close(struct net_device *dev) +{ + struct net_failover_info *nfo_info = netdev_priv(dev); + struct net_device *slave_dev; + + netif_tx_disable(dev); + + slave_dev = rtnl_dereference(nfo_info->pr...

...ts); > + failover_dev->min_mtu = slave_dev->min_mtu; > + failover_dev->max_mtu = slave_dev->max_mtu; > + } > + > + netdev_info(failover_dev, "failover slave:%s joined\n", > + slave_dev->name); > + > + return 0; > + > +err_set_mtu: > + dev_close(slave_dev); > +err_dev_open: > + return err; > +} > + > +/* Called when slave dev is injecting data into network stack. > + * Change the associated network device from lower dev to virtio. > + * note: already called with rcu_read_lock > + */ > +static rx_handler_result_t...

...ts); > + failover_dev->min_mtu = slave_dev->min_mtu; > + failover_dev->max_mtu = slave_dev->max_mtu; > + } > + > + netdev_info(failover_dev, "failover slave:%s joined\n", > + slave_dev->name); > + > + return 0; > + > +err_set_mtu: > + dev_close(slave_dev); > +err_dev_open: > + return err; > +} > + > +/* Called when slave dev is injecting data into network stack. > + * Change the associated network device from lower dev to virtio. > + * note: already called with rcu_read_lock > + */ > +static rx_handler_result_t...

...r_join; >+ >+ call_netdevice_notifiers(NETDEV_JOIN, slave_netdev); >+ >+ netdev_info(bypass_netdev, "bypass slave:%s registered\n", >+ slave_netdev->name); >+ >+ goto done; >+ >+err_join: >+ dev_set_mtu(slave_netdev, orig_mtu); >+err_set_mtu: >+ dev_close(slave_netdev); >+err_interface_up: >+ netdev_upper_dev_unlink(slave_netdev, bypass_netdev); >+ slave_netdev->priv_flags &= ~IFF_BYPASS_SLAVE; >+upper_link_failed: >+ netdev_rx_handler_unregister(slave_netdev); >+done: >+ return NOTIFY_DONE; >+} >+ >+static int b...

...r_join; >+ >+ call_netdevice_notifiers(NETDEV_JOIN, slave_netdev); >+ >+ netdev_info(bypass_netdev, "bypass slave:%s registered\n", >+ slave_netdev->name); >+ >+ goto done; >+ >+err_join: >+ dev_set_mtu(slave_netdev, orig_mtu); >+err_set_mtu: >+ dev_close(slave_netdev); >+err_interface_up: >+ netdev_upper_dev_unlink(slave_netdev, bypass_netdev); >+ slave_netdev->priv_flags &= ~IFF_BYPASS_SLAVE; >+upper_link_failed: >+ netdev_rx_handler_unregister(slave_netdev); >+done: >+ return NOTIFY_DONE; >+} >+ >+static int b...

...nents should only > deal with failover master in the long run. > > Fixes: 30c8bd5aa8b2 ("net: Introduce generic failover module") > Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> > Reviewed-by: Liran Alon <liran.alon at oracle.com> Why do you need to do dev_close/dev_open which will bounce the link?

...nents should only > deal with failover master in the long run. > > Fixes: 30c8bd5aa8b2 ("net: Introduce generic failover module") > Signed-off-by: Si-Wei Liu <si-wei.liu at oracle.com> > Reviewed-by: Liran Alon <liran.alon at oracle.com> Why do you need to do dev_close/dev_open which will bounce the link?

..._netdev, bypass_ops); + if (ret != 0) + goto err_join; + + call_netdevice_notifiers(NETDEV_JOIN, slave_netdev); + + netdev_info(bypass_netdev, "bypass slave:%s registered\n", + slave_netdev->name); + + goto done; + +err_join: + dev_set_mtu(slave_netdev, orig_mtu); +err_set_mtu: + dev_close(slave_netdev); +err_interface_up: + netdev_upper_dev_unlink(slave_netdev, bypass_netdev); + slave_netdev->priv_flags &= ~IFF_BYPASS_SLAVE; +upper_link_failed: + netdev_rx_handler_unregister(slave_netdev); +done: + return NOTIFY_DONE; +} + +static int bypass_slave_pre_unregister(struct net_de...

...stats(finfo->primary_dev, &finfo->primary_stats); + failover_dev->min_mtu = slave_dev->min_mtu; + failover_dev->max_mtu = slave_dev->max_mtu; + } + + netdev_info(failover_dev, "failover slave:%s joined\n", + slave_dev->name); + + return 0; + +err_set_mtu: + dev_close(slave_dev); +err_dev_open: + return err; +} + +/* Called when slave dev is injecting data into network stack. + * Change the associated network device from lower dev to virtio. + * note: already called with rcu_read_lock + */ +static rx_handler_result_t failover_handle_frame(struct sk_buff **pskb)...

...pen(dev, child_netdev); + + return 0; +} + +static int virtnet_bypass_close(struct net_device *dev) +{ + struct virtnet_bypass_info *vi = netdev_priv(dev); + struct net_device *child_netdev; + + netif_tx_disable(dev); + + child_netdev = rtnl_dereference(vi->active_netdev); + if (child_netdev) + dev_close(child_netdev); + + child_netdev = rtnl_dereference(vi->backup_netdev); + if (child_netdev) + dev_close(child_netdev); + + return 0; +} + +static netdev_tx_t +virtnet_bypass_drop_xmit(struct sk_buff *skb, struct net_device *dev) +{ + atomic_long_inc(&dev->tx_dropped); + dev_kfree_skb_any(...

...ev); + if (active_netdev) { + err = dev_open(active_netdev); + if (err) + goto err_active_open; + } + + backup_netdev = rtnl_dereference(vbi->backup_netdev); + if (backup_netdev) { + err = dev_open(backup_netdev); + if (err) + goto err_backup_open; + } + + return 0; + +err_backup_open: + dev_close(active_netdev); +err_active_open: + netif_tx_disable(dev); + return err; +} + +static int virtnet_bypass_close(struct net_device *dev) +{ + struct virtnet_bypass_info *vi = netdev_priv(dev); + struct net_device *child_netdev; + + netif_tx_disable(dev); + + child_netdev = rtnl_dereference(vi->act...

...slave_dev->min_mtu; >> + failover_dev->max_mtu = slave_dev->max_mtu; >> + } >> + >> + netdev_info(failover_dev, "failover slave:%s joined\n", >> + slave_dev->name); >> + >> + return 0; >> + >> +err_set_mtu: >> + dev_close(slave_dev); >> +err_dev_open: >> + return err; >> +} >> + >> +/* Called when slave dev is injecting data into network stack. >> + * Change the associated network device from lower dev to virtio. >> + * note: already called with rcu_read_lock >> + */ &...

...V_JOIN, slave_netdev); >> + >> + netdev_info(bypass_netdev, "bypass slave:%s registered\n", >> + slave_netdev->name); >> + >> + goto done; >> + >> +err_join: >> + dev_set_mtu(slave_netdev, orig_mtu); >> +err_set_mtu: >> + dev_close(slave_netdev); >> +err_interface_up: >> + netdev_upper_dev_unlink(slave_netdev, bypass_netdev); >> + slave_netdev->priv_flags &= ~IFF_BYPASS_SLAVE; >> +upper_link_failed: >> + netdev_rx_handler_unregister(slave_netdev); >> +done: >> + return NOTIFY_D...

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct attached SR-IOV VF devices. Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used

...opying what I think is useful from the screen: EIP is at br_device_event+0x94/0x110 [bridge] ... Process ifconfig (pid 22092, threadinfo:c18e9999 task:c165c600) Stack: ....(I assume this is ifconfig's stack, and probably not a lot of interest to the problem...) Call Trace: notifier_call_chain dev_close dev_change_flags devinet_ioctl inet_ioctl sock_ioctl do_ioctl do_page_fault vfs_ioctl sys_ioctl sysenter_past_esp .... (0)Kernel panic- not syncing: Fatal exception in interrupt Note- may have some typos, this is actually a PVR box plugged into a tv- not the easiest to work with ;-) Hope that...

This is another update based on feedback from MST and Stephen on the last patchset. Hopefully this series can be integrated and any further enhancements can be made on top of this patchset. v8: - Made the failover managment routines more robust by updating the feature bits/other fields in the failover netdev when slave netdevs are registered/unregistered. (mst) - added support for handling

Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be used by hypervisor to indicate that virtio_net interface should act as a backup for another device with the same MAC address. Ppatch 2 is in response to the community request for a 3 netdev solution. However, it creates some issues we'll get into in a moment. It extends virtio_net to use alternate datapath when available