search for: dev_attr_seri

...WUSR, virtblk_cache_type_show, virtblk_cache_type_store); @@ -550,6 +550,26 @@ static struct blk_mq_ops virtio_mq_ops = { static unsigned int virtblk_queue_depth; module_param_named(queue_depth, virtblk_queue_depth, uint, 0444); +static struct attribute *virtblk_attrs_ro[] = { + &dev_attr_serial.attr, + &dev_attr_cache_type_ro.attr, + NULL +}; + +static struct attribute *virtblk_attrs_rw[] = { + &dev_attr_serial.attr, + &dev_attr_cache_type_rw.attr, + NULL +}; + +static struct attribute_group virtblk_attr_group_ro = { + .attrs = virtblk_attrs_ro, +}; + +static struct attribu...

...dev, + struct device_attribute *attr, char *buf) +{ + struct input_dev *idev = to_input_dev(dev); + struct virtio_input *vi = input_get_drvdata(idev); + + return sprintf(buf, "%s\n", vi->serial); +} +static DEVICE_ATTR_RO(serial); + +static struct attribute *dev_attrs[] = { + &dev_attr_serial.attr, + NULL +}; + +static umode_t dev_attrs_are_visible(struct kobject *kobj, + struct attribute *a, int n) +{ + struct device *dev = container_of(kobj, struct device, kobj); + struct input_dev *idev = to_input_dev(dev); + struct virtio_input *vi = input_get_drvdata(idev); + + if (a == &...

...dev, + struct device_attribute *attr, char *buf) +{ + struct input_dev *idev = to_input_dev(dev); + struct virtio_input *vi = input_get_drvdata(idev); + + return sprintf(buf, "%s\n", vi->serial); +} +static DEVICE_ATTR_RO(serial); + +static struct attribute *dev_attrs[] = { + &dev_attr_serial.attr, + NULL +}; + +static umode_t dev_attrs_are_visible(struct kobject *kobj, + struct attribute *a, int n) +{ + struct device *dev = container_of(kobj, struct device, kobj); + struct input_dev *idev = to_input_dev(dev); + struct virtio_input *vi = input_get_drvdata(idev); + + if (a == &...

...struct virtio_input *vi = input_get_drvdata(idev); > > + return sprintf(buf, "%s\n", vi->serial); > > +} > > +static DEVICE_ATTR_RO(serial); What is serial? Serial number? > > + > > +static struct attribute *dev_attrs[] = { > > + &dev_attr_serial.attr, > > + NULL > > +}; > > + > > +static umode_t dev_attrs_are_visible(struct kobject *kobj, > > + struct attribute *a, int n) > > +{ > > + struct device *dev = container_of(kobj, struct device, kobj); >...

...struct virtio_input *vi = input_get_drvdata(idev); > > + return sprintf(buf, "%s\n", vi->serial); > > +} > > +static DEVICE_ATTR_RO(serial); What is serial? Serial number? > > + > > +static struct attribute *dev_attrs[] = { > > + &dev_attr_serial.attr, > > + NULL > > +}; > > + > > +static umode_t dev_attrs_are_visible(struct kobject *kobj, > > + struct attribute *a, int n) > > +{ > > + struct device *dev = container_of(kobj, struct device, kobj); >...

...virtblk_serial_show, NULL); + static int __devinit virtblk_probe(struct virtio_device *vdev) { struct virtio_blk *vblk; @@ -445,8 +470,15 @@ static int __devinit virtblk_probe(struct virtio_device *vdev) add_disk(vblk->disk); + err = device_create_file(disk_to_dev(vblk->disk), &dev_attr_serial); + if (err) + goto out_del_disk; + return 0; +out_del_disk: + del_gendisk(vblk->disk); + blk_cleanup_queue(vblk->disk->queue); out_put_disk: put_disk(vblk->disk); out_mempool: -- 1.6.3.3

...virtblk_serial_show, NULL); + static int __devinit virtblk_probe(struct virtio_device *vdev) { struct virtio_blk *vblk; @@ -445,8 +470,15 @@ static int __devinit virtblk_probe(struct virtio_device *vdev) add_disk(vblk->disk); + err = device_create_file(disk_to_dev(vblk->disk), &dev_attr_serial); + if (err) + goto out_del_disk; + return 0; +out_del_disk: + del_gendisk(vblk->disk); + blk_cleanup_queue(vblk->disk->queue); out_put_disk: put_disk(vblk->disk); out_mempool: -- 1.6.3.3

Hi, This patch adds a virtio driver for input devices. Specification: https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007 Qemu patches; https://lists.gnu.org/archive/html/qemu-devel/2015-03/threads.html#03973 Gerd Hoffmann (1): Add virtio-input driver. drivers/virtio/Kconfig | 10 ++

Hi, This patch adds a virtio driver for input devices. Specification: https://www.kraxel.org/cgit/virtio-spec/log/?h=virtio-input https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-input.html#x1-2640007 Qemu patches; https://lists.gnu.org/archive/html/qemu-devel/2015-03/threads.html#03973 Gerd Hoffmann (1): Add virtio-input driver. drivers/virtio/Kconfig | 10 ++

...+ struct input_dev *idev = to_input_dev(dev); > + struct virtio_input *vi = input_get_drvdata(idev); > + return sprintf(buf, "%s\n", vi->serial); > +} > +static DEVICE_ATTR_RO(serial); > + > +static struct attribute *dev_attrs[] = { > + &dev_attr_serial.attr, > + NULL > +}; > + > +static umode_t dev_attrs_are_visible(struct kobject *kobj, > + struct attribute *a, int n) > +{ > + struct device *dev = container_of(kobj, struct device, kobj); > + struct input_dev *idev = t...

...+ struct input_dev *idev = to_input_dev(dev); > + struct virtio_input *vi = input_get_drvdata(idev); > + return sprintf(buf, "%s\n", vi->serial); > +} > +static DEVICE_ATTR_RO(serial); > + > +static struct attribute *dev_attrs[] = { > + &dev_attr_serial.attr, > + NULL > +}; > + > +static umode_t dev_attrs_are_visible(struct kobject *kobj, > + struct attribute *a, int n) > +{ > + struct device *dev = container_of(kobj, struct device, kobj); > + struct input_dev *idev = t...

...*dev, + struct device_attribute *attr, char *buf) +{ + struct input_dev *idev = to_input_dev(dev); + struct virtio_input *vi = input_get_drvdata(idev); + return sprintf(buf, "%s\n", vi->serial); +} +static DEVICE_ATTR_RO(serial); + +static struct attribute *dev_attrs[] = { + &dev_attr_serial.attr, + NULL +}; + +static umode_t dev_attrs_are_visible(struct kobject *kobj, + struct attribute *a, int n) +{ + struct device *dev = container_of(kobj, struct device, kobj); + struct input_dev *idev = to_input_dev(dev); + struct virtio_input *vi = input_get_drvdata(idev); + + if (a == &...

...*dev, + struct device_attribute *attr, char *buf) +{ + struct input_dev *idev = to_input_dev(dev); + struct virtio_input *vi = input_get_drvdata(idev); + return sprintf(buf, "%s\n", vi->serial); +} +static DEVICE_ATTR_RO(serial); + +static struct attribute *dev_attrs[] = { + &dev_attr_serial.attr, + NULL +}; + +static umode_t dev_attrs_are_visible(struct kobject *kobj, + struct attribute *a, int n) +{ + struct device *dev = container_of(kobj, struct device, kobj); + struct input_dev *idev = to_input_dev(dev); + struct virtio_input *vi = input_get_drvdata(idev); + + if (a == &...

.../block/virtio_blk.c @@ -719,6 +719,8 @@ static int virtblk_probe(struct virtio_device *vdev) if (!err && opt_io_size) blk_queue_io_opt(q, blk_size * opt_io_size); + virtio_enable_vqs_early(vdev); + add_disk(vblk->disk); err = device_create_file(disk_to_dev(vblk->disk), &dev_attr_serial); if (err) -- MST

.../block/virtio_blk.c @@ -719,6 +719,8 @@ static int virtblk_probe(struct virtio_device *vdev) if (!err && opt_io_size) blk_queue_io_opt(q, blk_size * opt_io_size); + virtio_enable_vqs_early(vdev); + add_disk(vblk->disk); err = device_create_file(disk_to_dev(vblk->disk), &dev_attr_serial); if (err) -- MST

Using Rusty's suggestion I've respun the patch removing the special copy function. I've tested this patch in a guest kernel with and without qemu supplying serial numbers for the block devices and it's working as expected. When qemu supplies serial numbers, the correct value is supplied to /sys/block/vdX/serial and can be used by udev for generating disk/by-id paths (without

Using Rusty's suggestion I've respun the patch removing the special copy function. I've tested this patch in a guest kernel with and without qemu supplying serial numbers for the block devices and it's working as expected. When qemu supplies serial numbers, the correct value is supplied to /sys/block/vdX/serial and can be used by udev for generating disk/by-id paths (without

...char *buf) > +{ > + struct input_dev *idev = to_input_dev(dev); > + struct virtio_input *vi = input_get_drvdata(idev); > + return sprintf(buf, "%s\n", vi->serial); > +} > +static DEVICE_ATTR_RO(serial); > + > +static struct attribute *dev_attrs[] = { > + &dev_attr_serial.attr, > + NULL > +}; > + > +static umode_t dev_attrs_are_visible(struct kobject *kobj, > + struct attribute *a, int n) > +{ > + struct device *dev = container_of(kobj, struct device, kobj); > + struct input_dev *idev = to_input_dev(dev); > + struct virtio_input...

...char *buf) > +{ > + struct input_dev *idev = to_input_dev(dev); > + struct virtio_input *vi = input_get_drvdata(idev); > + return sprintf(buf, "%s\n", vi->serial); > +} > +static DEVICE_ATTR_RO(serial); > + > +static struct attribute *dev_attrs[] = { > + &dev_attr_serial.attr, > + NULL > +}; > + > +static umode_t dev_attrs_are_visible(struct kobject *kobj, > + struct attribute *a, int n) > +{ > + struct device *dev = container_of(kobj, struct device, kobj); > + struct input_dev *idev = to_input_dev(dev); > + struct virtio_input...

This is an attempt to fix the issue that some disks' sysfs attributes are not ready at the time its KOBJ_ADD event is sent. The symptom is during device hotplug, udev may fail to find certain attributes, such as serial or wwn, of the disk. As a result the /dev/disk/by-id entries are not created. The cause is device_add_disk emits the uevent before returning, and the callers have to create