Displaying 3 results from an estimated 3 matches for "detac_buf_packed".
Did you mean:
detach_buf_packed
2018 May 10
2
[RFC v3 3/5] virtio_ring: add packed ring support
On Thu, May 10, 2018 at 03:34:50PM +0800, Jason Wang wrote:
> On 2018?05?10? 15:32, Jason Wang wrote:
> > On 2018?04?25? 13:15, Tiwei Bie wrote:
> > > +??? /* We're using some buffers from the free list. */
> > > +??? vq->vq.num_free -= descs_used;
> > > +
> > > +??? /* Update free pointer */
> > > +??? if (indirect) {
> > >
2018 May 10
2
[RFC v3 3/5] virtio_ring: add packed ring support
On Thu, May 10, 2018 at 03:34:50PM +0800, Jason Wang wrote:
> On 2018?05?10? 15:32, Jason Wang wrote:
> > On 2018?04?25? 13:15, Tiwei Bie wrote:
> > > +??? /* We're using some buffers from the free list. */
> > > +??? vq->vq.num_free -= descs_used;
> > > +
> > > +??? /* Update free pointer */
> > > +??? if (indirect) {
> > >
2018 May 10
0
[RFC v3 3/5] virtio_ring: add packed ring support
...driver may think buffer id 0 is
>>> available and try to use it if even if the real buffer 0 was not done.
>>>
>>> Thanks
> Nice catch! Thanks a lot!
> I'll implement an ID allocator.
>
> Best regards,
> Tiwei Bie
Sounds good.
Another similar issue is detac_buf_packed(). It did:
??????? for (j = 0; j < vq->desc_state[head].num; j++) {
??????????????? desc = &vq->vring_packed.desc[i];
??????????????? vring_unmap_one_packed(vq, desc);
??????????????? i++;
??????????????? if (i >= vq->vring_packed.num)
??????????????????????? i = 0;
?????...