search for: dest_fd

...return -1; } - dest_is_dev = STRPREFIX (dest, "/dev/"); + dest_is_dev = is_device_parameter (dest); if (dest_is_dev) r = asprintf (&of_arg, "of=%s", dest); @@ -71,7 +71,7 @@ do_copy_size (const char *src, const char *dest, int64_t ssize) { int src_fd, dest_fd; - if (STRPREFIX (src, "/dev/")) + if (is_device_parameter (src)) src_fd = open (src, O_RDONLY | O_CLOEXEC); else { CLEANUP_FREE char *buf = sysroot_path (src); @@ -86,7 +86,7 @@ do_copy_size (const char *src, const char *dest, int64_t ssize) return -1; } - if...

Various changes/fixes to use smaller stack frames. Rich.

...nd_file_write (buf, r) < 0) { pclose (fp); return -1; diff --git a/daemon/copy.c b/daemon/copy.c index 6f3e844..2a6720b 100644 --- a/daemon/copy.c +++ b/daemon/copy.c @@ -50,11 +50,17 @@ copy (const char *src, const char *src_display, { int64_t saved_size = size; int src_fd, dest_fd; - char buf[BUFSIZ]; + CLEANUP_FREE char *buf = NULL; size_t n; ssize_t r; int err; + buf = malloc (BUFSIZ); + if (buf == NULL) { + reply_with_perror ("malloc"); + return -1; + } + if ((optargs_bitmask & GUESTFS_COPY_DEVICE_TO_DEVICE_SRCOFFSET_BITMASK)) {...

This is an updated and extended version of the original patch: https://www.redhat.com/archives/libguestfs/2010-August/msg00163.html This adds OCaml and Perl bindings (both tested), support for progress bars in virt-resize, and adds progress notifications to a number of the simpler commands. Still to do is to add progress messages to more commands. There are still a few commands which would be

https://bugzilla.redhat.com/show_bug.cgi?id=1477623 The first two patches are cleanups. The third patch changes the way that we handle Device and Dev_or_Path parameters so that a parameter marked as such can really only contain a block device name (and not, for instance, a chardev). Using a chardev here caused hangs in the API. The next two patches fix API usage to conform to this new stricter