search for: dest_buf

...to_device (const char *src, const char *dest, int do_copy_device_to_file (const char *src, const char *dest, int64_t srcoffset, int64_t destoffset, int64_t size, - int sparse) + int sparse, int append) { CLEANUP_FREE char *dest_buf = sysroot_path (dest); + int wrflags = O_WRONLY|O_CREAT|O_NOCTTY|O_CLOEXEC; if (!dest_buf) { reply_with_perror ("malloc"); return -1; } - return copy (src, src, dest_buf, dest, DEST_FILE_FLAGS, 0, + if ((optargs_bitmask & GUESTFS_COPY_DEVICE_TO_FILE_APPEND_BITMA...

...har *dest, > int > do_copy_device_to_file (const char *src, const char *dest, > int64_t srcoffset, int64_t destoffset, int64_t size, > - int sparse) > + int sparse, int append) > { > CLEANUP_FREE char *dest_buf = sysroot_path (dest); > + int wrflags = O_WRONLY|O_CREAT|O_NOCTTY|O_CLOEXEC; Cannot DEST_FILE_FLAGS (without O_TRUNC, of course) be used here (and below) to avoid copying&pasting these attributes? > > if (!dest_buf) { > reply_with_perror ("malloc"); >...

...mail_cache_seq (seq=<optimized out>, view=0x7fc4a81332b0) at mail-cache-lookup.c:322 #3 mail_cache_field_exists (view=view at entry=0x7fc4a81332b0, seq=seq at entry=760, field=field at entry=4) at mail-cache-lookup.c:352 #4 0x00007fc4a69f3151 in mail_cache_lookup_field (view=0x7fc4a81332b0, dest_buf=dest_buf at entry=0x7ffe23a98a00, seq=760, field_idx=field_idx at entry =4) at mail-cache-lookup.c:413 #5 0x00007fc4a69d9439 in index_mail_cache_lookup_field (mail=mail at entry=0x7fc4a8128cd0, buf=buf at entry=0x7ffe23a98a00, field_idx=field_idx at entry=4) at index-mail.c:68 #6 0x00007f...

...ADD_ARG (argv, i, "create"); > + > + /* Optional arguments. */ > + if (optargs_bitmask & GUESTFS_BTRFS_SUBVOLUME_CREATE_QGROUPID_BITMASK) { > + ADD_ARG (argv, i, "-i"); > + ADD_ARG (argv, i, qgroupid); > + } > + > + > ADD_ARG (argv, i, dest_buf); > ADD_ARG (argv, i, NULL); > > diff --git a/generator/actions.ml b/generator/actions.ml > index 30b839c..1c1fcff 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -10225,9 +10225,9 @@ See C<guestfs_get_e2generation>." }; > [[&qu...

...l-cache-lookup.c:322 > > > #3 mail_cache_field_exists (view=view at entry=0x7fc4a81332b0, > > seq=seq at entry=760, > > > field=field at entry=4) at mail-cache-lookup.c:352 > > > #4 0x00007fc4a69f3151 in mail_cache_lookup_field (view=0x7fc4a81332b0, > > > dest_buf=dest_buf at entry=0x7ffe23a98a00, seq=760, > > field_idx=field_idx at entry > > > =4) > > > at mail-cache-lookup.c:413 > > > #5 0x00007fc4a69d9439 in index_mail_cache_lookup_field > > > (mail=mail at entry=0x7fc4a8128cd0, > > > buf=buf at entr...

...cache_field_exists (view=view at entry=0x7fc4a81332b0, >> > > seq=seq at entry=760, >> > > > field=field at entry=4) at mail-cache-lookup.c:352 >> > > > #4 0x00007fc4a69f3151 in mail_cache_lookup_field >> (view=0x7fc4a81332b0, >> > > > dest_buf=dest_buf at entry=0x7ffe23a98a00, seq=760, >> > > field_idx=field_idx at entry >> > > > =4) >> > > > at mail-cache-lookup.c:413 >> > > > #5 0x00007fc4a69d9439 in index_mail_cache_lookup_field >> > > > (mail=mail at entry=0...

...uments. */ > > > + if (optargs_bitmask & GUESTFS_BTRFS_SUBVOLUME_CREATE_QGROUPID_BITMASK) { > > > + ADD_ARG (argv, i, "-i"); > > > + ADD_ARG (argv, i, qgroupid); > > > + } > > > + > > > + > > > ADD_ARG (argv, i, dest_buf); > > > ADD_ARG (argv, i, NULL); > > > > > > diff --git a/generator/actions.ml b/generator/actions.ml > > > index 30b839c..1c1fcff 100644 > > > --- a/generator/actions.ml > > > +++ b/generator/actions.ml > > > @@ -10225,9 +10225,9...

Hi, This is the part1 of improving btrfs support. This series adds missing parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. Other parts will follow. Regards, Hu Hu Tao (6): btrfs: correct words about subvolume and snapshot btrfs: add optional parameter `ro' to btrfs_subvolume_snapshot btrfs:

Hi, This is the part1 of improving btrfs support. This series adds missing parameters to btrfs_subvolume_snapshot and btrfs_subvolume_create, and adds two new API btrfs_subvolume_get_default and btrfs_subvolume_show. Other parts will follow. Regards, Hu changes: v2: - add 'once_had_no_optargs = true' for btrfs_subvolume_snapshot and btrfs_subvolume_create - improved documents

...subvolume"); ADD_ARG (argv, i, "snapshot"); + + /* Optional arguments. */ + if (!(optargs_bitmask & GUESTFS_BTRFS_SUBVOLUME_SNAPSHOT_RO_BITMASK)) + ro = 0; + + if (ro) { + ADD_ARG (argv, i, "-r"); + } + ADD_ARG (argv, i, source_buf); ADD_ARG (argv, i, dest_buf); ADD_ARG (argv, i, NULL); diff --git a/generator/actions.ml b/generator/actions.ml index fe492e6..850e58d 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -10217,7 +10217,7 @@ See C<guestfs_get_e2generation>." }; { defaults with name = "btrfs_subvolume_s...

...ADD_ARG (argv, i, "subvolume"); ADD_ARG (argv, i, "create"); + + /* Optional arguments. */ + if (optargs_bitmask & GUESTFS_BTRFS_SUBVOLUME_CREATE_QGROUPID_BITMASK) { + ADD_ARG (argv, i, "-i"); + ADD_ARG (argv, i, qgroupid); + } + + ADD_ARG (argv, i, dest_buf); ADD_ARG (argv, i, NULL); diff --git a/generator/actions.ml b/generator/actions.ml index 30b839c..1c1fcff 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -10225,9 +10225,9 @@ See C<guestfs_get_e2generation>." }; [["mkfs_btrfs"; "/dev/sda1&quo...

...*source, const char *dest, int ro) ADD_ARG (argv, i, "-r"); } + if (optargs_bitmask & GUESTFS_BTRFS_SUBVOLUME_SNAPSHOT_QGROUPID_BITMASK) { + ADD_ARG (argv, i, "-i"); + ADD_ARG (argv, i, qgroupid); + } + ADD_ARG (argv, i, source_buf); ADD_ARG (argv, i, dest_buf); ADD_ARG (argv, i, NULL); diff --git a/generator/actions.ml b/generator/actions.ml index 850e58d..30b839c 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -10217,7 +10217,7 @@ See C<guestfs_get_e2generation>." }; { defaults with name = "btrfs_subvolume_s...

...> + > > + /* Optional arguments. */ > > + if (optargs_bitmask & GUESTFS_BTRFS_SUBVOLUME_CREATE_QGROUPID_BITMASK) { > > + ADD_ARG (argv, i, "-i"); > > + ADD_ARG (argv, i, qgroupid); > > + } > > + > > + > > ADD_ARG (argv, i, dest_buf); > > ADD_ARG (argv, i, NULL); > > > > diff --git a/generator/actions.ml b/generator/actions.ml > > index 30b839c..1c1fcff 100644 > > --- a/generator/actions.ml > > +++ b/generator/actions.ml > > @@ -10225,9 +10225,9 @@ See C<guestfs_get_e2generatio...

...lback>, context=0x0) at mail-cache-lookup.c:208 #2 0x080743f8 in mail_cache_seq (view=0x80e1258, seq=1) at mail-cache-lookup.c:252 #3 0x0807448f in mail_cache_field_exists (view=0x80e1258, seq=1, field=0) at mail-cache-lookup.c:271 #4 0x080745bd in mail_cache_lookup_field (view=0x80e1258, dest_buf=0x80a6070, seq=1, field=0) at mail-cache-lookup.c:336 #5 0x0806e654 in index_mail_get_fixed_field (mail=0x80e0f18, field=MAIL_CACHE_FLAGS, data=0x80e0fbc, data_size=4) at index-mail.c:100 #6 0x0806f4ed in index_mail_next (mail=0x80e0f18, seq=1) at index-mail.c:647 #7 0x0806e45e in index_...

...he_field_exists (view=0xf16110, seq=<value optimized out>, field=<value optimized out>) at mail-cache-lookup.c:345 data = <value optimized out> __FUNCTION__ = "mail_cache_field_exists" #3 0x00007f351537ff64 in mail_cache_lookup_field (view=0xf16110, dest_buf=0x7fff96c80030, seq=52, field_idx=0) at mail-cache-lookup.c:413 field_def = <value optimized out> iter = {view = 0x7f3500000001, remap_counter = 0, seq = 0, rec = 0x1, pos = 355448944, rec_size = 32565, offset = 2048, trans_next_idx = 0, stop = 0, failed = 0, me...

...ARG (argv, i, subvolume_buf); @@ -295,7 +300,7 @@ do_btrfs_subvolume_create (const char *dest) return -1; } - ADD_ARG (argv, i, "btrfs"); + ADD_ARG (argv, i, str_btrfs); ADD_ARG (argv, i, "subvolume"); ADD_ARG (argv, i, "create"); ADD_ARG (argv, i, dest_buf); @@ -331,7 +336,7 @@ do_btrfs_subvolume_list (const char *fs) return NULL; } - ADD_ARG (argv, i, "btrfs"); + ADD_ARG (argv, i, str_btrfs); ADD_ARG (argv, i, "subvolume"); ADD_ARG (argv, i, "list"); ADD_ARG (argv, i, fs_buf); @@ -428,7 +433,7 @@ do...

...ARG (argv, i, subvolume_buf); @@ -295,7 +300,7 @@ do_btrfs_subvolume_create (const char *dest) return -1; } - ADD_ARG (argv, i, "btrfs"); + ADD_ARG (argv, i, str_btrfs); ADD_ARG (argv, i, "subvolume"); ADD_ARG (argv, i, "create"); ADD_ARG (argv, i, dest_buf); @@ -331,7 +336,7 @@ do_btrfs_subvolume_list (const char *fs) return NULL; } - ADD_ARG (argv, i, "btrfs"); + ADD_ARG (argv, i, str_btrfs); ADD_ARG (argv, i, "subvolume"); ADD_ARG (argv, i, "list"); ADD_ARG (argv, i, fs_buf); @@ -428,7 +433,7 @@ do...