search for: densemaptest

...low us to +# override the VPATH value unless we set PROJECT_NAME, which we don't want +# to do. +VPATH = $(LLVM_SRC_ROOT)/utils/unittest/googletest/src/ Why play with VPATH here? What is this doing? Can this be handled a different way? Similarly in makefile.unittest. +++ unittests/ADT/DenseMapTest.cpp (revision 0) +namespace { + +using namespace llvm; Please put the 'using' right after the #includes. Otherwise, the patch looks good to me. Please verify that it works with both a SRCDIR=OBJDIR and SRCDIR!=OBJDIR build. -Chris -------------- next part -------------- An HTML attac...

...ATH() on the decrement, or not have the code there (that's commented out) at all. * Instead of this: EXPECT_TRUE(uintMap[0] == 1); you should use EXPECT_EQ() * Instead of this: EXPECT_TRUE(uintMap.find(0u) == uintMap.begin()); is it possible to use EXPECT_EQ() as well? * In this test: TEST_F(DenseMapTest, IterationTest) { you use the array "int numbers[100];" as an array of booleans; why not make it "bool visited[100];" to make clear what it for, how it's used, and maybe be slightly more efficient? > 1) For the testing framework, I went with Google Test, since it's t...

...ValueInfoT, false>& I) > > This looks like it will make it impossible to copy const_iterators. I > guess it doesn't because the copy-constructor is auto-generated, but > please comment that and add tests for it and for the non-const->const > conversion to unittests/ADT/DenseMapTest.cpp. > > Otherwise, the patches just change iterator to const_iterator, which looks > fine. > > On Tue, Nov 3, 2009 at 3:09 AM, Victor Zverovich > <victor.zverovich at googlemail.com> wrote: > > Dear all, > > The first of the proposed patches (DenseMapIterator.pa...

+++ unittests/TestMain.cpp (revision 0) +//===--- unittest.cpp - unittest driver -----------------------------------===// +++ unittests/ADT/DenseMapTest.cpp (revision 0) +//===- llvm/unittest/DenseMapMap.h - DenseMap unit tests --------*- C++ -*-===// You probably want to update these file headers to match their real names. 2008/12/30 Misha Brukman <brukman at gmail.com> > 2008/12/30 Talin <viridia at gmail.com> > >> H...

...> >> This looks like it will make it impossible to copy const_iterators. I > >> guess it doesn't because the copy-constructor is auto-generated, but > >> please comment that and add tests for it and for the non-const->const > >> conversion to unittests/ADT/DenseMapTest.cpp. > >> > >> Otherwise, the patches just change iterator to const_iterator, which > looks > >> fine. > >> > >> On Tue, Nov 3, 2009 at 3:09 AM, Victor Zverovich > >> <victor.zverovich at googlemail.com> wrote: > >> > Dear a...

...KeyInfoT, ValueInfoT, false>& I) This looks like it will make it impossible to copy const_iterators. I guess it doesn't because the copy-constructor is auto-generated, but please comment that and add tests for it and for the non-const->const conversion to unittests/ADT/DenseMapTest.cpp. Otherwise, the patches just change iterator to const_iterator, which looks fine. On Tue, Nov 3, 2009 at 3:09 AM, Victor Zverovich <victor.zverovich at googlemail.com> wrote: > Dear all, > The first of the proposed patches (DenseMapIterator.patch) forbids implicit > conversion...

...his file by moving GTest up one directory, and added VPATH-less Makefiles: http://llvm.org/viewvc/llvm-project?view=rev&revision=61539 http://llvm.org/viewvc/llvm-project?view=rev&revision=61540 (minor revision) Also removed VPATH from Makefile.unittest (see link below). +++ unittests/ADT/DenseMapTest.cpp (revision 0) > +namespace { > + > +using namespace llvm; > > > Please put the 'using' right after the #includes. > Done. > Otherwise, the patch looks good to me. Please verify that it works with > both a SRCDIR=OBJDIR and SRCDIR!=OBJDIR build. > Done f...

...gt;> I) >> >> This looks like it will make it impossible to copy const_iterators. I >> guess it doesn't because the copy-constructor is auto-generated, but >> please comment that and add tests for it and for the non-const->const >> conversion to unittests/ADT/DenseMapTest.cpp. >> >> Otherwise, the patches just change iterator to const_iterator, which looks >> fine. >> >> On Tue, Nov 3, 2009 at 3:09 AM, Victor Zverovich >> <victor.zverovich at googlemail.com> wrote: >> > Dear all, >> > The first of the propo...

Dear all, The first of the proposed patches (DenseMapIterator.patch) forbids implicit conversion of DenseMap::const_iterator to DenseMap::iterator which was possible because DenseMapIterator inherited (publicly) from DenseMapConstIterator. Conversion the other way around is now allowed as one may expect. The template DenseMapConstIterator is removed and the template parameter IsConst which

...; This looks like it will make it impossible to copy const_iterators. I >> >> guess it doesn't because the copy-constructor is auto-generated, but >> >> please comment that and add tests for it and for the non-const->const >> >> conversion to unittests/ADT/DenseMapTest.cpp. >> >> >> >> Otherwise, the patches just change iterator to const_iterator, which >> looks >> >> fine. >> >> >> >> On Tue, Nov 3, 2009 at 3:09 AM, Victor Zverovich >> >> <victor.zverovich at googlemail.com> wrot...

...made and new patch attached. Comments below: On Tue, Dec 30, 2008 at 2:40 PM, Misha Brukman <brukman at gmail.com> wrote: > +++ unittests/TestMain.cpp (revision 0) > +//===--- unittest.cpp - unittest driver > -----------------------------------===// > > +++ unittests/ADT/DenseMapTest.cpp (revision 0) > +//===- llvm/unittest/DenseMapMap.h - DenseMap unit tests --------*- C++ > -*-===// > > You probably want to update these file headers to match their real names. > > 2008/12/30 Misha Brukman <brukman at gmail.com> > >> 2008/12/30 Talin <viri...

(Forwarding this to llvm-dev) This patch adds a unit test framework to LLVM, along with a sample unit test for DenseMap. I don't expect this patch to be accepted as-is, this is mainly a trial balloon and proof of concept. Some notes about the patch: 1) For the testing framework, I went with Google Test, since it's the one I have the most experience with. I fully expect an extended

...#39;s > commented out) at all. > > * Instead of this: > EXPECT_TRUE(uintMap[0] == 1); > you should use EXPECT_EQ() > > * Instead of this: > EXPECT_TRUE(uintMap.find(0u) == uintMap.begin()); > is it possible to use EXPECT_EQ() as well? > > * In this test: > TEST_F(DenseMapTest, IterationTest) { > you use the array "int numbers[100];" as an array of booleans; why not > make it "bool visited[100];" to make clear what it for, how it's used, > and maybe be slightly more efficient? > > > 1) For the testing framework, I went with Googl...

2008/12/30 Talin <viridia at gmail.com> > Here's the version of the unit test patch, incorporating the feedback I > have received so far. > Looks good, a few comments below. > Some notes on the patch: > > - This patch doesn't include googletest itself, that will need to be > checked in separately. The source distribution will live in >

...printable, although you can make anything printable by adding the necessary stream operator overloads. In this particular case, I decided that the printed representation of an iterator wouldn't be meaningful, so I didn't bother defining those overloads. > * In this test: > TEST_F(DenseMapTest, IterationTest) { > you use the array "int numbers[100];" as an array of booleans; why not > make it "bool visited[100];" to make clear what it for, how it's used, > and maybe be slightly more efficient? > OK >> 1) For the testing framework, I went with...

Here's the version of the unit test patch, incorporating the feedback I have received so far. Some notes on the patch: - This patch doesn't include googletest itself, that will need to be checked in separately. The source distribution will live in llvm/utils/unittest/googletest. (The reason for the extra directory level is so that the LLVM-specific makefiles can live in

...irectory, and added > VPATH-less Makefiles: > http://llvm.org/viewvc/llvm-project?view=rev&revision=61539 > http://llvm.org/viewvc/llvm-project?view=rev&revision=61540 (minor revision) > > Also removed VPATH from Makefile.unittest (see link below). > > +++ unittests/ADT/DenseMapTest.cpp (revision 0) > >> +namespace { >> + >> +using namespace llvm; >> >> >> Please put the 'using' right after the #includes. >> >> > > Done. > > > >> Otherwise, the patch looks good to me. Please verify that...

...#39;s > commented out) at all. > > * Instead of this: > EXPECT_TRUE(uintMap[0] == 1); > you should use EXPECT_EQ() > > * Instead of this: > EXPECT_TRUE(uintMap.find(0u) == uintMap.begin()); > is it possible to use EXPECT_EQ() as well? > > * In this test: > TEST_F(DenseMapTest, IterationTest) { > you use the array "int numbers[100];" as an array of booleans; why not > make it "bool visited[100];" to make clear what it for, how it's used, > and maybe be slightly more efficient? > > > 1) For the testing framework, I went with Googl...

...BJ/unittests/ExecutionEngine/Orc' llvm[3]: Compiling IndirectionUtilsTest.cpp for Release+Asserts build llvm[2]: ======= Finished Linking Release+Asserts Unit test CodeGen (without symbols) make[2]: Leaving directory '/home/NIKHILREDDY/WORK/LLVM_OBJ/unittests/CodeGen' llvm[2]: Compiling DenseMapTest.cpp for Release+Asserts build make[3]: Entering directory '/home/NIKHILREDDY/WORK/LLVM_OBJ/unittests/ExecutionEngine/MCJIT' llvm[3]: Linking Release+Asserts unit test DebugInfoPDB (without symbols) llvm[3]: Compiling MCJITCAPITest.cpp for Release+Asserts build llvm[3]: ======= Finished Link...