search for: densemapiterator

Dear all, The first of the proposed patches (DenseMapIterator.patch) forbids implicit conversion of DenseMap::const_iterator to DenseMap::iterator which was possible because DenseMapIterator inherited (publicly) from DenseMapConstIterator. Conversion the other way around is now allowed as one may expect. The template DenseMapConstIterator is removed and the t...

...e, True, False> { typedef False Result; }; > > These should probably go into include/llvm/Support/type_traits.h. In > C++0x, this is named "conditional" (section 20.6.7), so I think you > should use the same name, despite the standard committee's bad taste. > > + DenseMapIterator(const DenseMapIterator<KeyT, ValueT, > + KeyInfoT, ValueInfoT, false>& I) > > This looks like it will make it impossible to copy const_iterators. I > guess it doesn't because the copy-constructor is auto-generated, but > please c...

...False> +struct If<false, True, False> { typedef False Result; }; These should probably go into include/llvm/Support/type_traits.h. In C++0x, this is named "conditional" (section 20.6.7), so I think you should use the same name, despite the standard committee's bad taste. + DenseMapIterator(const DenseMapIterator<KeyT, ValueT, + KeyInfoT, ValueInfoT, false>& I) This looks like it will make it impossible to copy const_iterators. I guess it doesn't because the copy-constructor is auto-generated, but please comment that and add test...

...;> > >> These should probably go into include/llvm/Support/type_traits.h. In > >> C++0x, this is named "conditional" (section 20.6.7), so I think you > >> should use the same name, despite the standard committee's bad taste. > >> > >> + DenseMapIterator(const DenseMapIterator<KeyT, ValueT, > >> + KeyInfoT, ValueInfoT, false>& > >> I) > >> > >> This looks like it will make it impossible to copy const_iterators. I > >> guess it doesn't because the cop...

...edef False Result; }; >> >> These should probably go into include/llvm/Support/type_traits.h. In >> C++0x, this is named "conditional" (section 20.6.7), so I think you >> should use the same name, despite the standard committee's bad taste. >> >> +  DenseMapIterator(const DenseMapIterator<KeyT, ValueT, >> +                                          KeyInfoT, ValueInfoT, false>& >> I) >> >> This looks like it will make it impossible to copy const_iterators. I >> guess it doesn't because the copy-constructor is auto-gen...

...gt; These should probably go into include/llvm/Support/type_traits.h. In >> >> C++0x, this is named "conditional" (section 20.6.7), so I think you >> >> should use the same name, despite the standard committee's bad taste. >> >> >> >> + DenseMapIterator(const DenseMapIterator<KeyT, ValueT, >> >> + KeyInfoT, ValueInfoT, >> false>& >> >> I) >> >> >> >> This looks like it will make it impossible to copy const_iterators. I >> >> guess i...

...know which is the root cause of this error because the assertion not explicitly occurs in my code, it occurs in the library code which I'm using in my threads. Assertion I'm getting is this: Global Value is CRO: /home/preejackie/spicy/orcs/llvm/include/llvm/ADT/DenseMap.h:1242: bool llvm::DenseMapIterator<const llvm::Value *, llvm::StringMapEntry<llvm::Value *> *, llvm::DenseMapInfo<const llvm::Value *>, llvm::detail::DenseMapPair<const llvm::Value *, llvm::StringMapEntry<llvm::Value *> *>, false>::operator!=(const llvm::DenseMapIterator::ConstIterator &) const [Key...

...nDAG/SelectionDAG.cpp:3440: error: call of overloaded `AddInteger(uint32_t)' is ambiguous .../lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1429: error: no matching function for call to `max(long unsigned int, unsigned int&)' .../include/llvm/ADT/DenseMap.h: In member function `void llvm::DenseMapIterator<KeyT, ValueT, KeyInfoT, ValueInfoT>::AdvancePastEmptyBuckets() [with KeyT = uint32_t, ValueT = llvm::Value*, KeyInfoT = llvm::DenseMapInfo<uint32_t>, ValueInfoT = llvm::DenseMapInfo<llvm::Value*>]': .../include/llvm/ADT/DenseMap.h:479: instantiated from `llvm::DenseMapIterat...

...detail::DenseMapPair<llvm::CachedHashStringRef, int> >::InsertIntoBucket<llvm::CachedHashStringRef, int>(llvm::detail::DenseMapPair<llvm::CachedHashStringRef, int>*, llvm::CachedHashStringRef&&, int&&) (DenseMap.h:512) ==5467== by 0x51DEC9: std::pair<llvm::DenseMapIterator<llvm::CachedHashStringRef, int, llvm::DenseMapInfo<llvm::CachedHashStringRef>, llvm::detail::DenseMapPair<llvm::CachedHashStringRef, int>, false>, bool> llvm::DenseMapBase<llvm::DenseMap<llvm::CachedHashStringRef, int, llvm::DenseMapInfo<llvm::CachedHashStringRef>,...

...HashStringRef, int> >> >::InsertIntoBucket<llvm::CachedHashStringRef, >> int>(llvm::detail::DenseMapPair<llvm::CachedHashStringRef, int>*, >> llvm::CachedHashStringRef&&, int&&) (DenseMap.h:512) >> ==5467== by 0x51DEC9: std::pair<llvm::DenseMapIterator<llvm::CachedHashStringRef, >> int, llvm::DenseMapInfo<llvm::CachedHashStringRef>, >> llvm::detail::DenseMapPair<llvm::CachedHashStringRef, int>, false>, >> bool> llvm::DenseMapBase<llvm::DenseMap<llvm::CachedHashStringRef, int, >> llvm::DenseMapInf...