search for: denormalise_bands

...Q15ONE); + } } st->rng = seed; - for (c=0;c<C;c++) - for (i=0;i<st->mode->nbEBands;i++) - renormalise_vector(X+N*c+(st->mode->eBands[i]<<LM), (st->mode->eBands[i+1]-st->mode->eBands[i])<<LM, Q15ONE); - denormalise_bands(st->mode, X, freq, bandE, st->mode->nbEBands, C, 1<<LM); + denormalise_bands(st->mode, X, freq, bandE, st->mode->effEBands, C, 1<<LM); compute_inv_mdcts(st->mode, 0, freq, out_syn, overlap_mem, C, LM); plc = 0; -- 1.7.3.4 --------------090601...

...s is 21 and eBands[21] is 100 (the standard 2.5 ms short block ebands). This also gives me LM = 2, so what happens is eBands[nbEBands]<<LM is 400, whereas my framesize is only 320. This causes a stack overrun at line 1978 in celt.c in both calls to "renormalise_vector" and "denormalise_bands". It seems that the obvious solution for "denormalise_bands" is to call it with "st->mode->effEBands" instead of "st->mode->nbEBands", but I don't know what to do about the call to "renormalise_vector" (except perhaps use "st-&gt...

Hi everyone, I have profiled Opus on AArch64. I just run opus_demo with some pcm files. Following is time proportion of FFT with different bitrate. Bitrate | Time cost by FFT/iFFT 24kb/s | 15% 48kb/s | 15% 96kb/s | 13% Any comment? I want some data close to real application, any suggestion? Thanks, Phil Wang -------------- next part -------------- An HTML attachment was scrubbed... URL:

...h modes.h os_support.h pitch.h psy.h \ + quant_bands.h rate.h stack_alloc.h vq.h noinst_PROGRAMS = testcelt dump_modes testcelt_SOURCES = testcelt.c diff --git a/libcelt/bands.c b/libcelt/bands.c index 315cce8..49eaeda 100644 --- a/libcelt/bands.c +++ b/libcelt/bands.c @@ -210,9 +210,10 @@ void denormalise_bands(const CELTMode *m, const celt_norm_t * restrict X, celt_s /* Compute the best gain for each "pitch band" */ -void compute_pitch_gain(const CELTMode *m, const celt_norm_t *X, const celt_norm_t *P, celt_pgain_t *gains) +int compute_pitch_gain(const CELTMode *m, const celt_norm_t *X, co...

...e/peppermint/build/opus-1.1-beta/celt/bands.c:349: undefined reference to `sqrtf' /usr/local/lib/libopus.a(bands.o): In function `compute_band_energies': /home/peppermint/build/opus-1.1-beta/celt/bands.c:165: undefined reference to `sqrtf' /usr/local/lib/libopus.a(bands.o): In function `denormalise_bands': /home/peppermint/build/opus-1.1-beta/celt/bands.c:229: undefined reference to `exp' /usr/local/lib/libopus.a(bands.o): In function `anti_collapse': /home/peppermint/build/opus-1.1-beta/celt/bands.c:272: undefined reference to `exp' /home/peppermint/build/opus-1.1-beta/celt/bands.c...

...Q15(pgains[pband], P[j]); + } else { + for (j=C*eBands[i];j<C*eBands[i+1];j++) + P[j] = 0; } if (q > 0) diff --git a/libcelt/bands.h b/libcelt/bands.h index dc9b471..3e4a37c 100644 --- a/libcelt/bands.h +++ b/libcelt/bands.h @@ -78,8 +78,6 @@ void denormalise_bands(const CELTMode *m, const celt_norm_t * restrict X, celt_s */ void compute_pitch_gain(const CELTMode *m, const celt_norm_t *X, const celt_norm_t *P, celt_pgain_t *gains); -void pitch_quant_bands(const CELTMode *m, celt_norm_t * restrict P, const celt_pgain_t * restrict gains); - /** Quantisati...

...ild/opus-1.1-beta/celt/bands.c:349: undefined reference to `sqrtf' > /usr/local/lib/libopus.a(bands.o): In function `compute_band_energies': > /home/peppermint/build/opus-1.1-beta/celt/bands.c:165: undefined reference to `sqrtf' > /usr/local/lib/libopus.a(bands.o): In function `denormalise_bands': > /home/peppermint/build/opus-1.1-beta/celt/bands.c:229: undefined reference to `exp' > /usr/local/lib/libopus.a(bands.o): In function `anti_collapse': > /home/peppermint/build/opus-1.1-beta/celt/bands.c:272: undefined reference to `exp' > /home/peppermint/build/opus-1...

...ackward(&mode->mdct, &freq[b], out_syn[0]+NB*b, mode->window, overlap, shift, B); + clt_mdct_backward(&mode->mdct, &freq[b], out_syn[0]+NB*b, mode->window, overlap, shift, B, arch); } else { /* Normal case (mono or stereo) */ c=0; do { denormalise_bands(mode, X+c*N, freq, oldBandE+c*nbEBands, start, effEnd, M, downsample, silence); for (b=0;b<B;b++) - clt_mdct_backward(&mode->mdct, &freq[b], out_syn[c]+NB*b, mode->window, overlap, shift, B); + clt_mdct_backward(&mode->mdct, &a...

...ackward(&mode->mdct, &freq[b], out_syn[0]+NB*b, mode->window, overlap, shift, B); + clt_mdct_backward(&mode->mdct, &freq[b], out_syn[0]+NB*b, mode->window, overlap, shift, B, arch); } else { /* Normal case (mono or stereo) */ c=0; do { denormalise_bands(mode, X+c*N, freq, oldBandE+c*nbEBands, start, effEnd, M, downsample, silence); for (b=0;b<B;b++) - clt_mdct_backward(&mode->mdct, &freq[b], out_syn[c]+NB*b, mode->window, overlap, shift, B); + clt_mdct_backward(&mode->mdct, &a...

Hello All, I extended the libNE10 optimizations for float towards mdct_backwards/opus_ifft. I am able to get about 14.26% improvement for Decode use case now on my Beaglebone Black. Please see [1] for measurements. Questions 1. Since this patch needs to go in after Encode [2] patch) should I submit this as patch series? 2. Since Jonathan Lennox posted intrinsics cleanup [3] patch, should

Hi All, Since I continue to base my work on top of Jonathan's patch, and my previous Ne10 fft/ifft/mdct_forward/backward patches, I thought it would be better to just post all new patches as a patch series. Please let me know if anyone disagrees with this approach. You can see wip branch of all latest patches at https://git.linaro.org/people/viswanath.puttagunta/opus.git Branch:

Hi Timothy, As I mentioned earlier [1], I now fixed compile issues with fixed point and resubmitting the patch. I also have new patch that does intrinsics optimizations for celt_pitch_xcorr targetting aarch64. You can find my latest work-in-progress branch at [2] For reference, you can use the Ne10 pre-built libraries at [3] Note that I am working with Phil at ARM to get my patch at [4]

Hi All, As per Timothy's suggestion, disabling mdct_forward for fixed point. Only effects armv7,armv8: Extend fixed fft NE10 optimizations to mdct Rest of patches are same as in [1] For reference, latest wip code for opus is at [2] Still working with NE10 team at ARM to get corner cases of mdct_forward. Will update with another patch when issue in NE10 gets fixed. Regards, Vish [1]:

Hi All, Changes from RFC v2 [1] armv7,armv8: Extend fixed fft NE10 optimizations to mdct - Overflow issue fixed by Phil at ARM. Ne10 wip at [2]. Should be upstream soon. - So, re-enabled using fixed fft for mdct_forward which was disabled in RFCv2 armv7,armv8: Optimize fixed point fft using NE10 library - Thanks to Jonathan Lennox, fixed some build fixes on iOS and some copy-paste errors Rest

Hello Timothy / Jean-Marc / opus-dev, This patch series is follow up on work I posted on [1]. In addition to what was posted on [1], this patch series mainly integrates Fixed point FFT implementations in NE10 library into opus. You can view my opus wip code at [2]. Note that while I found some issues both with the NE10 library(fixed fft) and with Linaro toolchain (armv8 intrinsics), the work