search for: denable_experimental_new_pass_manag

Hi all, I wanted to give a quick update on the status of NPM for the IR optimization pipeline and ask some questions. In the past I believe there were thoughts that NPM was basically ready because all of check-llvm and check-clang passed when -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=ON was specified. But that CMake flag did not apply to opt and any tests running something like `opt -foo-pass -bar-pass` (which is the vast majority of check-llvm tests) were still using the legacy PM. The intended way to use NPM was to use the -passes flag, e.g. `opt -passes='foo,bar'`....

...abstraction level. > > > ** Testing ** > - Since the `llc` options are compatible, as passes are ported to NPM > and various issues got resolved, we should see more tests passing when `llc - > enable-new-pm` is turned on implicitly via an (maybe) knob similar to `cmake > -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER`. > - A buildbot to make sure no regression when `llc -enable-new-pm` is > implicitly on? > - Any idea on this regard is much appreciated. > > > Manually running tests once in a while might be good enough, not sure if the > cost of setting up a bot that maintains some sor...

...-enable-new-pm` accepts almost all options `llc` accept. ** Testing ** - Since the `llc` options are compatible, as passes are ported to NPM and various issues got resolved, we should see more tests passing when `llc -enable-new-pm` is turned on implicitly via an (maybe) knob similar to `cmake -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER`. - A buildbot to make sure no regression when `llc -enable-new-pm` is implicitly on? - Any idea on this regard is much appreciated. ** Work in progress ** Have a minimum codegen pipeline to produce a valid assembly file by porting target-independent passes such as AsmPrinter.cpp, SelectionDAGI...

...dev wrote: > > Hi all, > > I wanted to give a quick update on the status of NPM for the IR > optimization pipeline and ask some questions. > > In the past I believe there were thoughts that NPM was basically ready > because all of check-llvm and check-clang passed when > -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=ON was specified. But that CMake > flag did not apply to opt and any tests running something like `opt > -foo-pass -bar-pass` (which is the vast majority of check-llvm tests) were > still using the legacy PM. The intended way to use NPM was to use the > -passes flag, e.g. `opt -passes...

...dev wrote: > > Hi all, > > I wanted to give a quick update on the status of NPM for the IR > optimization pipeline and ask some questions. > > In the past I believe there were thoughts that NPM was basically ready > because all of check-llvm and check-clang passed when > -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=ON was specified. But that CMake > flag did not apply to opt and any tests running something like `opt > -foo-pass -bar-pass` (which is the vast majority of check-llvm tests) were > still using the legacy PM. The intended way to use NPM was to use the > -passes flag, e.g. `opt -passes...

...dev wrote: > > Hi all, > > I wanted to give a quick update on the status of NPM for the IR > optimization pipeline and ask some questions. > > In the past I believe there were thoughts that NPM was basically ready > because all of check-llvm and check-clang passed when > -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=ON was specified. But that CMake > flag did not apply to opt and any tests running something like `opt > -foo-pass -bar-pass` (which is the vast majority of check-llvm tests) were > still using the legacy PM. The intended way to use NPM was to use the > -passes flag, e.g. `opt -passes...

...- Since the `llc` options are compatible, as passes are ported to >> NPM >> > and various issues got resolved, we should see more tests passing when >> `llc - >> > enable-new-pm` is turned on implicitly via an (maybe) knob similar to >> `cmake >> > -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER`. >> > - A buildbot to make sure no regression when `llc -enable-new-pm` >> is >> > implicitly on? >> > - Any idea on this regard is much appreciated. >> > >> > >> > Manually running tests once in a while might be good enough...

Hello all, As of now, all LLVM and Clang tests have been updated/addressed to run under the new/experimental pass manager (at least the ones that failed when using the new PM). For those who aren't aware of what the new pass manager (PM) is, the tl;dr is that this will serve as a replacement for the legacy PM, and promises faster build times by restructuring how passes are run over IR units.