search for: demixing_matrix_size_in_byt

...w if int is 16 bits. > One of the operands of the multiplication should be cast to opus_int32 > in such cases to ensure a 32-bit multiply and avoid overflow. > > Done. > 4) get_multistream_decoder: align() must be applied separately to > sizeof(OpusProjectionDecoder) and st->demixing_matrix_size_in_bytes > since they may each have padding. Including the alignment padding in > demixing_matrix_size_in_bytes as in (5) avoids the second call to > align(). Similarly in opus_projection_decoder_get_size, align() > should just be applied to sizeof(OpusProjectionDecoder); in that case > t...

...DEX macro, multiplication may overflow if int is 16 bits. One of the operands of the multiplication should be cast to opus_int32 in such cases to ensure a 32-bit multiply and avoid overflow. 4) get_multistream_decoder: align() must be applied separately to sizeof(OpusProjectionDecoder) and st->demixing_matrix_size_in_bytes since they may each have padding. Including the alignment padding in demixing_matrix_size_in_bytes as in (5) avoids the second call to align(). Similarly in opus_projection_decoder_get_size, align() should just be applied to sizeof(OpusProjectionDecoder); in that case the other sizes may have t...

...One of the operands of the multiplication should be cast to opus_int32 > in such cases to ensure a 32-bit multiply and avoid overflow. > > Done. >   > >  4) get_multistream_decoder: align() must be applied separately to > sizeof(OpusProjectionDecoder) and st->demixing_matrix_size_in_bytes > since they may each have padding.  Including the alignment padding in > demixing_matrix_size_in_bytes as in (5) avoids the second call to > align().  Similarly in opus_projection_decoder_get_size, align() > should just be applied to sizeof(OpusProjectionDecoder); in...

On 11/09/2017 01:58 PM, Drew Allen wrote: > Attached is a quick patch that addresses a bug when exporting the matrix > from the encoder. Actually, I don't see what your encoder change is supposed to do. Are there cases where demixing_matrix->rows != nb_output_streams ? Cheers, Jean-Marc > Cheers, > Drew > > On Wed, Nov 8, 2017 at 4:44 PM Drew Allen <bitllama at

Hi Drew, Thanks for the fixes. See below for a couple of remaining issues. On Mon, Nov 20, 2017 at 5:57 PM, Drew Allen <bitllama at google.com> wrote: > On Sat, Nov 18, 2017 at 5:48 PM Mark Harris <mark.hsj at gmail.com> wrote: >> >> 5) opus_projection_decoder_init: demixing_matrix_size_in_bytes >> doesn't include the MappingMatrix struct or alignment but is used to >> determine the offset of the decoder; it should be obtained from >> mapping_matrix_get_size() and the field should be opus_int32. >> > This value is only meant to represent the "data&quot...