Displaying 4 results from an estimated 4 matches for "delayoutput".
2009 Dec 16
2
[LLVMdev] [PATCH] Circular Buffered Debug Stream
...t a patch that does one thing (e.g. implements dbgs(),
>
> Ok, let's start with that. Here's the patch to add the circular raw_ostream.
This idea of the patch makes sense to me, but here are a few questions:
+ int BufferSize;
+ std::vector<char> BufferArray;
+ bool DelayOutput;
+ std::vector<char>::iterator Cur;
Please doxygenify these.
Instead of using a std::vector for BufferArray, please just new[] an array since it is fixed size.
Why is BufferSize needed with the vector? Isn't it always the size of BufferArray? Also, why is it signed?
What does Del...
2009 Dec 16
0
[LLVMdev] [PATCH] Circular Buffered Debug Stream
On Tuesday 15 December 2009 23:02, Chris Lattner wrote:
> On Dec 15, 2009, at 6:33 PM, David Greene wrote:
> > On Tuesday 15 December 2009 20:11, Chris Lattner wrote:
> >> Please send complete and minimal patches to avoid wasting reviewer's
> >> time,
> >
> > What do you want, complete or minimal? I don't want to pre-send 50
> > or so patches
2009 Dec 16
2
[LLVMdev] [PATCH] Circular Buffered Debug Stream
On Dec 15, 2009, at 6:33 PM, David Greene wrote:
> On Tuesday 15 December 2009 20:11, Chris Lattner wrote:
>
>> Please send complete and minimal patches to avoid wasting reviewer's
>> time,
>
> What do you want, complete or minimal? I don't want to pre-send 50
> or so patches (one per source file) that simply change errs() to dbgs().
> Thus I thought I
2009 Dec 16
0
[LLVMdev] [PATCH] Circular Buffered Debug Stream
On Wednesday 16 December 2009 13:19, Chris Lattner wrote:
> + int BufferSize;
> + std::vector<char> BufferArray;
> + bool DelayOutput;
> + std::vector<char>::iterator Cur;
>
> Please doxygenify these.
Ok.
> Instead of using a std::vector for BufferArray, please just new[] an array
> since it is fixed size.
Ok.
> Why is BufferSize needed with the vector? Isn't it always the size of
> BufferArr...