search for: defpathvar

...var.c | 11 ++--------- usr/dash/var.h | 6 +----- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/usr/dash/var.c b/usr/dash/var.c index cc6f7f2a..604ab1f7 100644 --- a/usr/dash/var.c +++ b/usr/dash/var.c @@ -75,11 +75,7 @@ MKINIT struct localvar_list *localvar_stack; const char defpathvar[] = "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"; -#ifdef IFS_BROKEN -const char defifsvar[] = "IFS= \t\n"; -#else -const char defifs[] = " \t\n"; -#endif +char defifsvar[] = "IFS= \t\n"; MKINIT char defoptindvar[] = "OPTIND=1&q...

...ed even when -v is used is easy enough, see attached patch. Tested even with explicit PATH overrides: PATH=/path/to/some/other/dash command -pv dash correctly outputs /bin/dash on my system. > the path that 'command -p cmd' uses is a compiled-in constant > from dash's src/var.c:defpathvar, which starts with > "/usr/local/sbin:/usr/local/bin". To me, that is both completely > unexpected and pretty scary -- /usr/local/bin is (very) often less > well secured or checked than, say, /bin: Agreed. However, IMO, it does make sense for defpathvar to start with /usr/local/...

...ed even when -v is used is easy enough, see attached patch. Tested even with explicit PATH overrides: PATH=/path/to/some/other/dash command -pv dash correctly outputs /bin/dash on my system. > the path that 'command -p cmd' uses is a compiled-in constant > from dash's src/var.c:defpathvar, which starts with > "/usr/local/sbin:/usr/local/bin". To me, that is both completely > unexpected and pretty scary -- /usr/local/bin is (very) often less > well secured or checked than, say, /bin: Agreed. However, IMO, it does make sense for defpathvar to start with /usr/local/...

...-- usr/dash/var.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr/dash/var.h b/usr/dash/var.h index 1a06a3cb..11ce9b7d 100644 --- a/usr/dash/var.h +++ b/usr/dash/var.h @@ -107,7 +107,7 @@ extern const char defifsvar[]; extern const char defifs[]; #endif extern const char defpathvar[]; -#define defpath (defpathvar + 5) +#define defpath (defpathvar + 36) extern int lineno; extern char linenovar[];

...-- usr/dash/var.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr/dash/var.h b/usr/dash/var.h index 1a06a3cb..11ce9b7d 100644 --- a/usr/dash/var.h +++ b/usr/dash/var.h @@ -107,7 +107,7 @@ extern const char defifsvar[]; extern const char defifs[]; #endif extern const char defpathvar[]; -#define defpath (defpathvar + 5) +#define defpath (defpathvar + 36) extern int lineno; extern char linenovar[];