Displaying 20 results from an estimated 49 matches for "define_pci_device_table".
2014 Jul 18
9
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
// <smpl>
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@
- DEFINE_PCI_DE...
2014 Jul 18
9
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.
A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):
// <smpl>
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@
- DEFINE_PCI_DE...
2014 Jul 18
1
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
> On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> > We should prefer `const struct pci_device_id` over
> > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> > This issue was reported by checkpatch.
>
> Honestly, I prefer the macro -- it stands-out more. Maybe the style
> guidelines and/or checkpatch should change instead?
The macro is horrid, no other bus has this type of thing just to save a...
2014 Jul 18
1
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
> On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> > We should prefer `const struct pci_device_id` over
> > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> > This issue was reported by checkpatch.
>
> Honestly, I prefer the macro -- it stands-out more. Maybe the style
> guidelines and/or checkpatch should change instead?
The macro is horrid, no other bus has this type of thing just to save a...
2014 Jul 18
0
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
...> On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
> > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
> > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> > > > We should prefer `const struct pci_device_id` over
> > > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> > > > This issue was reported by checkpatch.
> > >
> > > Honestly, I prefer the macro -- it stands-out more. Maybe the style
> > > guidelines and/or checkpatch should change instead?
> >
> > The macro i...
2014 Jul 21
0
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
...00, Greg KH wrote:
>> > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
>> > > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
>> > > > > We should prefer `const struct pci_device_id` over
>> > > > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
>> > > > > This issue was reported by checkpatch.
>> > > >
>> > > > Honestly, I prefer the macro -- it stands-out more. Maybe the style
>> > > > guidelines and/or checkpatch should change instea...
2013 Dec 02
0
[PATCH 33/39] virtio: pci: remove DEFINE_PCI_DEVICE_TABLE macro
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.
Signed-off-by: Jingoo Han <jg1.han at samsung.com>
---
drivers/virtio/virtio_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index a37c699..a4a1f7c 100644
--- a...
2014 Jul 18
1
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
>
> We have almost 1000 more uses of the non-macro version than the "macro"
> version in the kernel today:
> $ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l
> 262
> $ git grep "const struct pci_device_id" | wc -l
> 1254
did you check for non-const ones? just to see if we have any of the
broken case in the tree :-)
as for consistency, pci_dev vs usb_device :-P
Dave.
2014 Jul 18
0
[PATCH 23/25] virtio: Replace DEFINE_PCI_DEVICE_TABLE macro use
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
kernel coding style guidelines. This issue was reported by checkpatch.
Signed-off-by: Benoit Taine <benoit.taine at lip6.fr>
---
Tested by compilation without errors.
drivers/virtio/virtio_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio...
2013 Dec 02
0
[PATCH 33/39] virtio: pci: remove DEFINE_PCI_DEVICE_TABLE macro
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.
Signed-off-by: Jingoo Han <jg1.han at samsung.com>
---
drivers/virtio/virtio_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index a37c699..a4a1f7c 100644
--- a...
2014 Jul 18
1
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
>
> We have almost 1000 more uses of the non-macro version than the "macro"
> version in the kernel today:
> $ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l
> 262
> $ git grep "const struct pci_device_id" | wc -l
> 1254
did you check for non-const ones? just to see if we have any of the
broken case in the tree :-)
as for consistency, pci_dev vs usb_device :-P
Dave.
2014 Jul 18
0
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
On Fri, 2014-07-18 at 09:28 -0700, James Bottomley wrote:
> On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote:
> > We should prefer `const struct pci_device_id` over
> > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> > This issue was reported by checkpatch.
>
> What kernel coding style? checkpatch isn't the arbiter of style, if
> that's the only problem.
>
> The DEFINE_PCI macro was a well reasoned addition when it was added in
> 2008...
2014 Jul 18
0
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.
Honestly, I prefer the macro -- it stands-out more. Maybe the style
guidelines and/or checkpatch should change instead?
John
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdrive...
2014 Jul 18
0
[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use
On Fri, 2014-07-18 at 09:28 -0700, James Bottomley wrote:
> On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote:
> > We should prefer `const struct pci_device_id` over
> > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> > This issue was reported by checkpatch.
>
> What kernel coding style? checkpatch isn't the arbiter of style, if
> that's the only problem.
>
> The DEFINE_PCI macro was a well reasoned addition when it was added in
> 2008...
2014 Sep 15
3
[PATCH] virtio-pci: also bind to Amazon PCI vendor ID
...ns(+)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 101db3f..9cbac33 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -93,6 +93,8 @@ struct virtio_pci_vq_info
/* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */
static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) = {
{ PCI_DEVICE(0x1af4, PCI_ANY_ID) },
+ /* Amazon.com vendor ID */
+ { PCI_DEVICE(0x1d0f, PCI_ANY_ID) },
{ 0 }
};
--
1.7.9.5
2014 Sep 15
3
[PATCH] virtio-pci: also bind to Amazon PCI vendor ID
...ns(+)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index 101db3f..9cbac33 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -93,6 +93,8 @@ struct virtio_pci_vq_info
/* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */
static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) = {
{ PCI_DEVICE(0x1af4, PCI_ANY_ID) },
+ /* Amazon.com vendor ID */
+ { PCI_DEVICE(0x1d0f, PCI_ANY_ID) },
{ 0 }
};
--
1.7.9.5
2013 Apr 02
3
TigerJet 320G Chip / TDM400 Chipset / DAHDI Support
Hi, I'm curious what chip Digium is using in the latest TDM400 cards.
Specifically, to my recollection, they used to use the TigerJet 320G,
however somewhat recently, Tigerjet was bought out, and now the 320G is no
longer produced.
Maybe a better question is: is there a way I can take the latest DAHDI
source and get a list of supported chipsets from it?
Thanks.
MCH
-------------- next part
2014 Aug 11
0
[PULL] virtio-next
...virtio: rng: remove unused struct element
virtio: rng: re-arrange struct elements for better packing
virtio: rng: delay hwrng_register() till driver is ready
Revert "hwrng: virtio - ensure reads happen after successful probe"
Benoit Taine (1):
virtio: Replace DEFINE_PCI_DEVICE_TABLE macro use
Fabian Frederick (1):
virtio: console: remove unnecessary null test before debugfs_remove_recursive
drivers/char/hw_random/core.c | 6 ------
drivers/char/hw_random/virtio-rng.c | 39 ++++++++++++++++---------------------
drivers/char/virtio_console.c | 6 ++----
dr...
2014 Aug 11
0
[PULL] virtio-next
...virtio: rng: remove unused struct element
virtio: rng: re-arrange struct elements for better packing
virtio: rng: delay hwrng_register() till driver is ready
Revert "hwrng: virtio - ensure reads happen after successful probe"
Benoit Taine (1):
virtio: Replace DEFINE_PCI_DEVICE_TABLE macro use
Fabian Frederick (1):
virtio: console: remove unnecessary null test before debugfs_remove_recursive
drivers/char/hw_random/core.c | 6 ------
drivers/char/hw_random/virtio-rng.c | 39 ++++++++++++++++---------------------
drivers/char/virtio_console.c | 6 ++----
dr...
2014 Sep 15
0
[PATCH] virtio-pci: also bind to Amazon PCI vendor ID
...rtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
> index 101db3f..9cbac33 100644
> --- a/drivers/virtio/virtio_pci.c
> +++ b/drivers/virtio/virtio_pci.c
> @@ -93,6 +93,8 @@ struct virtio_pci_vq_info
> /* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */
> static DEFINE_PCI_DEVICE_TABLE(virtio_pci_id_table) = {
> { PCI_DEVICE(0x1af4, PCI_ANY_ID) },
> + /* Amazon.com vendor ID */
> + { PCI_DEVICE(0x1d0f, PCI_ANY_ID) },
> { 0 }
> };
>
> --
> 1.7.9.5