search for: debuginfocodeview

...h and don't catch. I suspect it's a matter of whether the headers themselves form a cycle - whereas the Google build system's a bit more structured - knowing about libraries and explicit dependencies between them. & I didn't look closely to see if, as I said, MC could depend on DebugInfoCodeView - probably weird/awkward/not what we want (I'm guessing?) but the modules buildbots don't have explicit dependencies, they just fail when they find a cycle. So they can implicitly support all sorts of weird dependencies we might not've expected/planned, so long as it's not an actual...

DebugInfoCodeView is nto strictly a consumer, it is also a producer. On Wed, Mar 21, 2018 at 1:29 PM <paul.robinson at sony.com> wrote: > Intuitively I'd think MC and DebugInfo should be independent. MC is a > producer, DebugInfo is a consumer. What's common is the definition of the > stru...

...h and don't catch. I suspect it's a matter of whether the headers themselves form a cycle - whereas the Google build system's a bit more structured - knowing about libraries and explicit dependencies between them. & I didn't look closely to see if, as I said, MC could depend on DebugInfoCodeView - probably weird/awkward/not what we want (I'm guessing?) but the modules buildbots don't have explicit dependencies, they just fail when they find a cycle. So they can implicitly support all sorts of weird dependencies we might not've expected/planned, so long as it's not an actual...

I'm looking at fixing some layering violations in LLVM & came across a few in the CodeView handling, specifically: lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers I guess MC could be made dependent on DebugInfoCodeView? But probably these things should be sunk into BinaryFormat as is the case for DWARF features used by MC? include/llvm/Object/COFF.h includes include/llvm/DebugInfo/CodeView/CVDebugRecord.h Also seems like this could/should/needs to be sunk into BinaryFormat? I'm open to ideas & happy t...

...laikie <dblaikie at gmail.com> wrote: > I'm looking at fixing some layering violations in LLVM & came across a few > in the CodeView handling, specifically: > > lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers > I guess MC could be made dependent on DebugInfoCodeView? But probably > these things should be sunk into BinaryFormat as is the case for DWARF > features used by MC? > > include/llvm/Object/COFF.h includes > include/llvm/DebugInfo/CodeView/CVDebugRecord.h > Also seems like this could/should/needs to be sunk into BinaryFormat? > &g...

...mail.com> wrote: > >> I'm looking at fixing some layering violations in LLVM & came across a >> few in the CodeView handling, specifically: >> >> lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers >> I guess MC could be made dependent on DebugInfoCodeView? But probably >> these things should be sunk into BinaryFormat as is the case for DWARF >> features used by MC? >> > > I'd be OK with that. We could very easily introduce true link dependencies > on that library in the near future. > OK - added the LLVMBuild.txt c...

...laikie <dblaikie at gmail.com> wrote: > I'm looking at fixing some layering violations in LLVM & came across a few > in the CodeView handling, specifically: > > lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers > I guess MC could be made dependent on DebugInfoCodeView? But probably > these things should be sunk into BinaryFormat as is the case for DWARF > features used by MC? > I'd be OK with that. We could very easily introduce true link dependencies on that library in the near future. > include/llvm/Object/COFF.h includes > include/llvm/D...

...; I'm looking at fixing some layering violations in LLVM & came across a >>>> few in the CodeView handling, specifically: >>>> >>>> lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers >>>> I guess MC could be made dependent on DebugInfoCodeView? But probably >>>> these things should be sunk into BinaryFormat as is the case for DWARF >>>> features used by MC? >>>> >>> >>> I'd be OK with that. We could very easily introduce true link >>> dependencies on that library in the n...

...> >>> I'm looking at fixing some layering violations in LLVM & came across a >>> few in the CodeView handling, specifically: >>> >>> lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers >>> I guess MC could be made dependent on DebugInfoCodeView? But probably >>> these things should be sunk into BinaryFormat as is the case for DWARF >>> features used by MC? >>> >> >> I'd be OK with that. We could very easily introduce true link >> dependencies on that library in the near future. >> &gt...

...g at fixing some layering violations in LLVM & came across a >>>>> few in the CodeView handling, specifically: >>>>> >>>>> lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers >>>>> I guess MC could be made dependent on DebugInfoCodeView? But >>>>> probably these things should be sunk into BinaryFormat as is the case for >>>>> DWARF features used by MC? >>>>> >>>> >>>> I'd be OK with that. We could very easily introduce true link >>>> dependencies...

...layering violations in LLVM & came across >>>>>> a few in the CodeView handling, specifically: >>>>>> >>>>>> lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers >>>>>> I guess MC could be made dependent on DebugInfoCodeView? But >>>>>> probably these things should be sunk into BinaryFormat as is the case for >>>>>> DWARF features used by MC? >>>>>> >>>>> >>>>> I'd be OK with that. We could very easily introduce true link >>&g...