Displaying 20 results from an estimated 132 matches for "debugfs_create_dir".
2013 Jul 19
4
[patch] virtio: console: fix error handling for debugfs_create_dir()
debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.
Also my static checker doesn't like it when we print the error code, but
it's always just NULL.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
in...
2013 Jul 19
4
[patch] virtio: console: fix error handling for debugfs_create_dir()
debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.
Also my static checker doesn't like it when we print the error code, but
it's always just NULL.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
in...
2012 Dec 20
1
[PATCH] virtio_console: correct error message on failure of debugfs_create_dir
debugfs_create_dir() returns NULL if it fails, there's little point in
calling PTR_ERR on it.
Signed-off-by: Sasha Levin <sasha.levin at oracle.com>
---
drivers/char/virtio_console.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/vir...
2012 Dec 20
1
[PATCH] virtio_console: correct error message on failure of debugfs_create_dir
debugfs_create_dir() returns NULL if it fails, there's little point in
calling PTR_ERR on it.
Signed-off-by: Sasha Levin <sasha.levin at oracle.com>
---
drivers/char/virtio_console.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/char/virtio_console.c b/drivers/char/vir...
2013 Jul 19
4
[patch] virtio: console: fix error handling for debugfs_create_dir()
On Friday 19 July 2013, Dan Carpenter wrote:
> debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.
> Also my static checker doesn't like it when we print the error code, but
> it's always just NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
This looks wrong. debugfs_create_dir intentionally retur...
2013 Jul 19
4
[patch] virtio: console: fix error handling for debugfs_create_dir()
On Friday 19 July 2013, Dan Carpenter wrote:
> debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.
> Also my static checker doesn't like it when we print the error code, but
> it's always just NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
This looks wrong. debugfs_create_dir intentionally retur...
2013 Jul 21
2
[patch] virtio: console: fix error handling for debugfs_create_dir()
On Saturday 20 July 2013, Dan Carpenter wrote:
> On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote:
> > On Friday 19 July 2013, Dan Carpenter wrote:
> > > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.
> > > Also my static checker doesn't like it when we print the error code, but
> > > it's always just NULL.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> >
> &g...
2013 Jul 21
2
[patch] virtio: console: fix error handling for debugfs_create_dir()
On Saturday 20 July 2013, Dan Carpenter wrote:
> On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote:
> > On Friday 19 July 2013, Dan Carpenter wrote:
> > > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.
> > > Also my static checker doesn't like it when we print the error code, but
> > > it's always just NULL.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> >
> &g...
2013 Jul 20
0
[patch] virtio: console: fix error handling for debugfs_create_dir()
On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote:
> On Friday 19 July 2013, Dan Carpenter wrote:
> > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.
> > Also my static checker doesn't like it when we print the error code, but
> > it's always just NULL.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> This looks wrong. debugfs_...
2013 Jul 21
0
[patch] virtio: console: fix error handling for debugfs_create_dir()
On Sun, Jul 21, 2013 at 11:36:25AM +0200, Arnd Bergmann wrote:
> On Saturday 20 July 2013, Dan Carpenter wrote:
> > On Fri, Jul 19, 2013 at 12:28:41PM +0200, Arnd Bergmann wrote:
> > > On Friday 19 July 2013, Dan Carpenter wrote:
> > > > debugfs_create_dir() returns ERR_PTR(-ENODEV) if debugfs is disabled.
> > > > Also my static checker doesn't like it when we print the error code, but
> > > > it's always just NULL.
> > > >
> > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>...
2013 Jul 21
0
[patch] virtio: console: fix error handling for debugfs_create_dir()
> I don't see where that oops would happen. In the code I'm looking at,
> all uses of ->debugfs_dir only ever get passed into other debugfs
> functions that are stubbed out to empty inline functions.
>
> It's not the most obvious interface design, but this all seems intentional
> and correct to me.
Ah. Ok. You're right.
regards,
dan carpenter
2013 Jul 29
2
[patch v2] virtio: console: cleanup an error message
...> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> index 1b456fe..4cf46d8 100644
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -2215,10 +2215,8 @@ static int __init init(void)
> }
>
> pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> - if (!pdrvdata.debugfs_dir) {
> - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
> - PTR_ERR(pdrvdata.debugfs_dir));
> - }
> + if (!pdrvdata.debugfs_dir)
> + pr_warning("Error creating debugfs dir for virti...
2013 Jul 29
2
[patch v2] virtio: console: cleanup an error message
...> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> index 1b456fe..4cf46d8 100644
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -2215,10 +2215,8 @@ static int __init init(void)
> }
>
> pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> - if (!pdrvdata.debugfs_dir) {
> - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
> - PTR_ERR(pdrvdata.debugfs_dir));
> - }
> + if (!pdrvdata.debugfs_dir)
> + pr_warning("Error creating debugfs dir for virti...
2014 Feb 26
0
[PATCH RFC v5 8/8] pvqspinlock, x86: Enable KVM to use qspinlock's PV support
...struct dentry *d_spin_debug;
+static struct dentry *d_kvm_debug;
+static u32 lh_kick_stats; /* Lock holder kick count */
+static u32 qh_kick_stats; /* Queue head kick count */
+static u32 nn_kick_stats; /* Next node kick count */
+
+static int __init kvm_spinlock_debugfs(void)
+{
+ d_kvm_debug = debugfs_create_dir("kvm-guest", NULL);
+ if (!d_kvm_debug) {
+ printk(KERN_WARNING
+ "Could not create 'kvm' debugfs directory\n");
+ return -ENOMEM;
+ }
+ d_spin_debug = debugfs_create_dir("spinlocks", d_kvm_debug);
+
+ debugfs_create_u32("lh_kick_stats", 064...
2013 Jul 29
1
[patch v2] virtio: console: cleanup an error message
...console.c
> > > index 1b456fe..4cf46d8 100644
> > > --- a/drivers/char/virtio_console.c
> > > +++ b/drivers/char/virtio_console.c
> > > @@ -2215,10 +2215,8 @@ static int __init init(void)
> > > }
> > >
> > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> > > - if (!pdrvdata.debugfs_dir) {
> > > - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
> > > - PTR_ERR(pdrvdata.debugfs_dir));
> > > - }
> > > + if (!pdrvdata.debugfs_dir)
> > &...
2013 Jul 29
1
[patch v2] virtio: console: cleanup an error message
...console.c
> > > index 1b456fe..4cf46d8 100644
> > > --- a/drivers/char/virtio_console.c
> > > +++ b/drivers/char/virtio_console.c
> > > @@ -2215,10 +2215,8 @@ static int __init init(void)
> > > }
> > >
> > > pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
> > > - if (!pdrvdata.debugfs_dir) {
> > > - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
> > > - PTR_ERR(pdrvdata.debugfs_dir));
> > > - }
> > > + if (!pdrvdata.debugfs_dir)
> > &...
2013 Jan 17
1
[RFC] virtio_console: Add DRIVER and INTERFACE to uevent.
...dev->parent ? dev_name(dev->parent) : "",
+ dev_name(dev));
+}
+
static int __init init(void)
{
int err;
@@ -2201,6 +2222,7 @@ static int __init init(void)
return err;
}
+ pdrvdata.class->dev_uevent = class_virtio_ports_uevent;
pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
if (!pdrvdata.debugfs_dir) {
pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
--
1.7.5.4
2013 Jan 17
1
[RFC] virtio_console: Add DRIVER and INTERFACE to uevent.
...dev->parent ? dev_name(dev->parent) : "",
+ dev_name(dev));
+}
+
static int __init init(void)
{
int err;
@@ -2201,6 +2222,7 @@ static int __init init(void)
return err;
}
+ pdrvdata.class->dev_uevent = class_virtio_ports_uevent;
pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
if (!pdrvdata.debugfs_dir) {
pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
--
1.7.5.4
2014 Mar 12
0
[PATCH RFC v6 10/11] pvqspinlock, x86: Enable qspinlock PV support for KVM
...struct dentry *d_spin_debug;
+static struct dentry *d_kvm_debug;
+static u32 lh_kick_stats; /* Lock holder kick count */
+static u32 qh_kick_stats; /* Queue head kick count */
+static u32 hibernate_stats; /* Hibernation count */
+
+static int __init kvm_spinlock_debugfs(void)
+{
+ d_kvm_debug = debugfs_create_dir("kvm-guest", NULL);
+ if (!d_kvm_debug) {
+ printk(KERN_WARNING
+ "Could not create 'kvm' debugfs directory\n");
+ return -ENOMEM;
+ }
+ d_spin_debug = debugfs_create_dir("spinlocks", d_kvm_debug);
+
+ debugfs_create_u32("lh_kick_stats", 064...
2018 Aug 28
0
[PATCH v2 3/4] drm/dp_mst: Add dp_mst_status debugfs node for all drivers
...r *minor = mgr->dev->primary;
+ struct dentry *root;
+ bool put_ref = false;
+
+ /* Create the dp_mst directory for this device if it doesn't exist
+ * already
+ */
+ root = debugfs_lookup("dp_mst", minor->debugfs_root);
+ if (root) {
+ put_ref = true;
+ } else {
+ root = debugfs_create_dir("dp_mst", minor->debugfs_root);
+ if (!root || IS_ERR(root))
+ return;
+ }
+
+ mgr->debugfs = debugfs_create_dir(init_data->connector_name, root);
+ if (!mgr->debugfs)
+ goto out_dput;
+
+ debugfs_create_file("state", 0444, mgr->debugfs, mgr,
+ &drm_...