search for: debugfactory

So, one feature of the late, lamented DebugInfoBuilder that I am missing quite badly, and which is not available in the current DIFactory, is the ability to specify structure offsets abstractly. The DebugFactory requires that you pass in structure offset information as ints, whereas DebugInfoBuilder had "offsetOf" and "alignOf" methods, similar to the "sizeOf" trick, that would create the constants for you in a way that didn't require your front end to know the sizes o...

On Tue, Sep 22, 2009 at 12:14 AM, Talin <viridia at gmail.com> wrote: > So, one feature of the late, lamented DebugInfoBuilder that I am missing > quite badly, and which is not available in the current DIFactory, is the > ability to specify structure offsets abstractly. The DebugFactory > requires that you pass in structure offset information as ints, whereas > DebugInfoBuilder had "offsetOf" and "alignOf" methods, similar to the > "sizeOf" trick, that would create the constants for you in a way that > didn't require your front end to...

...Tue, Sep 22, 2009 at 12:14 AM, Talin <viridia at gmail.com> wrote: >> So, one feature of the late, lamented DebugInfoBuilder that I am missing >> quite badly, and which is not available in the current DIFactory, is the >> ability to specify structure offsets abstractly. The DebugFactory >> requires that you pass in structure offset information as ints, whereas >> DebugInfoBuilder had "offsetOf" and "alignOf" methods, similar to the >> "sizeOf" trick, that would create the constants for you in a way that >> didn't require yo...

...009 at 12:14 AM, Talin <viridia at gmail.com> wrote: > >> So, one feature of the late, lamented DebugInfoBuilder that I am missing > >> quite badly, and which is not available in the current DIFactory, is the > >> ability to specify structure offsets abstractly. The DebugFactory > >> requires that you pass in structure offset information as ints, whereas > >> DebugInfoBuilder had "offsetOf" and "alignOf" methods, similar to the > >> "sizeOf" trick, that would create the constants for you in a way that > >> d...

...gt; wrote: >> >> So, one feature of the late, lamented DebugInfoBuilder that I am >> >> missing >> >> quite badly, and which is not available in the current DIFactory, is >> >> the >> >> ability to specify structure offsets abstractly. The DebugFactory >> >> requires that you pass in structure offset information as ints, whereas >> >> DebugInfoBuilder had "offsetOf" and "alignOf" methods, similar to the >> >> "sizeOf" trick, that would create the constants for you in a way that &gt...

On Wed, Sep 23, 2009 at 1:51 PM, Dan Gohman <gohman at apple.com> wrote: > > On Sep 22, 2009, at 4:49 PM, Talin wrote: > >> >> // Calculate the size of the specified LLVM type. >> Constant * DebugInfoBuilder::getSize(const Type * type) { >> Constant * one = ConstantInt::get(Type::Int32Ty, 1); >> return ConstantExpr::getPtrToInt( >>

The old patch works, it's just that when you pass "0, 0, 0" for size, align and offset the compiler can't decide which method to call since "0" can be either a pointer or an integer. I can produce a new patch if you like, but I'm having trouble thinking of good names for the new methods. Alternatively, I suppose we could re-arrange the order of the parameters

On Sep 22, 2009, at 4:49 PM, Talin wrote: > > // Calculate the size of the specified LLVM type. > Constant * DebugInfoBuilder::getSize(const Type * type) { > Constant * one = ConstantInt::get(Type::Int32Ty, 1); > return ConstantExpr::getPtrToInt( > ConstantExpr::getGetElementPtr( > ConstantPointerNull::get(PointerType::getUnqual(type)), >

Here is a patch that does just that. On Wed, Sep 23, 2009 at 3:38 PM, Devang Patel <devang.patel at gmail.com>wrote: > On Wed, Sep 23, 2009 at 2:27 PM, Talin <viridia at gmail.com> wrote: > > On Wed, Sep 23, 2009 at 1:51 PM, Dan Gohman <gohman at apple.com> wrote: > >> > >> On Sep 22, 2009, at 4:49 PM, Talin wrote: > >>> > >>>

OK so the problem is that the compiler sees '0' and can't decide whether its an integer or a null pointer of type Constant *. I guess the new functions will have to have slightly different names. On Wed, Oct 7, 2009 at 9:50 AM, Devang Patel <devang.patel at gmail.com> wrote: > On Thu, Oct 1, 2009 at 8:34 PM, Talin <viridia at gmail.com> wrote: > > Here is a patch

On Wed, Sep 23, 2009 at 2:27 PM, Talin <viridia at gmail.com> wrote: > On Wed, Sep 23, 2009 at 1:51 PM, Dan Gohman <gohman at apple.com> wrote: >> >> On Sep 22, 2009, at 4:49 PM, Talin wrote: >>> >>> // Calculate the size of the specified LLVM type. >>> Constant * DebugInfoBuilder::getSize(const Type * type) { >>>    Constant * one =

On Thu, Oct 1, 2009 at 8:34 PM, Talin <viridia at gmail.com> wrote: > Here is a patch that does just that. This does not work. I'm getting llvm/tools/clang/lib/CodeGen/CGDebugInfo.cpp: In member function ‘llvm::DIType clang::CodeGen::CGDebugInfo::CreateQualifiedType(clang::QualType, llvm::DICompileUnit)’: /Users/yash/clean/llvm/tools/clang/lib/CodeGen/CGDebugInfo.cpp:225: error:

...ters. However, I'm also seeing a lot of new problems which weren't exposed before. After spending the better part of two days working on them, I'd like to describe them here and get some advice on what I might be doing wrong. #1) Class sizes coming out as zero. In my frontend, I call DebugFactory::CreateCompositeTypeEx as follows: DICompositeType di = dbgFactory_.CreateCompositeTypeEx( type->typeClass() == Type::Class ? dwarf::DW_TAG_class_type : dwarf::DW_TAG_structure_type, dbgCompileUnit_, type->typeDefn()->linkageName().c_str(), genDIFile(type->typ...

...9;m also seeing a lot of new problems which weren't exposed before. After spending the better part of two days working on them, I'd like to describe them here and get some advice on what I might be doing wrong. > > #1) Class sizes coming out as zero. > > In my frontend, I call DebugFactory::CreateCompositeTypeEx as follows: > > DICompositeType di = dbgFactory_.CreateCompositeTypeEx( > type->typeClass() == Type::Class ? dwarf::DW_TAG_class_type : dwarf::DW_TAG_structure_type, > dbgCompileUnit_, > type->typeDefn()->linkageName().c_str(), &gt...

...seeing a lot of new problems which weren't exposed > before. After spending the better part of two days working on them, I'd like > to describe them here and get some advice on what I might be doing wrong. > > #1) Class sizes coming out as zero. > > In my frontend, I call DebugFactory::CreateCompositeTypeEx as follows: > > DICompositeType di = dbgFactory_.CreateCompositeTypeEx( > type->typeClass() == Type::Class ? dwarf::DW_TAG_class_type : > dwarf::DW_TAG_structure_type, > dbgCompileUnit_, > type->typeDefn()->linkageName().c_str(),...

...a lot of new problems which weren't exposed before. After spending the better part of two days working on them, I'd like to describe them here and get some advice on what I might be doing wrong. >> >> #1) Class sizes coming out as zero. >> >> In my frontend, I call DebugFactory::CreateCompositeTypeEx as follows: >> >> DICompositeType di = dbgFactory_.CreateCompositeTypeEx( >> type->typeClass() == Type::Class ? dwarf::DW_TAG_class_type : dwarf::DW_TAG_structure_type, >> dbgCompileUnit_, >> type->typeDefn()->linkag...

...blems which weren't exposed >> before. After spending the better part of two days working on them, I'd like >> to describe them here and get some advice on what I might be doing wrong. >> >> #1) Class sizes coming out as zero. >> >> In my frontend, I call DebugFactory::CreateCompositeTypeEx as follows: >> >> DICompositeType di = dbgFactory_.CreateCompositeTypeEx( >> type->typeClass() == Type::Class ? dwarf::DW_TAG_class_type : >> dwarf::DW_TAG_structure_type, >> dbgCompileUnit_, >> type->typeDefn()-&g...

...exposed >>> before. After spending the better part of two days working on them, I'd like >>> to describe them here and get some advice on what I might be doing wrong. >>> >>> #1) Class sizes coming out as zero. >>> >>> In my frontend, I call DebugFactory::CreateCompositeTypeEx as follows: >>> >>> DICompositeType di = dbgFactory_.CreateCompositeTypeEx( >>> type->typeClass() == Type::Class ? dwarf::DW_TAG_class_type : >>> dwarf::DW_TAG_structure_type, >>> dbgCompileUnit_, >>>...