search for: debug_ls

From: Thomas Jones I have several user-defined functions. As is standard practice, I am defining a logical vector named idebug in order to control debugging printouts. For example, if idebug [1] has the value TRUE, such-and-such debugging printouts are enabled. After the function works, some or all of the debugging printouts can be inhibited. idebug is a global variable; otherwise, it would

This is a repost of a previously posted set. It's been updated following review comments. [PATCH 1/4] Add a core_pattern debug command Added missing return statements. [PATCH 2/4] Call sync after guestfsd exits Remove redundant sleep 1; sync [PATCH 3/4] Shut down the appliance cleanly [PATCH 4/4] Ignore launch() error in virt-rescue These were previously 2 patches. They are otherwise

[PATCH 1/3] Add a core_pattern debug command The first patch is just a rework of Rich's earlier core dump patch. It turns it into a debug subcommand so it can be called at any time. This also has the advantage of explicitly labelling an extremely untidy API as debug. [PATCH 2/3] Call sync after guestfsd exits The second patch seems to be required for cores to be dumped reliably. I was able to

These two patches are probably not completely independent, but separating them is a lot of work. With *both* patches applied, all the tests and extra-tests pass. That's no guarantee however that there isn't a mistake, so I don't think this patch is a candidate for the 1.16 branch, until it's had a lot more testing in development. Rich.

...buf split_lines_sb (char *str); extern char **split_lines (char *str); diff --git a/daemon/debug.c b/daemon/debug.c index b18d87c26..e2d43a7ca 100644 --- a/daemon/debug.c +++ b/daemon/debug.c @@ -444,7 +444,7 @@ debug_ldd (const char *subcmd, size_t argc, char *const *const argv) static char * debug_ls (const char *subcmd, size_t argc, char *const *const argv) { - const size_t len = count_strings (argv); + const size_t len = guestfs_int_count_strings (argv); CLEANUP_FREE const char **cargv = NULL; size_t i; int r; @@ -477,7 +477,7 @@ debug_ls (const char *subcmd, size_t argc, char *co...

...uint64_t position = 0, size = (uint64_t) ssize; > + CLEANUP_FREE char *buf; Missing "= NULL" here. > diff --git a/daemon/debug.c b/daemon/debug.c > index 5637939..6059603 100644 > --- a/daemon/debug.c > +++ b/daemon/debug.c > @@ -437,12 +437,18 @@ static char * > debug_ls (const char *subcmd, size_t argc, char *const *const argv) > { > size_t len = count_strings (argv); > - const char *cargv[len+3]; > + CLEANUP_FREE const char **cargv; Missing "= NULL" here. > diff --git a/daemon/fill.c b/daemon/fill.c > index a9a3aa7..b1d2180 100...

Hi, this patch series improves the way /usr filesystems are handled: tag them appropriately, so later on we can find them and merge results they contain directly back for the root filesystem. The series includes also a new private debug API, and its usage to fix the resolution of /dev/mapper/.. devices found in fstab; without it, LVM /usr filesystems are not recognized as belonging to their

...buf) - n = sizeof buf; + if (n64 > BUFSIZ) + n = BUFSIZ; else n = (size_t) n64; /* safe because of if condition */ diff --git a/daemon/debug.c b/daemon/debug.c index 5637939..6059603 100644 --- a/daemon/debug.c +++ b/daemon/debug.c @@ -437,12 +437,18 @@ static char * debug_ls (const char *subcmd, size_t argc, char *const *const argv) { size_t len = count_strings (argv); - const char *cargv[len+3]; + CLEANUP_FREE const char **cargv; size_t i; int r; char *out; CLEANUP_FREE char *err = NULL; + cargv = malloc (sizeof (char *) * (len+3)); + if (cargv =...

Various changes/fixes to use smaller stack frames. Rich.

...of the moon. */ - r = command (&out, &err, "ldd", "-r", argv[0], NULL); + r = command (&out, &err, str_ldd, "-r", argv[0], NULL); if (r == -1) { reply_with_error ("ldd: %s: %s", argv[0], err); free (out); @@ -389,7 +402,7 @@ debug_ls (const char *subcmd, size_t argc, char *const *const argv) const char *cargv[len+3]; size_t i; - cargv[0] = "ls"; + cargv[0] = str_ls; cargv[1] = "-a"; for (i = 0; i < len; ++i) cargv[2+i] = argv[i]; @@ -419,7 +432,7 @@ debug_ll (const char *subcmd, size_...

...of the moon. */ - r = command (&out, &err, "ldd", "-r", argv[0], NULL); + r = command (&out, &err, str_ldd, "-r", argv[0], NULL); if (r == -1) { reply_with_error ("ldd: %s: %s", argv[0], err); free (out); @@ -389,7 +402,7 @@ debug_ls (const char *subcmd, size_t argc, char *const *const argv) const char *cargv[len+3]; size_t i; - cargv[0] = "ls"; + cargv[0] = str_ls; cargv[1] = "-a"; for (i = 0; i < len; ++i) cargv[2+i] = argv[i]; @@ -419,7 +432,7 @@ debug_ll (const char *subcmd, size_...

...of the moon. */ - r = command (&out, &err, str_ldd, "-r", argv[0], NULL); + r = command (&out, &err, "ldd", "-r", argv[0], NULL); if (r == -1) { reply_with_error ("ldd: %s: %s", argv[0], err); free (out); @@ -457,7 +444,7 @@ debug_ls (const char *subcmd, size_t argc, char *const *const argv) return NULL; } - cargv[0] = str_ls; + cargv[0] = "ls"; cargv[1] = "-a"; for (i = 0; i < len; ++i) cargv[2+i] = argv[i]; @@ -490,7 +477,7 @@ debug_ll (const char *subcmd, size_t argc, char *const...

...of the moon. */ - r = command (&out, &err, str_ldd, "-r", argv[0], NULL); + r = command (&out, &err, "ldd", "-r", argv[0], NULL); if (r == -1) { reply_with_error ("ldd: %s: %s", argv[0], err); free (out); @@ -457,7 +447,7 @@ debug_ls (const char *subcmd, size_t argc, char *const *const argv) return NULL; } - cargv[0] = str_ls; + cargv[0] = "ls"; cargv[1] = "-a"; for (i = 0; i < len; ++i) cargv[2+i] = argv[i]; @@ -490,7 +480,7 @@ debug_ll (const char *subcmd, size_t argc, char *const...

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

This is just the utilities part of the patch series from: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html I believe this addresses everything raised in comments on that patch series. Rich.

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

This is a combination of: https://www.redhat.com/archives/libguestfs/2017-June/msg00046.html [PATCH 00/12] Refactor utility functions. plus: https://www.redhat.com/archives/libguestfs/2017-June/msg00023.html [PATCH v3 00/19] Allow APIs to be implemented in OCaml. with the second patches rebased on top of the utility refactoring, and some other adjustments and extensions. This passes

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.