search for: deactivate_locked_super

...&subvol_rootid, &fs_devices); if (error) return error; @@ -786,15 +801,17 @@ static int btrfs_get_sb(struct file_system_type *fs_type, int flags, s->s_flags |= MS_ACTIVE; } - root = get_default_root(s, subvol_objectid); - if (IS_ERR(root)) { - error = PTR_ERR(root); - deactivate_locked_super(s); - goto error_free_subvol_name; - } /* if they gave us a subvolume name bind mount into that */ if (strcmp(subvol_name, ".")) { struct dentry *new_root; + + root = get_default_root(s, subvol_rootid); + if (IS_ERR(root)) { + error = PTR_ERR(root); + deactivate_locked_sup...

...] ? check_and_collect+0x30/0x30 [ 1529.936714] [<ffffffff811c3985>] shrink_dcache_for_umount+0x75/0x120 [ 1529.936714] [<ffffffff811adf21>] generic_shutdown_super+0x21/0xf0 [ 1529.936714] [<ffffffff811ae207>] kill_block_super+0x27/0x70 [ 1529.936714] [<ffffffff811ae4ed>] deactivate_locked_super+0x3d/0x60 [ 1529.936714] [<ffffffff811aea96>] deactivate_super+0x46/0x60 [ 1529.936714] [<ffffffff811ca277>] mntput_no_expire+0xa7/0x140 [ 1529.936714] [<ffffffff811cb6ce>] SyS_umount+0x8e/0x100 [ 1529.936714] [<ffffffff815d2c29>] system_call_fastpath+0x16/0x1b [ 1529.93...

...] ? check_and_collect+0x30/0x30 [ 1529.936714] [<ffffffff811c3985>] shrink_dcache_for_umount+0x75/0x120 [ 1529.936714] [<ffffffff811adf21>] generic_shutdown_super+0x21/0xf0 [ 1529.936714] [<ffffffff811ae207>] kill_block_super+0x27/0x70 [ 1529.936714] [<ffffffff811ae4ed>] deactivate_locked_super+0x3d/0x60 [ 1529.936714] [<ffffffff811aea96>] deactivate_super+0x46/0x60 [ 1529.936714] [<ffffffff811ca277>] mntput_no_expire+0xa7/0x140 [ 1529.936714] [<ffffffff811cb6ce>] SyS_umount+0x8e/0x100 [ 1529.936714] [<ffffffff815d2c29>] system_call_fastpath+0x16/0x1b [ 1529.93...

Hi, this shown up today. I had to do a hard reboot as graceful hanged on sync(). ------------[ cut here ]------------ kernel BUG at fs/btrfs/delayed-inode.c:1466! invalid opcode: 0000 [#1] SMP CPU 10 Modules linked in: btrfs zlib_deflate lzo_compress ipmi_devintf autofs4 be2iscsi iscsi_boot_sysfs ib_iser rdma_cm ib_cm iw_cm ib_sa ib_mad ib_addr iscsi_tcp bnx2i cnic uio ipv6 cxgb3i libcxgbi

...8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] dquot_load_quota_sb+0x34b/0x680 dquot_load_quota_inode+0xfe/0x1a0 ocfs2_enable_quotas+0x190/0...

...1fd <0> ffff8800c2e32968 ffffffffa034db10 ffff8800a9d3dcf8 ffffffff8112af26 Call Trace: [<ffffffff8113b1fd>] shrink_dcache_for_umount+0x40/0x51 [<ffffffff8112af26>] generic_shutdown_super+0x1f/0xe1 [<ffffffff8112b03d>] kill_anon_super+0x16/0x54 [<ffffffff8112b604>] deactivate_locked_super+0x26/0x46 [<ffffffffa02fdaeb>] btrfs_get_sb+0x360/0x3ec [btrfs] [<ffffffff81111378>] ? alloc_pages_current+0xb2/0xc2 [<ffffffff8112b85a>] vfs_kern_mount+0xad/0x1a0 [<ffffffff8112b9b5>] do_kern_mount+0x4d/0xef [<ffffffff81141cbc>] do_mount+0x732/0x78f [<fffffff...

...t+0x30/0x30 > [ 1529.936714] [<ffffffff811c3985>] shrink_dcache_for_umount+0x75/0x120 > [ 1529.936714] [<ffffffff811adf21>] generic_shutdown_super+0x21/0xf0 > [ 1529.936714] [<ffffffff811ae207>] kill_block_super+0x27/0x70 > [ 1529.936714] [<ffffffff811ae4ed>] deactivate_locked_super+0x3d/0x60 > [ 1529.936714] [<ffffffff811aea96>] deactivate_super+0x46/0x60 > [ 1529.936714] [<ffffffff811ca277>] mntput_no_expire+0xa7/0x140 > [ 1529.936714] [<ffffffff811cb6ce>] SyS_umount+0x8e/0x100 > [ 1529.936714] [<ffffffff815d2c29>] system_call_fastpath...

...TASK> > ... > timer_delete+0x54/0xc0 > try_to_grab_pending+0x31/0x230 > __cancel_work_timer+0x6c/0x270 > ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] > ocfs2_dismount_volume+0xdd/0x450 [ocfs2] > generic_shutdown_super+0xaa/0x280 > kill_block_super+0x46/0x70 > deactivate_locked_super+0x4d/0xb0 > cleanup_mnt+0x135/0x1f0 > ... > </TASK> > > Allocated by task 632: > kasan_save_stack+0x1c/0x40 > kasan_set_track+0x21/0x30 > __kasan_kmalloc+0x8b/0x90 > ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] > dquot_load_quota_sb+0x34b/0x680 > dquot_l...

On Fri, 26 May 2023 09:36:25 +0800 Joseph Qi <joseph.qi at linux.alibaba.com> wrote: > Hi Andrew, > > There is an updated version v2, which describe more clearly about the > case: > https://lore.kernel.org/ocfs2-devel/e9fc4b2f-1fcc-7c31-f346-59eccff50f9b at linux.alibaba.com/T/#u Sigh. Thanks. As you can see from the above link, the email never hit ocfs2-devel and never

...021f3c0f20 ffff88007744fe80 Call Trace: [<ffffffff811df969>] shrink_dcache_for_umount+0x49/0x60 [<ffffffff811c8fe1>] generic_shutdown_super+0x21/0xe0 [<ffffffff811c9282>] kill_anon_super+0x12/0x20 [<ffffffffa041827b>] nfs_kill_super+0x1b/0x30 [nfs] [<ffffffff811c962d>] deactivate_locked_super+0x3d/0x60 [<ffffffff811c9c36>] deactivate_super+0x46/0x60 [<ffffffff811e6ac5>] mntput_no_expire+0xc5/0x120 SELinux: initialized (dev 0:40, type nfs4), uses genfs_contexts [<ffffffff811e7bff>] SyS_umount+0x9f/0x3c0 [<ffffffff81614de9>] system_call_fastpath+0x16/0x1b Code: 00...

...ffff81195a57>] btrfs_sync_fs+0x47/0x70 [<ffffffff811029be>] __sync_filesystem+0x5e/0x90 [<ffffffff81102a53>] sync_filesystem+0x43/0x60 [<ffffffff810dc226>] generic_shutdown_super+0x36/0xe0 [<ffffffff810dc361>] kill_anon_super+0x11/0x20 [<ffffffff810dc715>] deactivate_locked_super+0x45/0x80 [<ffffffff810dd115>] deactivate_super+0x45/0x60 [<ffffffff810f753d>] mntput_no_expire+0x9d/0xf0 [<ffffffff810f837a>] sys_umount+0x6a/0x380 [<ffffffff814e6e7b>] system_call_fastpath+0x16/0x1b Code: 33 00 e9 7e fd ff ff 44 89 ce 48 c7 c7 80 a4 78 81 31 c0 e...

I noticed we were getting lots of warnings with xfstest 83 because we have reservations outstanding. This is because we moved the orphan add outside of the truncate, but we don''t actually cleanup our reservation if something fails. This fixes the problem and I no longer see warnings. Thanks, Signed-off-by: Josef Bacik <jbacik@fusionio.com> --- fs/btrfs/inode.c | 2 ++ 1

...btrfs_put_super+0x19/0x20 [btrfs] [ 469.038215] [<ffffffff81191611>] generic_shutdown_super+0x61/0xe0 [ 469.038222] [<ffffffff81191726>] kill_anon_super+0x16/0x30 [ 469.038239] [<ffffffffa054134a>] btrfs_kill_super+0x1a/0x90 [btrfs] [ 469.038246] [<ffffffff81191aa7>] deactivate_locked_super+0x57/0x90 [ 469.038252] [<ffffffff8119265e>] deactivate_super+0x4e/0x70 [ 469.038260] [<ffffffff811acf37>] mntput_no_expire+0xd7/0x130 [ 469.038267] [<ffffffff811adf16>] sys_umount+0x76/0x390 [ 469.038273] [<ffffffff81627969>] system_call_fastpath+0x16/0x1b -- To uns...

...8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] dquot_load_quota_sb+0x34b/0x680 dquot_load_quota_inode+0xfe/0x1a0 ocfs2_enable_quotas+0x190/0...

...8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] dquot_load_quota_sb+0x34b/0x680 dquot_load_quota_inode+0xfe/0x1a0 ocfs2_enable_quotas+0x190/0...

...8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] dquot_load_quota_sb+0x34b/0x680 dquot_load_quota_inode+0xfe/0x1a0 ocfs2_enable_quotas+0x190/0...

...8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] dquot_load_quota_sb+0x34b/0x680 dquot_load_quota_inode+0xfe/0x1a0 ocfs2_enable_quotas+0x190/0...

...8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] dquot_load_quota_sb+0x34b/0x680 dquot_load_quota_inode+0xfe/0x1a0 ocfs2_enable_quotas+0x190/0...

...8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] dquot_load_quota_sb+0x34b/0x680 dquot_load_quota_inode+0xfe/0x1a0 ocfs2_enable_quotas+0x190/0...

...8208 by task umount/669 ... Call Trace: <TASK> ... timer_delete+0x54/0xc0 try_to_grab_pending+0x31/0x230 __cancel_work_timer+0x6c/0x270 ocfs2_disable_quotas.isra.0+0x3e/0xf0 [ocfs2] ocfs2_dismount_volume+0xdd/0x450 [ocfs2] generic_shutdown_super+0xaa/0x280 kill_block_super+0x46/0x70 deactivate_locked_super+0x4d/0xb0 cleanup_mnt+0x135/0x1f0 ... </TASK> Allocated by task 632: kasan_save_stack+0x1c/0x40 kasan_set_track+0x21/0x30 __kasan_kmalloc+0x8b/0x90 ocfs2_local_read_info+0xe3/0x9a0 [ocfs2] dquot_load_quota_sb+0x34b/0x680 dquot_load_quota_inode+0xfe/0x1a0 ocfs2_enable_quotas+0x190/0...