search for: dbgout_calls

On Jun 11, 2010, at 6:44 PM, Michael Spencer wrote: > Here is a full patch including Nathan's COFF support, tests that pass > on Windows, and some changes to lit. > > Obviously the COFF support and changes to lit should be separate > patches in the end. > > http://codereview.appspot.com/1624043/show Hi Guys, What is the status of this patch? Here are some comments on

Here is a full patch including Nathan's COFF support, tests that pass on Windows, and some changes to lit. Obviously the COFF support and changes to lit should be separate patches in the end. http://codereview.appspot.com/1624043/show - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed... Name: COFF-support.patch Type: application/octet-stream Size:

I have updated my patch based on Chris'es feedback. I removed the dbgout_calls macro, but left others in place for now. If there are no objections, I would like to commit this tomorrow evening (~7PM GMT-7). I have compiled and tested it on MSVC, with Michaels testing code and it looks good. Once this is committed, Michaels patch can be applied. -Nathan -------------- next pa...

Nathan, do you have any other changes? If not, I can make these changes and have a patch ready this evening. Sent from my iPhone On Jun 14, 2010, at 2:16 PM, Chris Lattner <clattner at apple.com> wrote: > > On Jun 11, 2010, at 6:44 PM, Michael Spencer wrote: > >> Here is a full patch including Nathan's COFF support, tests that pass >> on Windows, and some

On Jun 14, 2010, at 12:41 PM, Nathan Jeffords wrote: > Michael, > > I have not made any changes since I last posted a patch. If you would like to make the final updates, thats fine by me. I don't mind making the changes either, I can have them done this evening as well. > > Chris, > > As far as naming goes, PE/COFF used in Microsoft's document because they are

...ore comments about the actual implementation, but I'd like to see smaller patches before getting in to details. - Daniel On Tue, Jun 15, 2010 at 12:47 AM, Nathan Jeffords <blunted2night at gmail.com> wrote: > I have updated my patch based on Chris'es feedback. I removed the > dbgout_calls macro, but left others in place for now. If there are no > objections, I would like to commit this tomorrow evening (~7PM GMT-7). I > have compiled and tested it on MSVC, with Michaels testing code and it looks > good. Once this is committed, Michaels patch can be applied. > -Nathan &gt...

Michael, I have not made any changes since I last posted a patch. If you would like to make the final updates, thats fine by me. I don't mind making the changes either, I can have them done this evening as well. Chris, As far as naming goes, PE/COFF used in Microsoft's document because they are describing both their version of COFF, and their Portable Execution format which is a