search for: dbg_notimpl

...include "llvm/ADT/StringMap.h" > + > #include "llvm/Support/COFF.h" > #include "llvm/Support/Debug.h" > #include "llvm/Support/ErrorHandling.h" > #include "llvm/Support/raw_ostream.h" > using namespace llvm; > > -#define dbg_notimpl(x) \ > - do { dbgs() << "not implemented, " << __FUNCTION__ << " (" << x << ")"; \ > +#define dbgout(a, x) \ > + do { dbgs() << a << ", " << __FUNCTION__ << " (" << x << &...

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer

...: " << x << '\n'); llvm_unreachable("unexpected error occured");\ + } while (false) + +#define dbgout_call(x) DEBUG_WITH_TYPE(DEBUG_TYPE"_calls", dbgs() << \ + __FUNCTION__ << " (" << x << ")\n") + +#define dbg_notimpl(x) dbgerr("not imlemented, " << __FUNCTION__ \ + << " (" << x << ")") I'm not a big fan of these macros (plus typos like imlemented) are they really needed? Overall, looks like great progress! -Chris

Here is a full patch including Nathan's COFF support, tests that pass on Windows, and some changes to lit. Obviously the COFF support and changes to lit should be separate patches in the end. http://codereview.appspot.com/1624043/show - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed... Name: COFF-support.patch Type: application/octet-stream Size:

...llvm_unreachable("unexpected error > occured");\ > + } while (false) > + > +#define dbgout_call(x) DEBUG_WITH_TYPE(DEBUG_TYPE"_calls", dbgs() > << \ > + __FUNCTION__ << " (" << x << ")\n") > + > +#define dbg_notimpl(x) dbgerr("not imlemented, " << __FUNCTION__ \ > + << " (" << x << ")") > > I'm not a big fan of these macros (plus typos like imlemented) are > they really needed? > > Overall, looks like gre...

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >  - Please split the patch into at least four parts: >    (1) Add WinCOFFStreamer, with a stub implementation. >    (2) Add WinCOFFObjectWriter, with a stub implementation. >    (3) Fill in WinCOFFStreamer. >    (4) Fill in WinCOFFObjectWriter. Here's the 1'st patch.

On Jun 14, 2010, at 12:41 PM, Nathan Jeffords wrote: > Michael, > > I have not made any changes since I last posted a patch. If you would like to make the final updates, thats fine by me. I don't mind making the changes either, I can have them done this evening as well. > > Chris, > > As far as naming goes, PE/COFF used in Microsoft's document because they are

...achable("unexpected error occured");\ >> + } while (false) >> + >> +#define dbgout_call(x) DEBUG_WITH_TYPE(DEBUG_TYPE"_calls", dbgs() << \ >> + __FUNCTION__ << " (" << x << ")\n") >> + >> +#define dbg_notimpl(x) dbgerr("not imlemented, " << __FUNCTION__ \ >> + << " (" << x << ")") >> >> I'm not a big fan of these macros (plus typos like imlemented) are they >> really needed? >> >> O...