search for: daxdev_f_sync

...r); > > if (IS_ENABLED(CONFIG_DAX_DRIVER)) { > - dax_dev = alloc_dax(md, md->disk->disk_name, &dm_dax_ops); > + dax_dev = alloc_dax(md, md->disk->disk_name, &dm_dax_ops, > + DAXDEV_F_SYNC); Apologies for not realizing this until now, but this is broken. Imaging a device-mapper configuration composed of both 'async' virtio-pmem and 'sync' pmem. The 'sync' flag needs to be unified across all members. I would change this argument to '0' and then arrange...

...r); > > if (IS_ENABLED(CONFIG_DAX_DRIVER)) { > - dax_dev = alloc_dax(md, md->disk->disk_name, &dm_dax_ops); > + dax_dev = alloc_dax(md, md->disk->disk_name, &dm_dax_ops, > + DAXDEV_F_SYNC); Apologies for not realizing this until now, but this is broken. Imaging a device-mapper configuration composed of both 'async' virtio-pmem and 'sync' pmem. The 'sync' flag needs to be unified across all members. I would change this argument to '0' and then arrange...

...dev_dax *__devm_create_dev_dax(struct dax_region *dax_region, int id, * No 'host' or dax_operations since there is no access to this * device outside of mmap of the resulting character device. */ - dax_dev = alloc_dax(dev_dax, NULL, NULL); + dax_dev = alloc_dax(dev_dax, NULL, NULL, DAXDEV_F_SYNC); if (!dax_dev) goto err; diff --git a/drivers/dax/super.c b/drivers/dax/super.c index bbd57ca0634a..b6c44b5062e9 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c @@ -186,6 +186,8 @@ enum dax_device_flags { DAXDEV_ALIVE, /* gate whether dax_flush() calls the low level flush rou...

...NABLED(CONFIG_DAX_DRIVER)) { > > > - dax_dev = alloc_dax(md, md->disk->disk_name, &dm_dax_ops); > > > + dax_dev = alloc_dax(md, md->disk->disk_name, &dm_dax_ops, > > > + DAXDEV_F_SYNC); > > > > Apologies for not realizing this until now, but this is broken. > > Imaging a device-mapper configuration composed of both 'async' > > virtio-pmem and 'sync' pmem. The 'sync' flag needs to be unified > > across all members. I would cha...

...dev_dax *__devm_create_dev_dax(struct dax_region *dax_region, int id, * No 'host' or dax_operations since there is no access to this * device outside of mmap of the resulting character device. */ - dax_dev = alloc_dax(dev_dax, NULL, NULL); + dax_dev = alloc_dax(dev_dax, NULL, NULL, DAXDEV_F_SYNC); if (!dax_dev) goto err; diff --git a/drivers/dax/super.c b/drivers/dax/super.c index 0a339b85133e..bd6509308d05 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c @@ -186,6 +186,8 @@ enum dax_device_flags { DAXDEV_ALIVE, /* gate whether dax_flush() calls the low level flush rou...

.../linux/dax.h b/include/linux/dax.h > index 0dd316a74a29..c97fc0cc7167 100644 > --- a/include/linux/dax.h > +++ b/include/linux/dax.h > @@ -7,6 +7,9 @@ > #include <linux/radix-tree.h> > #include <asm/pgtable.h> > > +/* Flag for synchronous flush */ > +#define DAXDEV_F_SYNC true I'd feel better, i.e. it reads more canonically, if this was defined as (1UL << 0) and the argument to alloc_dax() was changed to 'unsigned long flags' rather than a bool.

...if (IS_ENABLED(CONFIG_DAX_DRIVER)) { > > - dax_dev = alloc_dax(md, md->disk->disk_name, &dm_dax_ops); > > + dax_dev = alloc_dax(md, md->disk->disk_name, &dm_dax_ops, > > + DAXDEV_F_SYNC); > > Apologies for not realizing this until now, but this is broken. > Imaging a device-mapper configuration composed of both 'async' > virtio-pmem and 'sync' pmem. The 'sync' flag needs to be unified > across all members. I would change this argument to ...

...IVER)) { > > > > - dax_dev = alloc_dax(md, md->disk->disk_name, > > > > &dm_dax_ops); > > > > + dax_dev = alloc_dax(md, md->disk->disk_name, > > > > &dm_dax_ops, > > > > + > > > > DAXDEV_F_SYNC); > > > > > > Apologies for not realizing this until now, but this is broken. > > > Imaging a device-mapper configuration composed of both 'async' > > > virtio-pmem and 'sync' pmem. The 'sync' flag needs to be unified > > > across...

...; - dax_dev = alloc_dax(dev_dax, NULL, NULL); > + dax_dev = alloc_dax(dev_dax, NULL, NULL, true); I find apis that take a boolean as unreadable. What does 'true' mean? It wastes time to go look at the function definition vs something like: alloc_dax(dev_dax, NULL, NULL, DAXDEV_F_SYNC);

...s support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in patch 2 - DavidH - Added MST's ack in patch 2. Changes from PATCH v7: - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by tag...

...s support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in patch 2 - DavidH - Added MST's ack in patch 2. Changes from PATCH v7: - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by tag...

...can be reused in virtio-pmem with MCE notifier but without scrubbing(no ACPI/ARS)? Need inputs to confirm if this behaviour is ok or needs any change? Changes from PATCH v7: [1] - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: [1] - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by t...

...can be reused in virtio-pmem with MCE notifier but without scrubbing(no ACPI/ARS)? Need inputs to confirm if this behaviour is ok or needs any change? Changes from PATCH v7: [1] - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: [1] - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by t...

...pport - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in patch 2 - DavidH - Added MST's ack in patch 2. Changes from PATCH v7: [2] - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by tag...

...s support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in patch 2 - DavidH - Added MST's ack in patch 2. Changes from PATCH v7: - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by tag...

...s support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in patch 2 - DavidH - Added MST's ack in patch 2. Changes from PATCH v7: - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by tag...

...s support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in patch 2 - DavidH - Added MST's ack in patch 2. Changes from PATCH v7: - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by tag...

...s support - Dan - Move virtio_pmem.h to nvdimm directory - Dan - Style, indentation & better error messages in patch 2 - DavidH - Added MST's ack in patch 2. Changes from PATCH v7: - Corrected pending request queue logic (patch 2) - Jakub Staro? - Used unsigned long flags for passing DAXDEV_F_SYNC (patch 3) - Dan - Fixed typo => vma 'flag' to 'vm_flag' (patch 4) - Added rob in patch 6 & patch 2 Changes from PATCH v6: - Corrected comment format in patch 5 & patch 6. [Dave] - Changed variable declaration indentation in patch 6 [Darrick] - Add Reviewed-by tag...

...etter error message and remove not required free - Check nd_region before use Changes suggested by - [Jan Kara] - dax_synchronous() for !CONFIG_DAX - Correct 'daxdev_mapping_supported' comment and non-dax implementation Changes suggested by - [Dan Williams] - Pass meaningful flag 'DAXDEV_F_SYNC' to alloc_dax - Gate nvdimm_flush instead of additional async parameter - Move block chaining logic to flush callback than common nvdimm_flush - Use NULL flush callback for generic flush for better readability [Dan, Jan] - Use virtio device id 27 from 25(already used) - [MST] Changes from PAT...

...etter error message and remove not required free - Check nd_region before use Changes suggested by - [Jan Kara] - dax_synchronous() for !CONFIG_DAX - Correct 'daxdev_mapping_supported' comment and non-dax implementation Changes suggested by - [Dan Williams] - Pass meaningful flag 'DAXDEV_F_SYNC' to alloc_dax - Gate nvdimm_flush instead of additional async parameter - Move block chaining logic to flush callback than common nvdimm_flush - Use NULL flush callback for generic flush for better readability [Dan, Jan] - Use virtio device id 27 from 25(already used) - [MST] Changes from PAT...