search for: davemloft

...----------------------------------------- > > Message: 1 > Date: Thu, 27 Jan 2005 22:16:04 +0100 > From: Bart De Schuymer <bdschuym@pandora.be> > Subject: [Bridge] Re: [PATCH/RFC] Reduce call chain length in > netfilter > To: "David S. Miller" <davem@davemloft.net> > Cc: netdev@oss.sgi.com, netfilter-devel@lists.netfilter.org, > bridge@osdl.org, snort2004@mail.ru, gandalf@wlug.westbo.se, > rusty@rustcorp.com.au, dwmw2@infradead.org, ak@suse.de, > shemminger@osdl.org > Message-ID: <1106860564.3389.4.camel@localhost.localdomain...

On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel <idosch at idosch.org> wrote: > > On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote: > > On 20.12.2018 10:12, Ido Schimmel wrote: > > > +Willem > > > > > > On Thu, Dec 20, 2018 at 08:45:40AM +0100, Christian Borntraeger wrote: > > >> Folks, > > >> > >

On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel <idosch at idosch.org> wrote: > > On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote: > > On 20.12.2018 10:12, Ido Schimmel wrote: > > > +Willem > > > > > > On Thu, Dec 20, 2018 at 08:45:40AM +0100, Christian Borntraeger wrote: > > >> Folks, > > >> > >

From: Stephen Hemminger <stephen at networkplumber.org> Date: Tue, 19 Dec 2017 09:55:48 -0800 > could be 10ms, just enough to let udev do its renaming Please, move to some kind of notification or event based handling of this problem. No delay is safe, what if userspace gets swapped out or whatever else might make userspace stall unexpectedly?

From: Stephen Hemminger <stephen at networkplumber.org> Date: Tue, 19 Dec 2017 09:55:48 -0800 > could be 10ms, just enough to let udev do its renaming Please, move to some kind of notification or event based handling of this problem. No delay is safe, what if userspace gets swapped out or whatever else might make userspace stall unexpectedly?

...also removed unneeded typecast. akpm: what on earth is this code doing anyway? cpu_possible_map can be sparse.. Signed-off-by: Jayachandran C. <c.jayachandran@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: David S. Miller <davem@davemloft.net> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c index 66bd932..84b9af7 100644 --- a/net/bridge/netfilter/ebtables.c +++ b/net/bridge/netfilter/ebtables.c @@ -824,9 +824,9 @@ static int translate_table(struct ebt_re if (udc_cnt) { /* this will get free...

When a bridge interface deletes its underlying ports, it should notify netconsole too, like what bonding interface does. Cc: "David S. Miller" <davem at davemloft.net> Signed-off-by: Cong Wang <amwang at redhat.com> --- net/bridge/br_if.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index e1144e1..d243914 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -427,6 +427,7 @@...

...pping from CPU to the preferable virtual-queue. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: Eric Dumazet <erdnetdev at gmail.com> Cc: "David S. Miller" <davem at davemloft.net> Cc: virtualization at lists.linux-foundation.org Cc: netdev at vger.kernel.org Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> --- V7->V8: set vq index unconditionally, make bisect happy, make sure don't introd...

...pping from CPU to the preferable virtual-queue. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: "Michael S. Tsirkin" <mst at redhat.com> Cc: Jason Wang <jasowang at redhat.com> Cc: Eric Dumazet <erdnetdev at gmail.com> Cc: "David S. Miller" <davem at davemloft.net> Cc: virtualization at lists.linux-foundation.org Cc: netdev at vger.kernel.org Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> --- V7->V8: set vq index unconditionally, make bisect happy, make sure don't introd...

On 12/19/2017 10:41 AM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > David Miller <davem at davemloft.net> wrote: > >> From: Stephen Hemminger <stephen at networkplumber.org> >> Date: Tue, 19 Dec 2017 09:55:48 -0800 >> >>> could be 10ms, just enough to let udev do its renaming >> Please, move to some kind of notification or event based handling of >&g...

On 12/19/2017 10:41 AM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > David Miller <davem at davemloft.net> wrote: > >> From: Stephen Hemminger <stephen at networkplumber.org> >> Date: Tue, 19 Dec 2017 09:55:48 -0800 >> >>> could be 10ms, just enough to let udev do its renaming >> Please, move to some kind of notification or event based handling of >&g...

...-function-declaration] > > #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id) > ^ > Let's include cpudata.h in topology_64.h. > > Cc: Sam Ravnborg <sam at ravnborg.org> > Cc: David S. Miller <davem at davemloft.net> > Cc: sparclinux at vger.kernel.org > Suggested-by: Sam Ravnborg <sam at ravnborg.org> > Signed-off-by: Gonglei <arei.gonglei at huawei.com> Acked-by: Sam Ravnborg <sam at ravnborg.org> > --- > arch/sparc/include/asm/topology_64.h | 1 + > 1 file change...

...-function-declaration] > > #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id) > ^ > Let's include cpudata.h in topology_64.h. > > Cc: Sam Ravnborg <sam at ravnborg.org> > Cc: David S. Miller <davem at davemloft.net> > Cc: sparclinux at vger.kernel.org > Suggested-by: Sam Ravnborg <sam at ravnborg.org> > Signed-off-by: Gonglei <arei.gonglei at huawei.com> Acked-by: Sam Ravnborg <sam at ravnborg.org> > --- > arch/sparc/include/asm/topology_64.h | 1 + > 1 file change...

...netdev operation, use signalling instead. added code that looks at skb->xmit_more after the skb has been put in TX VQ. Since some paths process the ring and free the skb immediately, this can cause use after free. Fix by storing xmit_more in a local variable. Cc: David S. Miller <davem at davemloft.net> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- David, am I using the API correctly? Seems to work for me. You used __netif_subqueue_stopped but that seems to use a slightly more expensive test_bit internally. The reason I added a variable for the txq here is because it'...

...netdev operation, use signalling instead. added code that looks at skb->xmit_more after the skb has been put in TX VQ. Since some paths process the ring and free the skb immediately, this can cause use after free. Fix by storing xmit_more in a local variable. Cc: David S. Miller <davem at davemloft.net> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- David, am I using the API correctly? Seems to work for me. You used __netif_subqueue_stopped but that seems to use a slightly more expensive test_bit internally. The reason I added a variable for the txq here is because it'...

From: Evgeny Kravtsunov <emkravts@openvz.org> compare_ether_addr() implicitly requires that the addresses passed are 2-bytes aligned in memory. This is not true for br_stp_change_bridge_id() and br_stp_recalculate_bridge_id() in which one of the addresses is unsigned char *, and thus may not be 2-bytes aligned. Signed-off-by: Evgeny Kravtsunov <emkravts@openvz.org> Signed-off-by:

...phen Hemminger wrote: > On Tue, 19 Dec 2017 11:42:33 -0800 > "Samudrala, Sridhar" <sridhar.samudrala at intel.com> wrote: > >> On 12/19/2017 10:41 AM, Stephen Hemminger wrote: >>> On Tue, 19 Dec 2017 13:21:17 -0500 (EST) >>> David Miller <davem at davemloft.net> wrote: >>> >>>> From: Stephen Hemminger <stephen at networkplumber.org> >>>> Date: Tue, 19 Dec 2017 09:55:48 -0800 >>>> >>>>> could be 10ms, just enough to let udev do its renaming >>>> Please, move to some...

...phen Hemminger wrote: > On Tue, 19 Dec 2017 11:42:33 -0800 > "Samudrala, Sridhar" <sridhar.samudrala at intel.com> wrote: > >> On 12/19/2017 10:41 AM, Stephen Hemminger wrote: >>> On Tue, 19 Dec 2017 13:21:17 -0500 (EST) >>> David Miller <davem at davemloft.net> wrote: >>> >>>> From: Stephen Hemminger <stephen at networkplumber.org> >>>> Date: Tue, 19 Dec 2017 09:55:48 -0800 >>>> >>>>> could be 10ms, just enough to let udev do its renaming >>>> Please, move to some...

...efac27791ee > v4.20-rc1~14^2~382^2~1 > > In v4.19 and before all packets went through tap_get_user. Hmmm, so maybe my bisect wasnt broken at all? It pointed to commit 105bc1306e9b29c2aa2783b9524f7aec9b5a5b1f Merge: 3475372ff60e4 d0e13a1488ad3 Author: David S. Miller <davem at davemloft.net> AuthorDate: Tue Sep 25 20:29:38 2018 -0700 Commit: David S. Miller <davem at davemloft.net> CommitDate: Tue Sep 25 20:29:38 2018 -0700 Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next

Commit-ID: 4a84d61a24296b8253b3f8f7c86ee28df53e2f3b Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=4a84d61a24296b8253b3f8f7c86ee28df53e2f3b Author: David S. Miller <davem at davemloft.net> AuthorDate: Wed, 17 Aug 2011 09:31:17 +0800 Committer: maximilian attems <max at stro.at> CommitDate: Mon, 2 Jul 2012 10:46:37 +0200 [klibc] [SHELL] Allow building without LINEO support Simply specify --disable-lineno to configure. Signed-off-by: David S. Miller <davem at davem...