search for: data_centers

...7,11 +67,23 @@ def find_host(connection): debug("cannot read /etc/vdsm/vdsm.id, using any host: %s" % e) return None - debug("hw_id = %r" % vdsm_id) + system_service = connection.system_service() + storage_name = params['output_storage'] + data_centers = system_service.data_centers_service().list( + search='storage=%s' % storage_name, + case_sensitive=False, + ) + if len(data_centers) == 0: + # The storage domain is not attached to a datacenter + # (shouldn't happen, would fail on disk creation). +...

...+++ b/v2v/rhv-upload-plugin.py @@ -69,14 +69,34 @@ def find_host(connection): debug("hw_id = %r" % vdsm_id) - hosts_service = connection.system_service().hosts_service() + system_service = connection.system_service() + storage_name = params['output_storage'] + data_centers = system_service.data_centers_service().list( + search='storage=%s' % storage_name, + case_sensitive=False, + ) + if len(data_centers) == 0: + # The storage domain is not attached to a datacenter + # (shouldn't happen, would fail on disk creation). +...

...2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index c72f5e181..c6ba1962f 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -70,7 +70,7 @@ def find_host(connection): system_service = connection.system_service() storage_name = params['output_storage'] data_centers = system_service.data_centers_service().list( - search='storage=%s' % storage_name, + search='storage.name=%s' % storage_name, case_sensitive=False, ) if len(data_centers) == 0: -- 2.17.1

...d, 2 insertions(+), 2 deletions(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index c6ba1962f..d787c9598 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -71,7 +71,7 @@ def find_host(connection): storage_name = params['output_storage'] data_centers = system_service.data_centers_service().list( search='storage.name=%s' % storage_name, - case_sensitive=False, + case_sensitive=True, ) if len(data_centers) == 0: # The storage domain is not attached to a datacenter @@ -84,7 +84,7 @@ def find_host(c...

...tion): > debug("cannot read /etc/vdsm/vdsm.id, using any host: %s" % e) > return None > > - debug("hw_id = %r" % vdsm_id) > + system_service = connection.system_service() > + storage_name = params['output_storage'] > + data_centers = system_service.data_centers_service().list( > + search='storage=%s' % storage_name, > + case_sensitive=False, > + ) > + if len(data_centers) == 0: > + # The storage domain is not attached to a datacenter > + # (shouldn't happen, woul...

...annot read /etc/vdsm/vdsm.id, using any host: %s" % e) > return None > > - debug("hw_id = %r" % vdsm_id) > I would leave this as is... > + system_service = connection.system_service() > + storage_name = params['output_storage'] > + data_centers = system_service.data_centers_service().list( > + search='storage=%s' % storage_name, > + case_sensitive=False, > + ) > + if len(data_centers) == 0: > + # The storage domain is not attached to a datacenter > + # (shouldn't happen, woul...

...@@ -69,14 +69,34 @@ def find_host(connection): > > debug("hw_id = %r" % vdsm_id) > > - hosts_service = connection.system_service().hosts_service() > + system_service = connection.system_service() > + storage_name = params['output_storage'] > + data_centers = system_service.data_centers_service().list( > + search='storage=%s' % storage_name, > + case_sensitive=False, > + ) > + if len(data_centers) == 0: > + # The storage domain is not attached to a datacenter > + # (shouldn't happen, woul...

...e = connection.system_service() -# Check whether the specified cluster exists. -clusters_service = system_service.clusters_service() -clusters = clusters_service.list( - search='name=%s' % params['rhv_cluster'], +# Check whether there is a datacenter for the specified storage. +data_centers = system_service.data_centers_service().list( + search='storage.name=%s' % params['output_storage'], case_sensitive=True, ) +if len(data_centers) == 0: + # The storage domain is not attached to a datacenter + # (shouldn't happen, would fail on disk creation). +...

...ean that the SD does not exist. --- v2v/rhv-upload-precheck.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/v2v/rhv-upload-precheck.py b/v2v/rhv-upload-precheck.py index 9ccfd1fdf..0b8087adb 100644 --- a/v2v/rhv-upload-precheck.py +++ b/v2v/rhv-upload-precheck.py @@ -66,6 +66,15 @@ data_centers = system_service.data_centers_service().list( case_sensitive=True, ) if len(data_centers) == 0: + storage_domains = system_service.storage_domains_service().list( + search='name=%s' % params['output_storage'], + case_sensitive=True, + ) + if len(storage...

...f5e181..c6ba1962f 100644 > > --- a/v2v/rhv-upload-plugin.py > > +++ b/v2v/rhv-upload-plugin.py > > @@ -70,7 +70,7 @@ def find_host(connection): > > system_service = connection.system_service() > > storage_name = params['output_storage'] > > data_centers = system_service.data_centers_service().list( > > - search='storage=%s' % storage_name, > > + search='storage.name=%s' % storage_name, > > case_sensitive=False, > > Thanks, pushed (commit 2547df8a0de46bb1447396e07ee0989bc3f8f31e). >...

Hi, I''ve just got hiera deployed into a new puppet environment, and have defined a class as follows: modules/role/manifests/ui.pp ===================== class role::ui ( $public_hostname ) { notify {''role::ui::notify'': message => "role::ui configured for ${::data_center}; hostname: $public_hostname", } } This is then included into

...- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/output/rhv-upload-precheck.py b/output/rhv-upload-precheck.py > index 1dc1b8498a..35ea021032 100644 > --- a/output/rhv-upload-precheck.py > +++ b/output/rhv-upload-precheck.py > @@ -81,7 +81,12 @@ datacenter = data_centers[0] > > # Get the storage domain. > storage_domains = connection.follow_link(datacenter.storage_domains) > -storage_domain = [sd for sd in storage_domains if sd.name == params['output_storage']][0] > +try: > + storage_domain = [sd for sd in storage_domains \ > +...

This patch series fixes various issues in the rhv-upload output mode: - properly find and use RHV resources - cleanup orphan disks, and possibly the current disk transfer on failure In reality, the first 4 patches deal with resources, and the other 4 with cleanups. The latter block can be theoretically sent alone -- I just happened to start working on it as part of my "let's fix

This series extract oVirt SDK and imageio code to make it eaiser to follow the code and improve error handing in open() and close(). The first small patches can be consider as fixes for downstream. Tested based on libguestfs v1.41.5, since I had trouble building virt-v2v and libguestfs from master. Nir Soffer (18): rhv-upload: Remove unused exception class rhv-upload: Check status more

...pload-plugin.py > index c72f5e181..c6ba1962f 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -70,7 +70,7 @@ def find_host(connection): > system_service = connection.system_service() > storage_name = params['output_storage'] > data_centers = system_service.data_centers_service().list( > - search='storage=%s' % storage_name, > + search='storage.name=%s' % storage_name, > case_sensitive=False, Thanks, pushed (commit 2547df8a0de46bb1447396e07ee0989bc3f8f31e). Do we need this in RHEL 7.6?...

https://bugzilla.redhat.com/show_bug.cgi?id=1986386 My RHV instance is dead at the moment so I didn't do much more than check this compiles and passes the one test we have. Also I want to spend as little time as possible on RHV outputs for virt-v2v since the RHV product will be discontinued soon. I did want to point out some things: - The preceeding code is probably wrong.