search for: daiane

From: Julio Faracco <jcfaracco at gmail.com> Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. To enable it, driver should have .ndo_tx_timeout implemented. This serie has two commits: In the past, we implemented a function to recover driver state when this kind of event

From: Julio Faracco <jcfaracco at gmail.com> Driver virtio_net is not handling error events for TX provided by dev_watchdog. This event is reached when transmission queue is having problems to transmit packets. To enable it, driver should have .ndo_tx_timeout implemented. This serie has two commits: In the past, we implemented a function to recover driver state when this kind of event

...warn message. It > notifies the event in some specific queue of device. This function > still counts tx_timeout statistic and consider this event as an error > (one error per queue), reporting it. > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > Cc: Jason Wang <jasowang at redhat.com> > --- > drivers/net/virtio_net.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 27f9b212c9...

...warn message. It > notifies the event in some specific queue of device. This function > still counts tx_timeout statistic and consider this event as an error > (one error per queue), reporting it. > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > Cc: Jason Wang <jasowang at redhat.com> > --- > drivers/net/virtio_net.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 27f9b212c9...

...to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- v1-v2: Tag `net-next` was included to indentify where patch would be applied. --- drivers/net/virtio_net.c | 95 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 94 insertions(+), 1 deletion(-) diff -...

...to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- v1-v2: Tag `net-next` was included to indentify where patch would be applied. --- drivers/net/virtio_net.c | 95 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 94 insertions(+), 1 deletion(-) diff -...

...is only a skeleton to throw a warn message. It notifies the event in some specific queue of device. This function still counts tx_timeout statistic and consider this event as an error (one error per queue), reporting it. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 27f9b212c9f5..4b703b4b9441 100644 --- a/drive...

...stats. This is not so relevant as the method implementation itself. But, on the other hand, I think it should be relevant if we split into tx_timeout per queue. Anyway, suggestions are welcome. > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > > Cc: Jason Wang <jasowang at redhat.com> > > --- > > drivers/net/virtio_net.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c...

...notifies the event in some specific queue of device. This function > > still counts tx_timeout statistic and consider this event as an error > > (one error per queue), reporting it. > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > > Cc: Jason Wang <jasowang at redhat.com> > > --- > > drivers/net/virtio_net.c | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virti...

...called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues, including RX (because we don't have control of this). Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 83 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 82 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 4d7d5434cc5d..fbe...

...to recover TX queues from a error state. That function is called by schedule_work method and it puts the reset function into work queue. As the error cause is unknown at this moment, it would be better to reset all queues. Signed-off-by: Julio Faracco <jcfaracco at gmail.com> Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> Cc: Jason Wang <jasowang at redhat.com> --- drivers/net/virtio_net.c | 95 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 94 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 4d7d5434cc5d..318...

...tate. That function is called by schedule_work method and it puts > the reset function into work queue. > > As the error cause is unknown at this moment, it would be better to > reset all queues. > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > Cc: Jason Wang <jasowang at redhat.com> > --- > v1-v2: Tag `net-next` was included to indentify where patch would be > applied. > --- > drivers/net/virtio_net.c | 95 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 94 i...

...t; > > the reset function into work queue. > > > > > > As the error cause is unknown at this moment, it would be better to > > > reset all queues. > > > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > > > Cc: Jason Wang <jasowang at redhat.com> > > > --- > > > v1-v2: Tag `net-next` was included to indentify where patch would be > > > applied. > > > --- > > > drivers/net/virtio_net.c | 95 +++++++...

...n into work queue. > > > > > > > > As the error cause is unknown at this moment, it would be better to > > > > reset all queues. > > > > > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > > > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > > > > Cc: Jason Wang <jasowang at redhat.com> > > > > --- > > > > v1-v2: Tag `net-next` was included to indentify where patch would be > > > > applied. > > > > --- > > > > drivers...

...schedule_work method and it puts > > the reset function into work queue. > > > > As the error cause is unknown at this moment, it would be better to > > reset all queues. > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > > Cc: Jason Wang <jasowang at redhat.com> > > --- > > v1-v2: Tag `net-next` was included to indentify where patch would be > > applied. > > --- > > drivers/net/virtio_net.c | 95 +++++++++++++++++++++++++++++++++++++...

...schedule_work method and it puts > > the reset function into work queue. > > > > As the error cause is unknown at this moment, it would be better to > > reset all queues. > > > > Signed-off-by: Julio Faracco <jcfaracco at gmail.com> > > Signed-off-by: Daiane Mendes <dnmendes76 at gmail.com> > > Cc: Jason Wang <jasowang at redhat.com> > > --- > > v1-v2: Tag `net-next` was included to indentify where patch would be > > applied. > > --- > > drivers/net/virtio_net.c | 95 +++++++++++++++++++++++++++++++++++++...

This series add two important features. One of them changes the .ndo_tx_timeout to include an extra parameter to identify the stuck queue. Many drivers are using a nester loop to identify which queue is stooped/stucked. This is a redundant work since dev_watchdog is doing exactly the same thing. This is so interesting for other drivers to in terms of code optimization. The second part (second

This series add two important features. One of them changes the .ndo_tx_timeout to include an extra parameter to identify the stuck queue. Many drivers are using a nester loop to identify which queue is stooped/stucked. This is a redundant work since dev_watchdog is doing exactly the same thing. This is so interesting for other drivers to in terms of code optimization. The second part (second