search for: dagiselmatchergen

...s. The problem is that calls aren't being preceded by instructions that put the arguments into registers. I backtracked my working copy and then stepped forward until it broke between r98937 and r98938. Refining further, I found that rolling back the single-statement change to utils/TableGen/DAGISelMatcherGen.cpp -- something about variadic instructions that was probably OK for x86, but MSP430 doesn't have variadic instructions -- restored the correct behavior. Seems like r98938 either introduced a bug in DAGISelMatcherGen.cpp or exposed a bug in MSP430InstrInfo.td (or similar). That's Chris...

...48e2d4 llvm::TreePatternNode::ApplyTypeConstraints(llvm::TreePattern&, bool) /home/nancy/work/rpp_clang/llvm/utils/TableGen/CodeGenDAGPatterns.cpp:2361:0 #16 0x00000000005b3c06 (anonymous namespace)::MatcherGen::InferPossibleTypes(unsigned int) /home/nancy/work/rpp_clang/llvm/utils/TableGen/DAGISelMatcherGen.cpp:184:0 #17 0x00000000005b59ca (anonymous namespace)::MatcherGen::EmitMatchCode(llvm::TreePatternNode const*, llvm::TreePatternNode*, unsigned int) /home/nancy/work/rpp_clang/llvm/utils/TableGen/DAGISelMatcherGen.cpp:491:0 #18 0x00000000005b54ba (anonymous namespace)::MatcherGen::EmitOperatorMatc...

...hat calls aren't being preceded by instructions that put the > arguments into registers.  I backtracked my working copy and then > stepped forward until it broke between r98937 and r98938.  Refining > further, I found that rolling back the single-statement change to > utils/TableGen/DAGISelMatcherGen.cpp -- something about variadic > instructions that was probably OK for x86, but MSP430 doesn't have > variadic instructions -- restored the correct behavior.  Seems like > r98938 either introduced a bug in DAGISelMatcherGen.cpp or exposed a > bug in MSP430InstrInfo.td (or similar)....

...4 llvm::TreePatternNode::ApplyTypeConstraints(llvm::TreePattern&, bool) /home/nancy/work/rpp_clang/llvm/utils/TableGen/CodeGenDAGPatterns.cpp:2361:0 #16 0x00000000005b3c06 (anonymous namespace)::MatcherGen::InferPossibleTypes(unsigned int) /home/nancy/work/rpp_clang/llvm/utils/TableGen/DAGISelMatcherGen.cpp:184:0 #17 0x00000000005b59ca (anonymous namespace)::MatcherGen::EmitMatchCode(llvm::TreePatternNode const*, llvm::TreePatternNode*, unsigned int) /home/nancy/work/rpp_clang/llvm/utils/TableGen/DAGISelMatcherGen.cpp:491:0 #18 0x00000000005b54ba (anonymous namespace)::MatcherGen::EmitOp...

...tuation is rather broken. I'm currently inclined to add a check for mayLoad and mayStore at that point in TableGeni (see patch), but was waiting until I could give tests and justification on the list before submitting it. Tim. -------------- next part -------------- diff --git a/utils/TableGen/DAGISelMatcherGen.cpp b/utils/TableGen/DAGISelMatcherGen.cpp index 2ac7b87..4acd209 100644 --- a/utils/TableGen/DAGISelMatcherGen.cpp +++ b/utils/TableGen/DAGISelMatcherGen.cpp @@ -690,6 +690,12 @@ EmitResultInstructionAsOperand(const TreePatternNode *N, bool NodeHasChain = InstPatNode &&...

...4 llvm::TreePatternNode::ApplyTypeConstraints(llvm::TreePattern&, bool) /home/nancy/work/rpp_clang/llvm/utils/TableGen/CodeGenDAGPatterns.cpp:2361:0 #16 0x00000000005b3c06 (anonymous namespace)::MatcherGen::InferPossibleTypes(unsigned int) /home/nancy/work/rpp_clang/llvm/utils/TableGen/DAGISelMatcherGen.cpp:184:0 #17 0x00000000005b59ca (anonymous namespace)::MatcherGen::EmitMatchCode(llvm::TreePatternNode const*, llvm::TreePatternNode*, unsigned int) /home/nancy/work/rpp_clang/llvm/utils/TableGen/DAGISelMatcherGen.cpp:491:0 #18 0x00000000005b54ba (anonymous namespace)::MatcherGen::EmitOp...

Working on a target I added this pattern: def : Pat<(v4i64 (load xoaddr:$src)), (QVFCTIDb (QVLFDXb xoaddr:$src))>; which represents an actual load followed by a necessary conversion operation. The problem is that when this matches any TokenFactor that was attached to the load node gets attached, not to the inner load instruction, but the outer conversion operation. This is

...----------------------------------------------------------------------------- Unknown leaf kind: IMM16Operand:i16:$ImmA ... #7 0x00000000005210a1 (anonymous namespace)::MatcherGen::EmitLeafMatchCode(llvm::TreePatternNode const*) /home/dte/Projects/CLP/clp-llvm/trunk/llvm-project/llvm/utils/TableGen/DAGISelMatcherGen.cpp:286:0 ------------------------------------------------------------------------------------------------- While looking the DAGISelMatcherGen.cpp around line 286 (version 3.8.0), I've found such a kind of code -----------------------------------------------------------------------------------...

...4 llvm::TreePatternNode::ApplyTypeConstraints(llvm::TreePattern&amp;, bool) /home/nancy/work/rpp_clang/llvm/utils/TableGen/CodeGenDAGPatterns.cpp:2361:0 #16 0x00000000005b3c06 (anonymous namespace)::MatcherGen::InferPossibleTypes(unsigned int) /home/nancy/work/rpp_clang/llvm/utils/TableGen/DAGISelMatcherGen.cpp:184:0 #17 0x00000000005b59ca (anonymous namespace)::MatcherGen::EmitMatchCode(llvm::TreePatternNode const*, llvm::TreePatternNode*, unsigned int) /home/nancy/work/rpp_clang/llvm/utils/TableGen/DAGISelMatcherGen.cpp:491:0 #18 0x00000000005b54ba (anonymous namespace)::MatcherGen::EmitOp...

Hi Peter, I would recommend looking into the implementation of the matcher if you want to add more builtin types: utils/TableGen//DAGISelMatcherGen.cpp That being said, you can define your own types without having to go through that hassle. E.g., from AArch64 def simm9 : Operand<i64>, ImmLeaf<i64, [{ return Imm >= -256 && Imm < 256; }]> { let ParserMatchClass = SImm9Operand; } Wouldn’t that work for you? Cheers,...

...CMakeFiles/obj.llvm-tblgen.dir/CodeGenRegisters.cpp.o CMakeFiles/obj.llvm-tblgen.dir/CodeGenSchedule.cpp.o CMakeFiles/obj.llvm-tblgen.dir/CodeGenTarget.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelEmitter.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherEmitter.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherGen.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherOpt.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcher.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DFAPacketizerEmitter.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DisassemblerEmitter.cpp.o CMakeFiles/obj.llvm-tblgen.dir/FastISelEmitter.cpp.o CMakeFiles/obj.llv...

...nesday, May 25, 2016 5:25 PM To: Lawrence, Peter <c_plawre at qca.qualcomm.com> Cc: llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] dumb question about tblgen Hi Peter, I would recommend looking into the implementation of the matcher if you want to add more builtin types: utils/TableGen//DAGISelMatcherGen.cpp That being said, you can define your own types without having to go through that hassle. E.g., from AArch64 def simm9 : Operand<i64>, ImmLeaf<i64, [{ return Imm >= -256 && Imm < 256; }]> { let ParserMatchClass = SImm9Operand; } Wouldn’t that work for you? Cheers,...

Dumb question about llvm-tblgen for "XyzGenInstrInfo.inc" If I have a pattern in my dot-td-file like this [(set i32:$dst (add i32:$rs1, i32:$rs2))] The question is where does the token "i32" come from, I don't see any definitions for i1, i8, i16, i32, ... in include/llvm/Target/*.td while I do see definitions for tokens like

...CMakeFiles/obj.llvm-tblgen.dir/CodeGenRegisters.cpp.o CMakeFiles/obj.llvm-tblgen.dir/CodeGenSchedule.cpp.o CMakeFiles/obj.llvm-tblgen.dir/CodeGenTarget.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelEmitter.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherEmitter.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherGen.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherOpt.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcher.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DFAPacketizerEmitter.cpp.o CMakeFiles/obj.llvm-tblgen.dir/DisassemblerEmitter.cpp.o CMakeFiles/obj.llvm-tblgen.dir/FastISelEmitter.cpp.o CMakeFiles/obj.llv...

...rs.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/CodeGenSchedule.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/CodeGenTarget.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelEmitter.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherEmitter.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherGen.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherOpt.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcher.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DFAPacketizerEmitter.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DisassemblerEmitter.cpp.o >> CMakeFiles/obj.llvm-tblgen...

...rs.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/CodeGenSchedule.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/CodeGenTarget.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelEmitter.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherEmitter.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherGen.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherOpt.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcher.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DFAPacketizerEmitter.cpp.o >> CMakeFiles/obj.llvm-tblgen.dir/DisassemblerEmitter.cpp.o >> CMakeFiles/obj.llvm-tblgen...

...ence, Peter <c_plawre at qca.qualcomm.com> > Cc: llvm-dev at lists.llvm.org > Subject: Re: [llvm-dev] dumb question about tblgen > > Hi Peter, > > I would recommend looking into the implementation of the matcher if you want to add more builtin types: > utils/TableGen//DAGISelMatcherGen.cpp > > That being said, you can define your own types without having to go through that hassle. > E.g., from AArch64 > def simm9 : Operand<i64>, ImmLeaf<i64, [{ return Imm >= -256 && Imm < 256; }]> { > let ParserMatchClass = SImm9Operand; > } >...

...leGen\CMakeFiles\llvm-tblgen.dir\CodeGenSchedule.cpp.obj utils\TableGen\CMakeFiles\llvm-tblgen.dir\CodeGenTarget.cpp.obj utils\TableGen\CMakeFiles\llvm-tblgen.dir\DAGISelEmitter.cpp.obj utils\TableGen\CMakeFiles\llvm-tblgen.dir\DAGISelMatcherEmitter.cpp.obj utils\TableGen\CMakeFiles\llvm-tblgen.dir\DAGISelMatcherGen.cpp.obj utils\TableGen\CMakeFiles\llvm-tblgen.dir\DAGISelMatcherOpt.cpp.obj utils\TableGen\CMakeFiles\llvm-tblgen.dir\DAGISelMatcher.cpp.obj utils\TableGen\CMakeFiles\llvm-tblgen.dir\DFAPacketizerEmitter.cpp.obj utils\TableGen\CMakeFiles\llvm-tblgen.dir\DisassemblerEmitter.cpp.obj utils\TableGen\CM...

...m-tblgen.dir/CodeGenSchedule.cpp.o >> >> CMakeFiles/obj.llvm-tblgen.dir/CodeGenTarget.cpp.o >> >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelEmitter.cpp.o >> >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherEmitter.cpp.o >> >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherGen.cpp.o >> >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherOpt.cpp.o >> >> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcher.cpp.o >> >> CMakeFiles/obj.llvm-tblgen.dir/DFAPacketizerEmitter.cpp.o >> >> CMakeFiles/obj.llvm-tblgen.dir/DisassemblerEmitter.cpp.o...

....llvm-tblgen.dir/CodeGenSchedule.cpp.o >>>> CMakeFiles/obj.llvm-tblgen.dir/CodeGenTarget.cpp.o >>>> CMakeFiles/obj.llvm-tblgen.dir/DAGISelEmitter.cpp.o >>>> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherEmitter.cpp.o >>>> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherGen.cpp.o >>>> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcherOpt.cpp.o >>>> CMakeFiles/obj.llvm-tblgen.dir/DAGISelMatcher.cpp.o >>>> CMakeFiles/obj.llvm-tblgen.dir/DFAPacketizerEmitter.cpp.o >>>> CMakeFiles/obj.llvm-tblgen.dir/DisassemblerEmitter.cpp.o &gt...