search for: daemon_utils_test

--- .gitignore | 1 + daemon/Makefile.am | 43 ++++++++++++++++++++++++++++++++++++++- daemon/daemon_utils_tests.ml | 48 ++++++++++++++++++++++++++++++++++++++++++++ daemon/dummy.c | 2 ++ docs/C_SOURCE_FILES | 1 + 5 files changed, 94 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 815431b7b..0fb2d258b 100644 --- a/.gitignore +++ b/.gitignore @@ -169,6 +169...

These utility functions will be used in the OCaml inspection code. --- daemon/daemon_utils_tests.ml | 15 +++++++ daemon/utils.ml | 100 +++++++++++++++++++++++++++++++++++++++++++ daemon/utils.mli | 12 ++++++ 3 files changed, 127 insertions(+) diff --git a/daemon/daemon_utils_tests.ml b/daemon/daemon_utils_tests.ml index 892509d89..b1f02de30 100644 --- a/daemon/d...

On Thu, Aug 03, 2017 at 06:08:24PM +0200, Pino Toscano wrote: > But I guess I have no chance to change the current patch (even adding > a test using asserts, instead of oUnit, for which I still did not get > a reason why a new test using it would be unacceptable), so ... Fewer dependencies make the code easier for others to consume, and that's especially true when (like oUnit) those

The previously selected 'atomic' recipe resulted in 2GB swap in a 6GB volume. Also, we don't really need the boot partition, so just create a partition using the whole disk space. --- builder/templates/debian.preseed | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/builder/templates/debian.preseed b/builder/templates/debian.preseed index

Commit 0a94cae15bae7cecb725e78e485708694d347612 added useful headings to parts of the configure script. This refactors the code by adding a common macro (‘HEADING’), and also changes the output so it's clearer at a glance: --- Checking for Haskell --- checking for ghc... (cached) ghc --- Checking for PHP --- checking for php... (cached) php checking for phpize... (cached) phpize

...e.am +++ b/daemon/Makefile.am @@ -59,9 +59,13 @@ generator_built = \ structs.ml \ structs.mli +CONFIGURE_GENERATED_ML = \ + daemon_config.ml + EXTRA_DIST = \ $(generator_built) \ - $(SOURCES_MLI) $(SOURCES_ML) \ + $(SOURCES_MLI) \ + $(filter-out $(CONFIGURE_GENERATED_ML),$(SOURCES_ML)) \ daemon_utils_tests.ml \ guestfsd.pod @@ -297,7 +301,7 @@ SOURCES_MLI = \ utils.mli SOURCES_ML = \ - daemon_config.ml \ + $(CONFIGURE_GENERATED_ML) \ utils.ml \ structs.ml \ optgroups.ml \ diff --git a/python/Makefile.am b/python/Makefile.am index 673de3157..9aca202b5 100644 --- a/python/Makefile.am ++...

...x, and a manually written framework would end up > reimplementing most of it, in the end. If you compare an oUnit test: https://github.com/libguestfs/libguestfs/blob/master/common/mlutils/c_utils_unit_tests.ml to an assert test: https://github.com/libguestfs/libguestfs/blob/master/daemon/daemon_utils_tests.ml There is barely any difference to me. This is my point really: oUnit doesn't bring any particular benefit. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk us...

...up > > reimplementing most of it, in the end. > > If you compare an oUnit test: > > https://github.com/libguestfs/libguestfs/blob/master/common/mlutils/c_utils_unit_tests.ml > > to an assert test: > > https://github.com/libguestfs/libguestfs/blob/master/daemon/daemon_utils_tests.ml > > There is barely any difference to me. This is my point really: oUnit > doesn't bring any particular benefit. Just few points that come into my mind: - better reporting for expected/got values - better interaction for exceptions (e.g. expect/don't expect one) - logging -...

...aemon_config.ml.in create mode 100644 daemon/daemon_config.mli diff --git a/.gitignore b/.gitignore index 8276afb26..233a8c536 100644 --- a/.gitignore +++ b/.gitignore @@ -186,6 +186,7 @@ Makefile.in /daemon/actions.h /daemon/callbacks.ml /daemon/caml-stubs.c +/daemon/daemon_config.ml /daemon/daemon_utils_tests /daemon/dispatch.c /daemon/guestfsd diff --git a/configure.ac b/configure.ac index e293ece65..e3df97fce 100644 --- a/configure.ac +++ b/configure.ac @@ -247,6 +247,7 @@ AC_CONFIG_FILES([Makefile common/windows/Makefile csharp/Makefile customi...

*** BLURB HERE? *** Pino Toscano (6): build: stop shipping files generated by configure docs: fix out-of-source documentation build generator: do not generate mlv2v files when not needed perl: fix path to Build.PL rust: fix path to lib.rs rust: fix list of generator-built files daemon/Makefile.am | 8 ++++++-- docs/Makefile.am | 4 ++-- generator/main.ml | 11

Version 1 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00003.html This patch series reimplements a few more APIs in OCaml, including some very important core APIs like ?list_filesystems? and ?mount?. All the tests pass after this. The selection of APIs that I have moved may look a little random, but in fact they are all APIs consumed by the inspection code (and some more

...onfig_daemon.ml.in create mode 100644 daemon/config_daemon.mli diff --git a/.gitignore b/.gitignore index 8276afb26..59d7278be 100644 --- a/.gitignore +++ b/.gitignore @@ -186,6 +186,7 @@ Makefile.in /daemon/actions.h /daemon/callbacks.ml /daemon/caml-stubs.c +/daemon/config_daemon.ml /daemon/daemon_utils_tests /daemon/dispatch.c /daemon/guestfsd diff --git a/configure.ac b/configure.ac index daf9abf6f..fbba5ab65 100644 --- a/configure.ac +++ b/configure.ac @@ -247,6 +247,7 @@ AC_CONFIG_FILES([Makefile common/windows/Makefile csharp/Makefile customi...

v2 was here: https://www.redhat.com/archives/libguestfs/2017-June/msg00008.html This series gets as far as a working (and faster) reimplementation of ‘guestfs_list_filesystems’. I also have another patch series on top of this one which reimplements the inspection APIs inside the daemon, but that needs a bit more work still, since inspection turns out to be a very large piece of code. Rich.

...ed, 216 insertions(+), 140 deletions(-) diff --git a/.gitignore b/.gitignore index cdc90453c..12bfd45a2 100644 --- a/.gitignore +++ b/.gitignore @@ -147,6 +147,7 @@ Makefile.in /daemon/btrfs.mli /daemon/callbacks.ml /daemon/caml-stubs.c +/daemon/cryptsetup.mli /daemon/daemon_config.ml /daemon/daemon_utils_tests /daemon/devsparts.mli diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 25948dbe9..928916e3d 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -39,6 +39,7 @@ generator_built = \ blkid.mli \ btrfs.mli \ callbacks.ml \ + cryptsetup.mli \ devsparts.mli \ file.mli \ fil...

...ed, 216 insertions(+), 140 deletions(-) diff --git a/.gitignore b/.gitignore index ab4cd0667..39354de51 100644 --- a/.gitignore +++ b/.gitignore @@ -147,6 +147,7 @@ Makefile.in /daemon/btrfs.mli /daemon/callbacks.ml /daemon/caml-stubs.c +/daemon/cryptsetup.mli /daemon/daemon_config.ml /daemon/daemon_utils_tests /daemon/devsparts.mli diff --git a/daemon/Makefile.am b/daemon/Makefile.am index e57e5a506..480192e1c 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -39,6 +39,7 @@ generator_built = \ blkid.mli \ btrfs.mli \ callbacks.ml \ + cryptsetup.mli \ devsparts.mli \ file.mli \ fil...

...the OCaml replacements are better anyway. - Reimplement udev_settle{,_file} as wrappers around C functions. I tried to make this change but it is unexpectedly complex, because it would mean that daemon/utils.ml contains a C function which can only be satisfied by linking to the daemon, but daemon_utils_tests is a standalone program which cannot be linked to the daemon. So we'd either need to create another OCaml module, or split up the C parts of the daemon into "library bits" and "daemon bits". - Removing GUESTFSD_EXT_CMD. This is still being used by OpenSUSE, so we...

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

...re b/.gitignore index bb7026537..6927b8bb5 100644 --- a/.gitignore +++ b/.gitignore @@ -185,21 +185,36 @@ Makefile.in /customize/virt-customize.1 /daemon/.depend /daemon/actions.h +/daemon/blkid.mli +/daemon/btrfs.mli /daemon/callbacks.ml /daemon/caml-stubs.c /daemon/daemon_config.ml /daemon/daemon_utils_tests +/daemon/devsparts.mli /daemon/dispatch.c +/daemon/file.mli +/daemon/filearch.mli +/daemon/findfs.mli /daemon/guestfsd /daemon/guestfsd.8 /daemon/guestfsd.exe +/daemon/inspect.mli +/daemon/is.mli +/daemon/ldm.mli +/daemon/link.mli +/daemon/listfs.mli /daemon/lvm-tokenization.c +/daemon/md.mli...

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.

...re b/.gitignore index bb7026537..e67013478 100644 --- a/.gitignore +++ b/.gitignore @@ -185,21 +185,38 @@ Makefile.in /customize/virt-customize.1 /daemon/.depend /daemon/actions.h +/daemon/blkid.mli +/daemon/btrfs.mli /daemon/callbacks.ml /daemon/caml-stubs.c /daemon/daemon_config.ml /daemon/daemon_utils_tests +/daemon/devsparts.mli /daemon/dispatch.c +/daemon/file.mli +/daemon/filearch.mli +/daemon/findfs.mli /daemon/guestfsd /daemon/guestfsd.8 /daemon/guestfsd.exe +/daemon/inspect.mli +/daemon/is.mli +/daemon/ldm.mli +/daemon/link.mli +/daemon/listfs.mli +/daemon/lvm.mli /daemon/lvm-tokenization....