search for: dac99511c

...make sure to assign the IDs for disks (s_disk_id) from 0 instead of 1, just like all the other input modes not based on libvirt XML. --- v2v/parse_libvirt_xml.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/parse_libvirt_xml.ml b/v2v/parse_libvirt_xml.ml index 78a6e71c0..dac99511c 100644 --- a/v2v/parse_libvirt_xml.ml +++ b/v2v/parse_libvirt_xml.ml @@ -246,7 +246,7 @@ let parse_libvirt_xml ?conn xml = (* Non-removable disk devices. *) let disks = let get_disks, add_disk = - let disks = ref [] and i = ref 0 in + let disks = ref [] and i = ref (-1) in...

...just like all the other input modes not > > based on libvirt XML. > > --- > > v2v/parse_libvirt_xml.ml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/v2v/parse_libvirt_xml.ml b/v2v/parse_libvirt_xml.ml > > index 78a6e71c0..dac99511c 100644 > > --- a/v2v/parse_libvirt_xml.ml > > +++ b/v2v/parse_libvirt_xml.ml > > @@ -246,7 +246,7 @@ let parse_libvirt_xml ?conn xml = > > (* Non-removable disk devices. *) > > let disks = > > let get_disks, add_disk = > > - let disks = ref...

...ead of 1. This does not change the actual behaviour, just makes the IDs like in all the other input modes not based on libvirt XML. --- v2v/parse_libvirt_xml.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/parse_libvirt_xml.ml b/v2v/parse_libvirt_xml.ml index 78a6e71c0..dac99511c 100644 --- a/v2v/parse_libvirt_xml.ml +++ b/v2v/parse_libvirt_xml.ml @@ -246,7 +246,7 @@ let parse_libvirt_xml ?conn xml = (* Non-removable disk devices. *) let disks = let get_disks, add_disk = - let disks = ref [] and i = ref 0 in + let disks = ref [] and i = ref (-1) in...

...libvirt XML. > > > > --- > > > > v2v/parse_libvirt_xml.ml | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/v2v/parse_libvirt_xml.ml b/v2v/parse_libvirt_xml.ml > > > > index 78a6e71c0..dac99511c 100644 > > > > --- a/v2v/parse_libvirt_xml.ml > > > > +++ b/v2v/parse_libvirt_xml.ml > > > > @@ -246,7 +246,7 @@ let parse_libvirt_xml ?conn xml = > > > > (* Non-removable disk devices. *) > > > > let disks = > > > >...

...t; (s_disk_id) from 0 instead of 1, just like all the other input modes not > based on libvirt XML. > --- > v2v/parse_libvirt_xml.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/v2v/parse_libvirt_xml.ml b/v2v/parse_libvirt_xml.ml > index 78a6e71c0..dac99511c 100644 > --- a/v2v/parse_libvirt_xml.ml > +++ b/v2v/parse_libvirt_xml.ml > @@ -246,7 +246,7 @@ let parse_libvirt_xml ?conn xml = > (* Non-removable disk devices. *) > let disks = > let get_disks, add_disk = > - let disks = ref [] and i = ref 0 in > + let...

...s not > > > based on libvirt XML. > > > --- > > > v2v/parse_libvirt_xml.ml | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/v2v/parse_libvirt_xml.ml b/v2v/parse_libvirt_xml.ml > > > index 78a6e71c0..dac99511c 100644 > > > --- a/v2v/parse_libvirt_xml.ml > > > +++ b/v2v/parse_libvirt_xml.ml > > > @@ -246,7 +246,7 @@ let parse_libvirt_xml ?conn xml = > > > (* Non-removable disk devices. *) > > > let disks = > > > let get_disks, add_disk = &gt...

An evolution of: https://www.redhat.com/archives/libguestfs/2018-August/msg00155.html