Displaying 2 results from an estimated 2 matches for "d_spawnv".
Did you mean:
__spawn
2020 Mar 22
2
Re: nbdkit / mingw support
Answering a few questions:
* Unclear why it's necessary to rename nbdkit-common.h -> nbdkit-compat.h
- It's not a rename, but a new file. nbdkit-compat.h is included for PE DLL
compatibility, and is included in nbdkit-common.h
* Functions are indirected through struct nbdkit_functions
_nbdkit_functions which I guess is necessary because of PE linking
(we've had similar
2020 Mar 21
4
nbdkit / mingw support
...above, because I
replaced -module -avoid-version -shared with $(SHARED_LDFLAGS),
adding -no-undefined additionally on mingw.
* Change to .gitignore is obviously fine, but I kept the file sorted:
https://github.com/libguestfs/nbdkit/commit/002da4f4ca279a798fea1bf8749558d643d7c186
* Defining -D_spawnv=spawnv seems OK, but should be a separate patch.
I didn't push anything.
* Unclear why AM_CONDITIONAL(MINGW) is needed. It doesn't seem to be
used anywhere unless I'm missing something. However if conditional
compilation for mingw is needed for something, then this would be fin...