search for: d_secure_scl

...but were necessary to correctly link LLVM >> libraries with Mesa3D on Windows. >> >> Jose >> > > Are you volontary trying to break everyone build (just to build your own > project), or have you no idea of the effect of this change: > > +add_llvm_definitions( -D_SECURE_SCL=0 ) > > While I personnaly use this flag in all my projects, it should not be > silently and sneakily imposed to all llvm user. You should make it an > option, and keep the default as it is currently. I.e. make this an opt-in > choice. > > While I may seem harsh, this flag chan...

Nice, very well done on the CMake build. This command worked perfectly: cmake -G "Visual Studio 8 2005" -DCMAKE_CXX_FLAGS="-D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_DEPRECATE -D_SECURE_SCL=0 -D_SCL_SECURE_NO_DEPRECATE -D_HAS_ITERATOR_DEBUGGING=0" ..\trunk > ..\build_log.txt And for the actual build, went very well. The INSTALL was much project was better then I was expecting (although did not install to a place I wanted it to, I guess that can be changed with another option...

...> They are quite trivial, but were necessary to correctly link LLVM > libraries with Mesa3D on Windows. > > Jose > > Are you volontary trying to break everyone build (just to build your own project), or have you no idea of the effect of this change: +add_llvm_definitions( -D_SECURE_SCL=0 ) While I personnaly use this flag in all my projects, it should not be silently and sneakily imposed to all llvm user. You should make it an option, and keep the default as it is currently. I.e. make this an opt-in choice. While I may seem harsh, this flag change the ABI !!! and its effects...

...t; default. (The flag is interesting because it can leads to great performance >> improvement in STL heavy code (up to x10 and more on particular code)). > > I use this for every bit of my code: >  /D_CRT_NONSTDC_NO_DEPRECATE /D_CRT_SECURE_NO_DEPRECATE > /D_CRT_SECURE_NO_WARNINGS /D_SECURE_SCL=0 /D_SCL_SECURE_NO_DEPRECATE > /D_HAS_ITERATOR_DEBUGGING=0 > > In one particular class in one of my libraries, the speed difference > is the difference of it running in about 10ms, compared to it running > in about 12 minutes, and yes that is accurate.  That is a lot greater > the...

Attached are two patches with MSVC build enchancements. They are quite trivial, but were necessary to correctly link LLVM libraries with Mesa3D on Windows. Jose -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Allow-to-build-against-static-MSVC-runtime.patch Type: text/x-patch Size: 2055 bytes Desc: not available URL:

...t gmail.com> writes: > Attached are two patches with MSVC build enchancements. > > They are quite trivial, but were necessary to correctly link LLVM > libraries with Mesa3D on Windows. [snip] > add_llvm_definitions( -D_SCL_SECURE_NO_DEPRECATE ) > + add_llvm_definitions( -D_SECURE_SCL=0 ) With this setting the default LLVM build becomes incompatible with libraries compiled with _SECURE_SCL=1 (which is the default setting). The right thing here is to use an option. > - add_llvm_definitions("/${LLVM_USE_CRT}") > + # http://www.cmake.org/Wiki/CMake_FAQ#How_c...

...provement in STL heavy code (up to x10 and more on particular >>>>>> code)). >>>>> >>>>> I use this for every bit of my code: >>>>>   /D_CRT_NONSTDC_NO_DEPRECATE /D_CRT_SECURE_NO_DEPRECATE >>>>> /D_CRT_SECURE_NO_WARNINGS /D_SECURE_SCL=0 /D_SCL_SECURE_NO_DEPRECATE >>>>> /D_HAS_ITERATOR_DEBUGGING=0 >>>>> >>>>> In one particular class in one of my libraries, the speed difference >>>>> is the difference of it running in about 10ms, compared to it running >>>>&gt...

On Mon, Nov 24, 2008 at 10:13 PM, Óscar Fuentes <ofv at wanadoo.es> wrote: > /* snip */ Thanks so much for that information. :) For note, this is my usual line I add to the end of my preprocessor definitions in *every* single project I ever open now (thanks to some very bad memories associated with not having them).

"Cory Nelson" <phrosty at gmail.com> writes: > On Mon, Nov 24, 2008 at 8:18 PM, Óscar Fuentes <ofv at wanadoo.es> wrote: >> OvermindDL1 <overminddl1 at gmail.com> writes: >>> As long as instructions are supplied on how to pass in user defined >>> macros to the build system. I have to turn off a lot of the extra >>> safety crap that