search for: d86762

...requiring people to opt-out via muting the thread, etc) >> >> Yes, we can conduct the "should we enable --warn-backrefs by default" >> conversation here. Since the semantics --warn-backrefs of are a bit >> complex, we need a documentation. https://reviews.llvm.org/D86762 is >> put up to get wording suggestions. Explicitly adding the people to the >> CC list... >> >> FWIW for many code bases, --warn-backrefs should produce no warnings >> (error if --fatal-warnings). For some code bases, GNU ld may error >> "undefined referenc...

On 2020-09-01, Petr Hosek wrote: >I see the GNU ld behavior as a limitation, not as a feature, as Peter Smith >also pointed out in https://reviews.llvm.org/D86762. While it can be argued >that there are certain cases where it can help detect layering >violations as you mentioned in your change, I'm not sure how valuable that >is in practice. Every case I've encountered so far either in Chrome or in >Fuchsia was a valid use case, most comm...

...Sep 1, 2020 at 5:35 PM Fāng-ruì Sòng via llvm-dev < >llvm-dev at lists.llvm.org> wrote: > >> On 2020-09-01, Petr Hosek wrote: >> >I see the GNU ld behavior as a limitation, not as a feature, as Peter >> Smith >> >also pointed out in https://reviews.llvm.org/D86762. While it can be >> argued >> >that there are certain cases where it can help detect layering >> >violations as you mentioned in your change, I'm not sure how valuable that >> >is in practice. Every case I've encountered so far either in Chrome or in >&gt...

...more an optional opt-in rather than requiring people to opt-out via muting the thread, etc) Yes, we can conduct the "should we enable --warn-backrefs by default" conversation here. Since the semantics --warn-backrefs of are a bit complex, we need a documentation. https://reviews.llvm.org/D86762 is put up to get wording suggestions. Explicitly adding the people to the CC list... FWIW for many code bases, --warn-backrefs should produce no warnings (error if --fatal-warnings). For some code bases, GNU ld may error "undefined reference". --warn-backrefs can catch such problems....

...>> >llvm-dev at lists.llvm.org> wrote: >> > >> >> On 2020-09-01, Petr Hosek wrote: >> >> >I see the GNU ld behavior as a limitation, not as a feature, as Peter >> >> Smith >> >> >also pointed out in https://reviews.llvm.org/D86762. While it can be >> >> argued >> >> >that there are certain cases where it can help detect layering >> >> >violations as you mentioned in your change, I'm not sure how valuable >> that >> >> >is in practice. Every case I've enco...

...l layering check tool. I just wrote a documentation about the advantage (of GNU ld's archive selection semantics..... But we can do better with --warn-backrefs! GNU ld just reports "undefined reference" with no actionable feedback about the offending archive) https://reviews.llvm.org/D86762 I am wondering whether in the next release we can make --warn-backrefs the default. I have added many known users to the review. (There is no need for --no-warn-backrefs because --warn-backrefs-exclude='*' does the same job)

...t;> >> > >> >> >> On 2020-09-01, Petr Hosek wrote: >> >> >> >I see the GNU ld behavior as a limitation, not as a feature, as >> Peter >> >> >> Smith >> >> >> >also pointed out in https://reviews.llvm.org/D86762. While it can >> be >> >> >> argued >> >> >> >that there are certain cases where it can help detect layering >> >> >> >violations as you mentioned in your change, I'm not sure how >> valuable >> >> that >>...

...t;> >> On 2020-09-01, Petr Hosek wrote: >>>> >> >> >I see the GNU ld behavior as a limitation, not as a feature, as >>>> Peter >>>> >> >> Smith >>>> >> >> >also pointed out in https://reviews.llvm.org/D86762. While it >>>> can be >>>> >> >> argued >>>> >> >> >that there are certain cases where it can help detect layering >>>> >> >> >violations as you mentioned in your change, I'm not sure how >>>>...