search for: d83088

...aps a `Value *` for LLVM IR but a `Register` for MachineIR), and b) querying the CFG via virtual methods in a CfgInterface interface class. Please take a look at the following Phabricator reviews and related changes you can navigate to via the "Stack" tab: 1. https://reviews.llvm.org/D83088: Introduces the classes and templates that enable this new way of writing analyses (CfgTraits, CfgInterface, CfgInterfaceImpl<CfgTraitsT>, ...). 2. https://reviews.llvm.org/D83089: Refactors the dominator tree implementation so that algorithms that operate on CfgBlockRef will be able to...

...), and >> >> b) querying the CFG via virtual methods in a CfgInterface interface class. >> >> Please take a look at the following Phabricator reviews and related >> changes you can navigate to via the "Stack" tab: >> >> 1. https://reviews.llvm.org/D83088: Introduces the classes and templates >> that enable this new way of writing analyses (CfgTraits, CfgInterface, >> CfgInterfaceImpl<CfgTraitsT>, ...). >> >> 2. https://reviews.llvm.org/D83089: Refactors the dominator tree >> implementation so that algorithms that...

...tor than just GitHub PRs by themselves. On Mon, Sep 14, 2020 at 3:14 PM Nicolai Hähnle via cfe-dev < cfe-dev at lists.llvm.org> wrote: > Hi Stephen, > > Here's a real-life example of reviews that GitHub doesn't properly > support to my knowledge: https://reviews.llvm.org/D83088, look for > "Stack" under "Revision Contents". > > The key here is that there's a sequence of commits that's partially > dependent on each other, so that reviewing each one individually is > suboptimal, but at the same time you really don't want to be...

...Sep 14, 2020 at 3:14 PM Nicolai Hähnle via cfe-dev < >> cfe-dev at lists.llvm.org> wrote: >> >>> Hi Stephen, >>> >>> Here's a real-life example of reviews that GitHub doesn't properly >>> support to my knowledge: https://reviews.llvm.org/D83088, look for >>> "Stack" under "Revision Contents". >>> >>> The key here is that there's a sequence of commits that's partially >>> dependent on each other, so that reviewing each one individually is >>> suboptimal, but at the sa...

The LLVM incubator projects have been using github PRs for reviews and so far haven't really seen any significant issues. The biggest confusion so far has not been with reviews but with the difference between "rebase and merge" and "squash and mere". We have used basically 3 different processes: Method 1: start a review with one commit on a new branch (typically in a