Displaying 2 results from an estimated 2 matches for "d81267".
2020 Jul 21
4
Phabricator sending spurious "This revision was not accepted when it landed" emails
...iced Phabricator sending emails saying:
This revision was not accepted when it landed; it landed in state
"Needs Review".
when the review clearly has been accepted by someone?
Some recent examples:
https://reviews.llvm.org/D83952
https://reviews.llvm.org/D80116
https://reviews.llvm.org/D81267
Thanks,
Jay.
2020 Jul 21
4
Phabricator sending spurious "This revision was not accepted when it landed" emails
...is was committed with extra
> changes" but not "This was committed without review".
>
> Do you have any examples that didn't have post-approval-pre-commit changes
> that still got this annotation about being committed without review?
>
> https://reviews.llvm.org/D81267
>
>
> Last one seems more clear - one of the reviewers (rupprecht) still had the
> review marked "requires changes", so it was committed without closure on
> that
>
Indeed this one shows the message:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200713/8075...