Displaying 3 results from an estimated 3 matches for "d80947".
2020 Jun 15
9
Codifying our Brace rules-
...ed that our "omit braces with single line blocks" rule wasn't written down! Additionally, as a group on IRC and in review, noticed that the enforcement of this rule has been extremely inconsistent. We made a first run at codifying our existing practice here: https://reviews.llvm.org/D80947, which was then committed after significant time on llvm-commits.
I would like to encourage the list via discussion and further reviews/commits to come to a consensus on what we actually MEAN by this rule. For example, a recent comment points out that :
If (cond)
Stmt;
else if (cond)
Stmt;
e...
2020 Jun 15
2
Codifying our Brace rules-
...ks ago I noticed that our “omit braces with single line blocks” rule wasn’t written down! Additionally, as a group on IRC and in review, noticed that the enforcement of this rule has been extremely inconsistent. We made a first run at codifying our existing practice here: https://reviews.llvm.org/D80947, which was then committed after significant time on llvm-commits.
>>
>>
>>
>> I would like to encourage the list via discussion and further reviews/commits to come to a consensus on what we actually MEAN by this rule. For example, a recent comment points out that :
>>...
2020 Jun 16
3
Codifying our Brace rules-
...at our “omit braces with single line blocks”
> rule wasn’t written down! Additionally, as a group on IRC and in review,
> noticed that the enforcement of this rule has been extremely inconsistent.
> We made a first run at codifying our existing practice here:
> https://reviews.llvm.org/D80947, which was then committed after
> significant time on llvm-commits.
>
> I would like to encourage the list via discussion and further
> reviews/commits to come to a consensus on what we actually MEAN by this
> rule. For example, a recent comment points out that :
>
> If (cond)...