Displaying 2 results from an estimated 2 matches for "d7e202ec".
Did you mean:
7e2a2ec
2019 Jul 31
0
[nbdkit PATCH 8/8] rate: Atomically set CLOEXEC on fds
...@ maybe_adjust (const char *file, struct bucket *bucket, pthread_mutex_t *lock)
if (!file) return;
- fp = fopen (file, "r");
+ fp = fopen (file, "re");
if (fp == NULL)
return; /* this is not an error */
diff --git a/server/utils.c b/server/utils.c
index eabef200..d7e202ec 100644
--- a/server/utils.c
+++ b/server/utils.c
@@ -236,6 +236,10 @@ nbdkit_read_password (const char *value, char **password)
}
/* Read password from a file. */
+ /* Note: If the unit test for this fails because fopen("re") is
+ * unsupported by a given system, you must also f...
2019 Jul 31
13
[nbdkit PATCH 0/8] fd leak safety
There's enough here to need a review; some of it probably needs
backporting to stable-1.12.
This probably breaks tests on Haiku or other platforms that have not
been as on-the-ball about atomic CLOEXEC; feel free to report issues
that arise, and I'll help come up with workarounds (even if we end up
leaving a rare fd leak on less-capable systems).
Meanwhile, I'm still working on my