search for: d79698

...s case, @ __sancov_gen_.1 is a part of comdat group $_ZN3Foo10inline_fooEv but is being referenced by a symbol in comdat group $_ZN3Foo10public_fooEv. We’re seeing this when building libc on fuchsia which uses the new pass manager. The commit that seemed to trigger this is https://reviews.llvm.org/D79698 which (I believe) would run the Sancov pass before optimizations, and potentially cause inlining of @__sancov_gen_.1 into functions outside of the comdat group it’s defined in. Is this explanation correct? To be consistent with the compiler’s behavior, we could: 1. Change the instrumentat...