Displaying 3 results from an estimated 3 matches for "d69922".
Did you mean:
369922
2020 Jan 15
2
[cfe-dev] Phabricator -> GitHub PRs?
On 01/15, Nicolai Hähnle via cfe-dev wrote:
> On Tue, Jan 14, 2020 at 11:41 AM Renato Golin <rengolin at gmail.com> wrote:
> > We rarely approve some patches and not others in a series, and when we
> > do, we ask people to create a new series without the approved patch,
> > or split them, so that we can continue reviewing the series.
>
> This has simply not been
2020 Jan 16
4
[cfe-dev] Phabricator -> GitHub PRs?
...get arcanist to work. Does arcanist take
> care of organizing the series?
>
(I haven't made patch series myself)
> How do reviews work? Does each patch get a separate review page like
> any other patch?
>
Yes, see https://reviews.llvm.org/D69785 and https://reviews.llvm.org/D69922 as
an example of two patches in a series.
> Let's say patch 3 in a series is approved and it could be committed
> without patches 1 and 2 (like Renato I question why this is a patch
> series if so, but let's assume it for argument's sake). That means I
> need to rebase -i...
2020 Jan 15
4
[cfe-dev] Phabricator -> GitHub PRs?
On Wed, Jan 15, 2020 at 01:30:34PM -0600, David Greene via cfe-dev wrote:
> Emilio Cobos Álvarez <emilio at crisal.io> writes:
>
> > [1] or [2] are recentish examples that come to mind, but it happens
> > fairly often. Of course for a bunch of simpler changes one revision is
> > enough.
>
> I think you forgot to include links. :)
>
> > The use cases