search for: d69785

...nally have series where major > redesigns are required, and then asking for a fresh start makes sense. There is an (ever growing) patch series that connects contributions by multiple people with patches in all sorts of states, from merged to WIP: The first was this one https://reviews.llvm.org/D69785, since then the series grew in all directions (see the stack). I have other (=smaller) patch series that evolve over time but this one is the biggest and most complex. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature...

...his is a controversial RFC, we will provide examples and reasons. I hope this is fairly straightforward as this does not introduce any drawbacks (I know of). Please let me know if you have an opinion on this. Thanks, Johannes [0] https://reviews.llvm.org/D69853 [1] https://reviews.llvm.org/D69785 [2] https://reviews.llvm.org/D70109 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191113/0d15ef4f/attachment.sig&gt...

...rd as this does not introduce any >> drawbacks (I know of). >> >> Please let me know if you have an opinion on this. >> >> Thanks, >> Johannes >> >> >> >> >> [0] https://reviews.llvm.org/D69853 >> [1] https://reviews.llvm.org/D69785 >> [2] https://reviews.llvm.org/D70109 >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> > ___________________________________________...

...ot introduce any > > drawbacks (I know of). > > > > Please let me know if you have an opinion on this. > > > > Thanks, > > Johannes > > > > > > > > > > [0] https://reviews.llvm.org/D69853 > > [1] https://reviews.llvm.org/D69785 > > [2] https://reviews.llvm.org/D70109 > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > -- Johannes Doerfert Researcher Argonne Na...

On Fri, 10 Jan 2020 at 13:43, Nicolai Hähnle via llvm-dev <llvm-dev at lists.llvm.org> wrote: > It's worth pointing out that GitHub is not able to do this properly, > either. The problem on GitHub's side is that while a pull request can > contain multiple commits, one cannot properly review those commits > individually, and it is not at all possible to approve individual

...#39;ve mentioned before I can't get arcanist to work. Does arcanist take > care of organizing the series? > (I haven't made patch series myself) > How do reviews work? Does each patch get a separate review page like > any other patch? > Yes, see https://reviews.llvm.org/D69785 and https://reviews.llvm.org/D69922 as an example of two patches in a series. > Let's say patch 3 in a series is approved and it could be committed > without patches 1 and 2 (like Renato I question why this is a patch > series if so, but let's assume it for argument's sake)....

On Wed, Jan 15, 2020 at 01:30:34PM -0600, David Greene via cfe-dev wrote: > Emilio Cobos Álvarez <emilio at crisal.io> writes: > > > [1] or [2] are recentish examples that come to mind, but it happens > > fairly often. Of course for a bunch of simpler changes one revision is > > enough. > > I think you forgot to include links. :) > > > The use cases