Displaying 2 results from an estimated 2 matches for "d59802".
2019 Apr 05
2
[RFC] Should we add isa_or_null<>?
...ther style so we know we should migrate those to the new one.
>
I have a checker under review that could be enhanced to do that -- though
it currently replaces `X->foo() && isa<Y>(X->foo())` with
`dyn_cast_or_null<Y>(X->foo())`.
Please see: https://reviews.llvm.org/D59802
thanks...
don
>
> ~Craig
>
>
> On Thu, Apr 4, 2019 at 4:37 PM Don Hinton <hintonda at gmail.com> wrote:
>
>> On Thu, Apr 4, 2019 at 6:29 PM Craig Topper <craig.topper at gmail.com>
>> wrote:
>>
>>> There are a handful of places in LLVM tha...
2019 Apr 04
2
[RFC] Should we add isa_or_null<>?
On Thu, Apr 4, 2019 at 6:29 PM Craig Topper <craig.topper at gmail.com> wrote:
> There are a handful of places in LLVM that dosomething like if
> (dyn_cast_or_null<UndefValue>(P->hasConstantValue()))
>
Yes, I've seen those, but while working on a new checker, I was advised
that replacing `X && isa<Y>(X)` with `dyn_cast_or_null<Y>(X)` was