Displaying 3 results from an estimated 3 matches for "d54153".
2019 Jan 14
5
Removing LLVM_ALWAYS_INLINE from ADT classes
...comes with any fundamental objections or there are technical
> hurdles down the road.
>
So, personally I feel strongly that LLVM_OPTIMIZED_TABLEGEN should be off
by default, since the it splits up the ninja build graph. We've also run
into issues with it with VS: https://reviews.llvm.org/D54153 Shelling out
to `cmake --build` as part of a build action doesn't seem to work very well
for many generators.
What actually blocks us from removing these always_inline attributes? When
I read this thread, I didn't get the sense that debug build tablegen
performance was actually important...
2019 Jan 16
2
Removing LLVM_ALWAYS_INLINE from ADT classes
...ere are technical
> >> hurdles down the road.
> >
> >
> > So, personally I feel strongly that LLVM_OPTIMIZED_TABLEGEN should be
> off by default, since the it splits up the ninja build graph. We've also
> run into issues with it with VS: https://reviews.llvm.org/D54153
> Shelling out to `cmake --build` as part of a build action doesn't seem to
> work very well for many generators.
> >
> > What actually blocks us from removing these always_inline attributes?
> When I read this thread, I didn't get the sense that debug build tablegen
&g...
2019 Jan 10
2
Removing LLVM_ALWAYS_INLINE from ADT classes
On Thu, Jan 10, 2019 at 1:20 PM Davide Italiano <davide at freebsd.org> wrote:
>
> On Wed, Jan 9, 2019 at 2:18 PM Davide Italiano <davide at freebsd.org> wrote:
> >
> > On Wed, Jan 9, 2019 at 9:38 AM Mehdi AMINI <joker.eph at gmail.com> wrote:
> > >
> > >
> > >
> > > On Fri, Jan 4, 2019 at 3:15 PM Davide Italiano via llvm-dev