search for: d48013

Displaying 3 results from an estimated 3 matches for "d48013".

Did you mean: 48013
2020 Jan 15
3
[cfe-dev] Phabricator -> GitHub PRs?
...d > features and why. For example, what drives the need for patch series > and dependence relationships? Some walk-through examples would be very > helpful. Here's a somewhat more complex example of changes made by myself a year and a half ago, starting with https://reviews.llvm.org/D48013 It's a series of changes across TableGen and the AMDGPU backend to refactor how we represent a class of instructions. Some patterns that occur: - an NFC (no functional change) refactoring/rename change in an area that is then later touched by a functional change. - a change to common infrastru...
2020 Jan 15
3
[cfe-dev] Phabricator -> GitHub PRs?
On 01/15, Emilio Cobos Álvarez wrote: > On 1/8/20 2:15 AM, Bill Wendling via cfe-dev wrote: > > It's not hyperbole, but fine. How do you use it to keep multiple, > > related changes in order? The interface for reviewing and responding to > > reviews is horrific, e.g. quoting text from a review is rather bad, the > > email it sends is badly formatted and hard to
2020 Jan 16
2
[cfe-dev] Phabricator -> GitHub PRs?
..., 2020 at 1:45 PM David Greene via cfe-dev < cfe-dev at lists.llvm.org> wrote: > Nicolai Hähnle <nhaehnle at gmail.com> writes: > > > Here's a somewhat more complex example of changes made by myself a > > year and a half ago, starting with https://reviews.llvm.org/D48013 > > Aha! I found it! The "Stack" tab under "Revision Contents" after all > of the review comments. That's *really* not obvious if there are lots > of review comments to scroll through. > > So if I'm understanding this correctly, there are 17 commits...