search for: d46595

...*separate* folds within instcombine, each tested on it's own, (much like clang-tidy checks vs monolithic clang diagnostics) and then somehow combined, not unlike the usual optimization pipelines. The second problem is the size/complexity of the instcombine pass. I do acknowledge that D46336 / D46595 (both in instcombine) is an improvement, which results in more folds that didn't happen before. But it makes the already-large inscombine even more complex, and i'm not sure how it affects the performance. Then there is D45842. That code is pretty simple, and takes ~one page. It does not d...

> On May 8, 2018, at 9:50 AM, Daniel Berlin via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > 1. The reassociate pass that exists right now was *originally* (AFAIK) written to enable CSE/GVN to do better. Agreed. The original mindset included a (naive) belief that going with a canonical form was better than teaching redundancy elimination to handle abstractions (as a matter