search for: d44560

>> In my particular case from https://reviews.llvm.org/D44560, I currently >> test the following 3 different cases across the full set of DWARF >> versions and formats: >>  - Parsing a valid line table >>  - Emitting an error if the stated prologue length is greater than the >> actual length >>  - Emitting an error if th...

...be some benefit in it, although > I admit that I haven't looked to make sure that this is a reasonable > request there. > > James > > On 20 March 2018 at 20:30, <paul.robinson at sony.com> wrote: > >> >> In my particular case from https://reviews.llvm.org/D44560, I >> currently >> >> test the following 3 different cases across the full set of DWARF >> >> versions and formats: >> >> - Parsing a valid line table >> >> - Emitting an error if the stated prologue length is greater than the >> >&gt...

..., so it still seems like there would be some benefit in it, although I admit that I haven't looked to make sure that this is a reasonable request there. James On 20 March 2018 at 20:30, <paul.robinson at sony.com> wrote: > >> In my particular case from https://reviews.llvm.org/D44560, I currently > >> test the following 3 different cases across the full set of DWARF > >> versions and formats: > >> - Parsing a valid line table > >> - Emitting an error if the stated prologue length is greater than the > >> actual length > >&...

...whole space of combinatorial testing should be > carefully discussed. Seems like a high risk of long-running tests w/o > providing much incremental value. > These are fair comments, and probably should be judged on a case-by-case basis. In my particular case from https://reviews.llvm.org/D44560, I currently test the following 3 different cases across the full set of DWARF versions and formats: - Parsing a valid line table - Emitting an error if the stated prologue length is greater than the actual length - Emitting an error if the stated prologue length is shorter than the actual le...

...>> I admit that I haven't looked to make sure that this is a reasonable >> request there. >> >> James >> >> On 20 March 2018 at 20:30, <paul.robinson at sony.com> wrote: >> >>> >> In my particular case from https://reviews.llvm.org/D44560, I >>> currently >>> >> test the following 3 different cases across the full set of DWARF >>> >> versions and formats: >>> >> - Parsing a valid line table >>> >> - Emitting an error if the stated prologue length is greater than...

On Thu, Mar 15, 2018 at 11:10 AM David Blaikie via llvm-dev < llvm-dev at lists.llvm.org> wrote: > +Chandler who might have some thoughts on this. > FWIW, I have no concerns about updating to a modern googletest. More modern the better IMO if someone is willing to do the work to make sure it works on all our platforms, etc. However: > Could you provide an example here of the