Displaying 13 results from an estimated 13 matches for "d44464".
2018 Mar 22
2
Opt Bisect layering
...lvm-dev at lists.llvm.org>;
Friedman, Eli <efriedma at codeaurora.org>
*Subject:* Re: [llvm-dev] Opt Bisect layering
There is a patch under review right now from someone who wants to provide a
mechanism to replace OptBisect as the pass gate keeping mechanism.
https://reviews.llvm.org/D44464
Possibly we could take this opportunity to move OptBisect to a different
layer, though I don’t know where else it would belong.
The other possibility is that we could have the caller pass in a
description instead of a pointer to the pass and the IR unit. OptBisect
isn’t doing anything with th...
2018 Mar 29
0
Opt Bisect layering
...<efriedma at codeaurora.org>
> *Subject:* Re: [llvm-dev] Opt Bisect layering
>
>
>
> There is a patch under review right now from someone who wants to provide
> a mechanism to replace OptBisect as the pass gate keeping mechanism.
>
>
>
> https://reviews.llvm.org/D44464
>
>
>
> Possibly we could take this opportunity to move OptBisect to a different
> layer, though I don’t know where else it would belong.
>
>
>
> The other possibility is that we could have the caller pass in a
> description instead of a pointer to the pass and the IR...
2018 Mar 29
2
Opt Bisect layering
...> *Subject:* Re: [llvm-dev] Opt Bisect layering
>>
>>
>>
>> There is a patch under review right now from someone who wants to provide
>> a mechanism to replace OptBisect as the pass gate keeping mechanism.
>>
>>
>>
>> https://reviews.llvm.org/D44464
>>
>>
>>
>> Possibly we could take this opportunity to move OptBisect to a different
>> layer, though I don’t know where else it would belong.
>>
>>
>>
>> The other possibility is that we could have the caller pass in a
>> description inst...
2018 Apr 03
0
Opt Bisect layering
...org>
> Subject: Re: [llvm-dev] Opt Bisect layering
>
>
>
> There is a patch under review right now from someone who
wants to provide a mechanism to replace OptBisect as the pass gate
keeping mechanism.
>
>
>
> https://reviews.llvm.org/D44464
>
>
>
> Possibly we could take this opportunity to move OptBisect to
a different layer, though I don’t know where else it would belong.
>
>
>
> The other possibility is that we could have the caller pass
in a description instead of a pointer to the...
2018 Apr 03
2
Opt Bisect layering
...t Bisect layering
> >
> >
> >
> > There is a patch under review right now from someone who
> wants to provide a mechanism to replace OptBisect as the pass gate
> keeping mechanism.
> >
> >
> >
> > https://reviews.llvm.org/D44464
> >
> >
> >
> > Possibly we could take this opportunity to move OptBisect to
> a different layer, though I don’t know where else it would belong.
> >
> >
> >
> > The other possibility is that we could have the caller pass
&g...
2018 Apr 03
0
Opt Bisect layering
...> >
> > There is a patch under review right now from someone who
> wants to provide a mechanism to replace OptBisect as the pass gate
> keeping mechanism.
> >
> >
> >
> > https://reviews.llvm.org/D44464
> >
> >
> >
> > Possibly we could take this opportunity to move
OptBisect to
> a different layer, though I don’t know where else it would belong.
> >
> >
> >
> > The other possib...
2018 May 06
0
Need guidance to work on NEW PASS managers bugs
...ounter in
skipFunction()/skipModule() etc method.
- There is already FIXME: added for moving getDescription() from OptBisect
class to respective
IR units like Loop, Region etc. So that new pass manager can also use
those methods.
- However to support feature added in this https://reviews.llvm.org/D44464
we may need to add a callback function
pointer that can be set and if present use it instead for normal counter
value check to decide if a pass should
be executed or not. Or some other mechanism to provide this feature.
- I am not completely sure but if we are able provide custom callback
featu...
2018 Apr 03
2
Opt Bisect layering
...; There is a patch under review right now from someone who
> > wants to provide a mechanism to replace OptBisect as the pass gate
> > keeping mechanism.
> > >
> > >
> > >
> > > https://reviews.llvm.org/D44464
> > >
> > >
> > >
> > > Possibly we could take this opportunity to move
> OptBisect to
> > a different layer, though I don’t know where else it would belong.
> > >
> > >
> > &...
2018 Mar 21
2
Opt Bisect layering
So I'm poking around trying to improve the layering of LLVM (using an
internal strict modular build as a motivation/tool to identify issues) &
came across a layering violation in the OptBisect implementation.
This feature is implemented in lib/IR, but includes several headers from
include/llvm/Analysis - which would create a circular dependency if not for
the fact that all the headers it
2018 May 03
2
Opt Bisect layering
...someone who
> > wants to provide a mechanism to replace OptBisect as
> the pass gate
> > keeping mechanism.
> > >
> > >
> > >
> > > https://reviews.llvm.org/D44464
> > >
> > >
> > >
> > > Possibly we could take this opportunity to move
> OptBisect to
> > a different layer, though I don’t know where else it
> would belong...
2018 Apr 23
0
Opt Bisect layering
...ch under review right now from someone who
>> > wants to provide a mechanism to replace OptBisect as the pass gate
>> > keeping mechanism.
>> > >
>> > >
>> > >
>> > > https://reviews.llvm.org/D44464
>> > >
>> > >
>> > >
>> > > Possibly we could take this opportunity to move
>> OptBisect to
>> > a different layer, though I don’t know where else it would belong.
>> > >
>>...
2018 May 02
2
Need guidance to work on NEW PASS managers bugs
As a point of clarification, optnone is already being handled by the pass itself in the legacy implementation. The skip[IR unit] functions are provided by the pass base classes, and the attribute is checked there. This happens any time the legacy wrapper is run, no matter how it is run.
Regarding the opt-bisect design, I’m not particularly fond of the managed static either, but I do want to
2018 May 07
1
Need guidance to work on NEW PASS managers bugs
...skipModule() etc method.
> - There is already FIXME: added for moving getDescription() from OptBisect
> class to respective
> IR units like Loop, Region etc. So that new pass manager can also use
> those methods.
> - However to support feature added in this https://reviews.llvm.org/D44464
> we may need to add a callback function
> pointer that can be set and if present use it instead for normal counter
> value check to decide if a pass should
> be executed or not. Or some other mechanism to provide this feature.
> - I am not completely sure but if we are able prov...