search for: d43729

...first set of bugs people have found wrt to very start/end of blocks, or bb == predbb issues. On Sat, Feb 24, 2018 at 12:58 PM, Fedor Indutny via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Update: > > I was able to make progress on it today ( See https://reviews.llvm.org/ > D43729 ). Apparently my problems were: > > * Iterating through the instruction/block list after erasing > block/instruction > * Trying to split block after removing one predecessor > > Regarding the latter, it appears that semantics of ` > DuplicateInstructionsInSplitBetween` change s...

Hello! I've discovered that `CallSiteSplitting` optimization doesn't support musttail calls. The easiest fix as it stands is disabling it for such call sites: https://reviews.llvm.org/D43729 . However, I'm not happy with such contribution. My more sophisticated attempt has failed due to my poor understanding of llvm internals. Here is the attempted patch: https://gist.github.com/indutny/240c33522563ebd633613a903479d5e6 I'd greatly appreciate any help with it. Just in case, t...

...ws.llvm.org/D43822 > > On Sat, Feb 24, 2018 at 12:58 PM, Fedor Indutny via llvm-dev > <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > Update: > > I was able to make progress on it today ( See > https://reviews.llvm.org/D43729 <https://reviews.llvm.org/D43729> ). > Apparently my problems were: > Great, thanks for putting up a patch for that. It made good progress already and I left a few more comments directly over there. Cheers, Florian

Update: I was able to make progress on it today ( See https://reviews.llvm.org/D43729 ). Apparently my problems were: * Iterating through the instruction/block list after erasing block/instruction * Trying to split block after removing one predecessor Regarding the latter, it appears that semantics of `DuplicateInstructionsInSplitBetween` change significantly in such case, and it...