search for: d42850

...uperclass’s definition applied to the subclass, then a >> comment is confusing. > > +1 Thanks everyone, I'm in full agreement but thought I'd check as there are quite a few instances of copied comments in the current codebase. Patch submitted for review https://reviews.llvm.org/D42850 Best, Alex

On 01/31/2018 02:37 AM, David Chisnall via llvm-dev wrote: > On 30 Jan 2018, at 19:56, Alex Bradbury via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> Is this bad style? It seems the current codebase is inconsistent on >> this point. The upside of such duplication is that it reduces the need >> to cross-reference to other files when using a dumb editor. > I

On 30 Jan 2018, at 19:56, Alex Bradbury via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Is this bad style? It seems the current codebase is inconsistent on > this point. The upside of such duplication is that it reduces the need > to cross-reference to other files when using a dumb editor. I generally use the rendered docs on the LLVM web site when using a dumb editor, so