search for: d4178

...t send email unless there is text typed into one of the boxes Manuel, but I think we should by default put some text into a box (and send the email unless the user deletes that text) when accepting a revision. Otherwise, the final LGTM can accidentally happen on Phab and not reach the mailing list (D4178 for example). Thoughts? -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140627/02e483e2/attachment.html>

...s text typed into one of the boxes Manuel, but I think >> we should by default put some text into a box (and send the email unless the >> user deletes that text) when accepting a revision. Otherwise, the final LGTM >> can accidentally happen on Phab and not reach the mailing list (D4178 for >> example). >> >> Thoughts? >> > > Is there any reason not to have accepts always send an email? > > - Michael Spencer If it's possible to make "accept" send an email with the text "LGTM", that would design away another source of...

...t send email unless there is text typed into one of the boxes Manuel, but I think we should by default put some text into a box (and send the email unless the user deletes that text) when accepting a revision. Otherwise, the final LGTM can accidentally happen on Phab and not reach the mailing list (D4178 for example). > > Thoughts? > > I had hoped we can educate people using phab that only text they write gets sent to the list, and that they should only send things to the list, and not manage the state in phab. Is there a way of disabling the state management interface in phab entire...