Displaying 2 results from an estimated 2 matches for "d37253".
Did you mean:
d37259
2022 Nov 11
1
Memory leak, make_absolute_pwd_glob
...to
the FreeBSD base system. It complains that calls like "path1 =
make_absolute_pwd_glob(path1, *pwd);" in sftp.c leak the allocation.
All make_absolute_pwd_glob() calls but one are of that form, so
perhaps have it consume and free the first arg, as below (and
https://reviews.freebsd.org/D37253)?
diff --git a/crypto/openssh/sftp.c b/crypto/openssh/sftp.cindex
c3c347e087e4..630e7773af75 100644
--- a/crypto/openssh/sftp.c
+++ b/crypto/openssh/sftp.c
@@ -621,14 +621,14 @@ escape_glob(const char *s)
}
static char *
-make_absolute_pwd_glob(const char *p, const char *pwd)
+make_absolute_pwd...
2023 Mar 21
1
Memory leak, make_absolute_pwd_glob
...1 =
> make_absolute_pwd_glob(path1, *pwd);" in sftp.c leak the allocation.
I see this same issue has since been reported by Coverity upstream and
fixed in 36c6c3eff5e4, but that change still missed all of the other
leaks addressed by my change.
Updated patch in https://reviews.freebsd.org/D37253