Displaying 4 results from an estimated 4 matches for "d28624".
Did you mean:
28624
2017 Jan 26
2
Critical XRay fixes for Arm32
...e.rogatch at gmail.com>
>> >> wrote:
>> >>>
>> >>> Hi Dean, Renato,
>> >>>
>> >>> AFAIK, unfortunately, these critical Arm32 XRay fixes are not yet in
>> >>> 4.0:
>> >>> https://reviews.llvm.org/D28624 , https://reviews.llvm.org/D28623 .
>> >>> The
>> >>> first repairs XRay instrumentation map emission. Without this map XRay
>> >>> doesn't work at all: the runtime doesn't see anything to instrument.
>> >>> The
>> >>&g...
2017 Jan 26
2
Critical XRay fixes for Arm32
...Dean agrees, as I believe he's the code owner.
Thanks,
Hans
On Thu, Jan 26, 2017 at 11:47 AM, Serge Rogatch <serge.rogatch at gmail.com> wrote:
> There were no LLVM tests for presence of XRay instrumentation map in the
> emitted assembly. You can see that https://reviews.llvm.org/D28624 adds this
> check to the tests.
> The tests in compiler-rt had been accidentally disabled.
> https://reviews.llvm.org/D28623 enables them in
> compiler-rt/test/xray/lit.cfg .
>
> On 26 January 2017 at 22:37, Hans Wennborg <hans at chromium.org> wrote:
>>
>> I'...
2017 Jan 26
2
Critical XRay fixes for Arm32
Sorry, I initially included LLVM-Commits rather than LLVM-Dev. Fixed.
On 26 January 2017 at 03:26, Serge Rogatch <serge.rogatch at gmail.com> wrote:
> Hi Dean, Renato,
>
> AFAIK, unfortunately, these critical Arm32 XRay fixes are not yet in 4.0:
> https://reviews.llvm.org/D28624 , https://reviews.llvm.org/D28623 . The
> first repairs XRay instrumentation map emission. Without this map XRay
> doesn't work at all: the runtime doesn't see anything to instrument. The
> second fixes the CPU cache incoherency problem. Without this patch, XRay
> will intermitt...
2017 Jan 26
2
Critical XRay fixes for Arm32
...Fixed.
>>
>> On 26 January 2017 at 03:26, Serge Rogatch <serge.rogatch at gmail.com>
>> wrote:
>>>
>>> Hi Dean, Renato,
>>>
>>> AFAIK, unfortunately, these critical Arm32 XRay fixes are not yet in 4.0:
>>> https://reviews.llvm.org/D28624 , https://reviews.llvm.org/D28623 . The
>>> first repairs XRay instrumentation map emission. Without this map XRay
>>> doesn't work at all: the runtime doesn't see anything to instrument. The
>>> second fixes the CPU cache incoherency problem. Without this patch,...